From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id oA0QLnSDy2Ll0QAAbAwnHQ (envelope-from ) for ; Mon, 11 Jul 2022 03:57:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id AB/MLXSDy2LP5wAAauVa8A (envelope-from ) for ; Mon, 11 Jul 2022 03:57:08 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6606E176E8 for ; Mon, 11 Jul 2022 03:57:08 +0200 (CEST) Received: from localhost ([::1]:39812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oAifb-0006ko-Hi for larch@yhetil.org; Sun, 10 Jul 2022 21:57:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45446) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oAif2-0006ke-Ur for emacs-orgmode@gnu.org; Sun, 10 Jul 2022 21:56:32 -0400 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]:35585) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oAif1-0004wb-9r for emacs-orgmode@gnu.org; Sun, 10 Jul 2022 21:56:32 -0400 Received: by mail-pg1-x532.google.com with SMTP id r22so3555341pgr.2 for ; Sun, 10 Jul 2022 18:56:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=rECymbvt+wR+wxXU0YSrzNypB0SOgTh49rJckDwlTxc=; b=JcaKe8yhYwhevAvzn6P1NTu5byHBt/MlynxAYnlJuam6nfxZV6plX2CUvQ1qTqSI0/ Tm5iX/cme5j1cv3+B+JIHwucvIPZbz7S8/cn9bjTrXZdwCCR/+9uBLcjuernO6gbpl65 R6Huj1upodAYMmZFCOpY1ntsU3hsmYllGE7tAjxfgah5eoVfxULibUOFZGRVom68oqC/ VnlHlTEPsKCKZ4jK/PcKc0R8muBbvzsBT/gfmlpNeofonxlWhDUyEjTJR01QPW3ZQXaD 5U7QiJbMtnMUwLBfjQFdYGkgWyQopknO89d7VUoLvgC3j9eQ4cFcbR90jrhVz598YytB XzEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=rECymbvt+wR+wxXU0YSrzNypB0SOgTh49rJckDwlTxc=; b=WWHQsXGsjYeJ2M/cTfFBxukaoMl4ImWS34AMLAVywVm7hwPhYnvQtC3EqH3Ns0PxDA KTzYi6a/EST7GQu4w2LV0od/3uye9zGRQZ20etTjMl7fGC2mZV4wdYByLSoFuTyEz0Sw l3MpgLLhzuUTjR5ca9HHBFzdgAtwuhVEwvgNIpIjkdNcmsaM8pF72Nt2k8wCkFenfesG 5Jih8y5x2EltZrBw7YL8sWECXzarb/qcpfvKnU8R4AGEUb93G6vpqMpyjh1iqz9L1rm7 THKBi0OVineqsJNK/McUfA0bt5bDbSd7gyIKvkFRZa9Q70bUCjia5HUP3aAg5Kg31fmw iZ9A== X-Gm-Message-State: AJIora+s/DHoCt9rZzefImhtmuLAtS5y91MJ7kVxCzf/Aqg9pTv70gEn vVPunSR0SrdHQyhIXkTZKn4= X-Google-Smtp-Source: AGRyM1stGguiWYs/mFunA8zsIRankW2Uf/p6tG/qiOhx1aMxJn4QFExPT9rMVK24/p11A+XXMAPfAg== X-Received: by 2002:a63:6c81:0:b0:3fd:4be3:8ee9 with SMTP id h123-20020a636c81000000b003fd4be38ee9mr13380950pgc.188.1657504586122; Sun, 10 Jul 2022 18:56:26 -0700 (PDT) Received: from localhost ([157.52.138.46]) by smtp.gmail.com with ESMTPSA id w18-20020a63fb52000000b003db7de758besm3066487pgj.5.2022.07.10.18.56.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Jul 2022 18:56:25 -0700 (PDT) From: Ihor Radchenko To: Bhavin Gandhi Cc: emacs-orgmode@gnu.org Subject: Re: [BUG] org-auto-repeat-maybe: error =?utf-8?Q?=22Can=E2=80=99t?= expand minibuffer to full frame" and missing log note In-Reply-To: References: <413e82eb-db3b-8fac-7edb-35aded973dfd@ctpowe.net> <87y1xdk2a7.fsf@localhost> <87bku5nkz2.fsf@localhost> Date: Mon, 11 Jul 2022 09:57:32 +0800 Message-ID: <8735f8s96b.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::532; envelope-from=yantar92@gmail.com; helo=mail-pg1-x532.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1657504628; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=rECymbvt+wR+wxXU0YSrzNypB0SOgTh49rJckDwlTxc=; b=EmXhPVZZz81CUpp9BTcs1E5+M5h/XuKyfMW5lIbrCD9SXO8XP9aNxq7+lrDP1FaOKLJwAA iyERE9RCmFNXSdkA3xt94cfR1/cZDNU4QV/Vz79H7uF83DLtkbjbgoLJyZnDjZlrhb/70H /tCk4OrDorLrr/XoggM2AvWHGGj/SueayJtfjJSWMqKnC/vjeydiYJ/+p5emoInyrUqIdg Gd8z/t9XGGHVz+hC4vsny1JDMWmI0NAFrtcp659yP4KOVdLQguF5nj37issA/woomqSeLb eoauYNhMr+Ej99kAK/B5Y1+7mp2hKJuprQAth+KQGiX2prAo+RKLnQkx4+yUlQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1657504628; a=rsa-sha256; cv=none; b=OVaBNBkmPAXQo7diif3RakfAySo8L9YcrCJhyBeGe2rb4npNP+LaS2n0pLA231OWyUbEyV ZDM2U3ULFq9Vpr8i+6tbToo2LkMS2HDKPbbnOy8rqmxAKMjUVam3HY0iHiiR/0eDgJhPO1 QrQbsz78iu8QfQxRvJ2EsgsvhC+UfCKm6U4erXT8rOQ/0J5TCYH1OO0QozcsKII7lfs9wX 3IkjOK3fY3+X/1N/2YKms+zeqCt7ibMGD7aSQggcmttsqMBKeCUYeBohFc1L7aLotNPe5t lcR02WkMerM5yWCH+/nYS3Gdnh7fnE3pae5mZEb8DisNgoK1hz69+zdOAHRuLQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=JcaKe8yh; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.55 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=JcaKe8yh; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6606E176E8 X-Spam-Score: -4.55 X-Migadu-Scanner: scn0.migadu.com X-TUID: +BxTz3XO9r+m Bhavin Gandhi writes: >> A better fix may relate to the fact that org-add-log-setup is usually >> used to run org-add-log-note at the end of current command. y-or-n-p or >> any other kind of command (e.g. added via advice) will break this >> assumption we use. So, org-add-log-setup could also store >> `this-command', say, in `org-log-note-this-command' and >> `org-add-log-note' can then execute only when `this-command' is the same >> with `org-log-note-this-command'. WDYT? > > I had something similar in my mind, something like we check if > this-command is org-* (not very robust). Your idea makes sense to > me. But this won't work when read-from-minibuffer is called as it > doesn't seem to change this-command when it runs. Then, we will also need to save (recursion-depth) value and check for it in addition to this-command. Best, Ihor