From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id UL0iOU5izmNbwwAAbAwnHQ (envelope-from ) for ; Mon, 23 Jan 2023 11:32:47 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id QP38OE5izmOUKQAAauVa8A (envelope-from ) for ; Mon, 23 Jan 2023 11:32:46 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 95693394AA for ; Mon, 23 Jan 2023 11:32:46 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJu7L-0001dr-HL; Mon, 23 Jan 2023 05:31:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJu7J-0001dN-96 for emacs-orgmode@gnu.org; Mon, 23 Jan 2023 05:31:57 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJu7G-0001mg-Gr for emacs-orgmode@gnu.org; Mon, 23 Jan 2023 05:31:56 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id EB9292403A2 for ; Mon, 23 Jan 2023 11:31:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1674469911; bh=E2YzjjKSXqhK/LQzcMP1f6H7SasC0bjQy/kyNd61Vgc=; h=From:To:Cc:Subject:Date:From; b=ORrJ+rdu8uV0jHolkW0lHBIvaiF4ULTXzUu4IA45Xh2c0TrSHfqREzjbzmuPqz6Rh 1CKqnLTmXqHXBGtPecV4YHbEB2o91lGOWBNQXFBbGxf2qTU9uoYPwSDF9SQsFS9sI2 xVjcO0c2L1YNlpger9jPF3xuJ/Wcm3XaPX4P20JQI2r/ng6hskq2LL1GqWmu28HyKk ALB03oZdhlc/lGOM9IUxDotGDYytlVILOnwQTRLFCEpsPzWjXAVmrpHVoOCv96Tm4I Y+dHo0iU1mLmPprZIjSBHCDFaeNzBrJaC8pJ6kzl+XmY6/G2JJIOO7mYAm9E2L9Acq vK1mZqccw1ZFg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4P0mcP6CxKz9rxL; Mon, 23 Jan 2023 11:31:49 +0100 (CET) From: Ihor Radchenko To: Leo Butler Cc: Org Mode Mailing List Subject: Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects In-Reply-To: <87mt6m5n6u.fsf@localhost> References: <87mt92elyy.fsf@t14.reltub.ca> <87mt9128sz.fsf@localhost> <87zgd1b4rn.fsf_-_@t14.reltub.ca> <8735asbtfe.fsf@localhost> <87pmdvamwf.fsf@t14.reltub.ca> <87bkpaguy3.fsf@localhost> <87leocuhpg.fsf@t14.reltub.ca> <87359esah2.fsf@localhost> <87cz8ifioa.fsf@localhost> <87sfh9vukl.fsf@localhost> <87fsd7wolt.fsf@t14.reltub.ca> <87r0wk29dz.fsf@localhost> <87358ywn5g.fsf@localhost> <87bknh5nva.fsf@localhost> <87358ovj53.fsf@t14.reltub.ca> <87a62vitpu.fsf@localhost> <87lemfqbwl.fsf@t14.reltub.ca> <87o7r6m8sf.fsf@t14.reltub.ca> <87fschfhke.fsf@localhost> <87mt6m5n6u.fsf@localhost> Date: Mon, 23 Jan 2023 10:32:19 +0000 Message-ID: <8735817d8s.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674469966; a=rsa-sha256; cv=none; b=bbi5nZY8xOrsRiyBckXUOm1J6Rj4jovmM5H1BLSQKWUrRKk5HX7amHdGWAWRNx2FMfoHah aXxGBZ3VSM3wEr1P8bdc/CCFTOEYsmoLSQPh4VwI6d8SQWJPIaN/+4GVckszIkIJhc7RG/ bzEzQUHuFGaxHhosjrLsifTh6PUyzCzljMaz91NrEu2XxWkx1QonW7K9PyWoHxxvXqq0BU Nrgc13KcBwMgQrTdlgqcbCqA6zlsupi9WX3qlm2PNncS4ooGpl/rWxp+IBBU+wRlrPeUS6 +v7PtNrCBCLtZ21ZA0tcvAS1csw0HPPXYs4LJTZzV00KUw7okLNrBcDyPO4CCw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=ORrJ+rdu; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674469966; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=+Y3R3qgMgj1dxxqggtH/EoXrmo8Vxfx87L4C3SY40Y0=; b=F/MtRrtvbKEj9ekVNFw8yKy+pXEmOuJvQKRCMAWZ0mr2c7l8FDmu4jskbys9uBFYyLmnLj 6Bz/O1i5osdAYGASSLmZ1xp5A5GwtEhuGA141CysG9qfCFTs3VU/MyoPlR4iQAYO3I0Pim ap0GhEjtXWL/xq63CNA12JakzTf1/A515/D9Aeqm+pk1vTSa1EkGIFNfHy2LuGniyPFMYX o8bfCLLsWxIiq0gHuL8+5ncSfcknfj3nZRZJ2aT9RRvkKhHLri1oS1FTcIKTlseCu3Woxr e9FYe0ENo1d/NHOMHFFzaKux41M3QLnyxgcUHuo0Hz+VLdTWdCUQcsc2lOO6Hw== X-Spam-Score: -11.15 X-Migadu-Queue-Id: 95693394AA Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=ORrJ+rdu; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -11.15 X-TUID: ZHnFVQnRZUhK Ihor Radchenko writes: > Ihor Radchenko writes: > >> So, the test failure is real. > > The error buffer contents when the test fails is the following: > > warning: using the gnuplot graphics toolkit is discouraged > ... > [ Babel evaluation exited with code 0 ] > > Exit code is 0, so octave does finish. > > Hence, test assertion that > (should-not (buffer-live-p (get-buffer "*Org-Babel Error Output*"))) > does not appear to be accurate. > > Leo, should we simply remove the assertion? I decided to remove the assertion from the tests. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=59228e51345ab522d9db611c8e73caa078d86d2f While there could be a value in making sure that ob-octave calls octave without generating errors, it is not strictly what the test is checking for. Moreover, we currently have no reliable way to disambiguate mere warnings from non-zero exit code. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at