From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id GAgJE7Gjz2NMagAAbAwnHQ (envelope-from ) for ; Tue, 24 Jan 2023 10:24:01 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id oBk5ErGjz2OMagAAG6o9tA (envelope-from ) for ; Tue, 24 Jan 2023 10:24:01 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DD9E416920 for ; Tue, 24 Jan 2023 10:24:00 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKFWJ-0001T7-Vg; Tue, 24 Jan 2023 04:23:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKFWE-0001Sq-Uj for emacs-orgmode@gnu.org; Tue, 24 Jan 2023 04:23:07 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKFWC-0008JC-TK for emacs-orgmode@gnu.org; Tue, 24 Jan 2023 04:23:06 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id D4A77240904 for ; Tue, 24 Jan 2023 10:23:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1674552181; bh=OkQhBgwS4X7VIvW54V9Yi9BeTYPZXwlb0TZnidIOMhE=; h=From:To:Cc:Subject:Date:From; b=XlaSafmbaqeFcy/+cGPMB9jSRhCegUb5j4tjcejvM56XLHh0TxGrlK8PBxo2D9TT2 GjSFXWimtwxPjJZKhmphczVDF0XXWX4pSbYT4XwkHhkG4CNQEgDhMbw5SWi5SfmNYX F9P3lP2qYg+EgSmC/3gpPRbp+txOCjLxmMDw0jlXFiUTaz3k0+zW8ClwaXZjQb+K/I gfxdvu4/hEhVNgrZINBtE+JhXvormU/0EVvRttHeiy6yTj6KnTZ5NLk7UhLyMYZ/WS Tf+JUPCyJjWM8tg+FgmnuzhJTVyM+x7sasp++dfqmBJt51DrnLOmNL4FSvZ5T+W54B uuStQV5utO91Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4P1M2Y01xbz6tmx; Tue, 24 Jan 2023 10:23:00 +0100 (CET) From: Ihor Radchenko To: "Aaron L. Zeng" Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] lisp/org-agenda.el: Fix void-function string-pad in Emacs <28.1 In-Reply-To: <20230124025259.1301063-1-me@bcc32.com> References: <20230124025259.1301063-1-me@bcc32.com> Date: Tue, 24 Jan 2023 09:23:33 +0000 Message-ID: <87358070bu.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674552240; a=rsa-sha256; cv=none; b=b792wYy+RaLWf0U/O8i860dUgJb8Bx9Nwaq3kbaA7CO+0RI8Xbk4eAONVfv07PZTU7+VHZ 5OvmkXPk9cOHDtIX0ynYfcu40ZJL4wzYFJRhwbmgIgm97iIrBPsref1on95pe6BJj7rPRA he47yQCFKYPEemw0ZCx7ep/Goa7wXuRryLmFoI9FYRqPjkq4J3aCc4f+akcF/SVFvQI+aw YaFj1MEvkXKzDuQnQrdfc8GY6b0WChLsUzusH6tByZ1FpF+K5guS1q3YjoYtJdYxiSJUa2 0cWUUBOQa9bpE2YfEAouPsuslwtUKfQ2Mnb/dUd+BZTkVNTj7yK2/lo3fjQ/Pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674552240; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=axx81GfsSepj10vzxk77LX85UInN/Sd/o9BDcM+MTCw=; b=P/O+ZQ4WqhySjOEtPpi+QCzZFjX42OYzP+2g8aXNhyMR2X6Z4/RP0jBnSykF0Zqz4sWEb5 Uh54xwQBtwrTuxsMBQastqCXwSLfdp7FIVNxIZv8Y7pzsgWx8MrH1/NfQ4FgEn4jQBP/WW TEC376lcCynJwiIfom6ENt7pbNqFlO+ZFYM1T3658WMz3+TrVXong8T9uobSfS/pGLEP5+ zWBJGnaknGQDZa3i7ILtbuGGNN3910G4oZ7ltfGKpoDHgIxQhEDGWmmZ2Oe8VCgKH4xMrX chdd2OYcvDTVwW+Rn5uo8rhFB8iiehOL3EeWMs1RJyvMqzwT2GQ5LwCWS41umg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=XlaSafmb; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -6.65 X-Spam-Score: -6.65 X-Migadu-Queue-Id: DD9E416920 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=XlaSafmb; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-TUID: N74ktlFj2sDA "Aaron L. Zeng" writes: > * org-compat.el (org-string-pad): Add compatibility function > `org-string-pad' for `string-pad', introduced in Emacs 28.1. > > * org-agenda.el (org-fix-agenda-info): Use `org-string-pad' rather > than `string-pad'. > > Since this is more-or-less just copying string-pad's definition from > subr-x.el, I think this qualifies for TINYCHANGE. Thanks! This issue has not been caught by byte-compilation. I applied an alternative fix not using `string-pad' at all. Canceled. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=5bbb97f3df9788646b8d48d60e8b8ea06566e05f -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at