From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 0Oz0DPFa1GMjCAAAbAwnHQ (envelope-from ) for ; Sat, 28 Jan 2023 00:14:57 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id uBkJDPFa1GMeGgEAG6o9tA (envelope-from ) for ; Sat, 28 Jan 2023 00:14:57 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D705717817 for ; Sat, 28 Jan 2023 00:14:56 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pLXv6-0005Rp-CN; Fri, 27 Jan 2023 18:14:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLXv5-0005RP-6C for emacs-orgmode@gnu.org; Fri, 27 Jan 2023 18:14:07 -0500 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pLXut-00070q-Hm; Fri, 27 Jan 2023 18:14:06 -0500 Received: by mail-pj1-x1032.google.com with SMTP id e8-20020a17090a9a8800b0022c387f0f93so5066181pjp.3; Fri, 27 Jan 2023 15:13:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=A4a3Fz01swxKjh1wtKRDg8laWnbOgSmXIjZjl5XNmHE=; b=jBJsOxCwIzuy3wzi4F4DxZNrPJnn6wUhwPpuM0elUSpdxw860Xdm1tJiW1urCcDybM qvV1f1Z6/XGIdIS/CKUh4Z9C1jkSk9JuCwM7GyB/Qh7tTfyAMmQN4rv3yHAzd5xCiijT DG1hTjczllyddEjV+RtT8rEkLeHd2Y0wuop6iAqFj7EAgVBWIzX0OEQCe0qKt9akSFtg +bylhz4A03R+1M71gcihmiTeltmYzlUs/p1asQVkWKQO0kdQv2Y2e4d+wpi9sIX/jdxu TdlqTnRcWDfaTQ7sz6Yt4TQGDLpv769dGKqrZeERmTGMbKlnnMi8Er3/oJo84knzzdeu 20LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A4a3Fz01swxKjh1wtKRDg8laWnbOgSmXIjZjl5XNmHE=; b=0thVTmHT+hp4ANj4QyOJqugTjc4mESj9oXDefMscO98gsSS91Ih3OZYMfoXcRsp9i7 KZjcis2/dbGZlfDRHv7mA6cMUan/liUQY5hOQiiX1OdSbI/FAcftljouqMLp3B6muqm5 Q6EU+7Se4iFSPM0Qv4Tg8ldB+s8CvzlFwxjtRiUiR0Bac+ana2JKzE6T77juhuu/FvcF WKHrTP0rD99cm8gVuz0F35FI0OftLBRZLRZaPSSeG8KJjeaRA2X8wx0PkE5UE6uVKvwF 0CdsAbShST/0Fc5F02xhgH2MHyloLHvC+sCu7zsX5JNSkoHQXVgkCcluVg/df2PWwHjE u0kg== X-Gm-Message-State: AO0yUKXkU5o6AQUTaD904MrMTp7fB7i3RjdM1+edNDTdmiCMPQDe2S6z JgXQ7F1VRvZfxyXK5Mr3TOA= X-Google-Smtp-Source: AK7set8DccoyoDPcYVI7W6slgDVeFzRQ1nEl+qBsQngkSumWxgnWjojvyLdtR5HrKvf3470ON/mLWQ== X-Received: by 2002:a17:90b:4c52:b0:22c:46a1:67ca with SMTP id np18-20020a17090b4c5200b0022c46a167camr4768926pjb.37.1674861232774; Fri, 27 Jan 2023 15:13:52 -0800 (PST) Received: from localhost (157-131-78-143.fiber.dynamic.sonic.net. [157.131.78.143]) by smtp.gmail.com with ESMTPSA id n2-20020a17090a2fc200b0022c526608c2sm1355475pjm.28.2023.01.27.15.13.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jan 2023 15:13:51 -0800 (PST) From: Jack Kamm To: Ihor Radchenko Cc: Bastien Guerry , emacs-orgmode@gnu.org Subject: Re: [DISCUSSION] Should we deprecate python-mode.el (alternative to built-in python.el) support in ob-python? In-Reply-To: <87o7qp5wbw.fsf@localhost> References: <87bkprid1d.fsf@localhost> <87mt9am16j.fsf@gmail.com> <87r0yk7bx8.fsf@localhost> <87r0xqla74.fsf@localhost> <87r0xq8dk9.fsf@gnu.org> <87wn6atjid.fsf@localhost> <877cxe2ot2.fsf@gmail.com> <87o7qp5wbw.fsf@localhost> Date: Fri, 27 Jan 2023 15:13:50 -0800 Message-ID: <87357v370x.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=jackkamm@gmail.com; helo=mail-pj1-x1032.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674861296; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=A4a3Fz01swxKjh1wtKRDg8laWnbOgSmXIjZjl5XNmHE=; b=NqzQA3oeNep/CymqxciJvBhzWLEBiOmVkvlV/ToFgPwkFnR206argEGf7DK+seGsm+w4tQ gZBcuCC8HR5DoXRtGk7hYDH4uhN4DAweoYTY2fIh0pLOl8+4iq3xXclyPXi8xZFS80SvwV FZZ9gp24Jj1CRc2KA9f5QraWmeai9wQhpYzZjvtqf/2VO3jsVJ8eJjmmi3LmdYgWzbQshN M6sKz5EmvqIosmG7eKNK5H0sFsd47luRJuW6UN8NYjyAb8Ed9iLb7flLbVy63z8TUQFtvm 2CfMw/MiJUdhKMqB+GkZ+0JMu3ldKyAtykVF0j1icwhEWm/FzDJG72goeEDRDA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=jBJsOxCw; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674861296; a=rsa-sha256; cv=none; b=GFmbnQxELQxgOSH+utyNh7k4+nOdeU37lXMbThE8qta5eBceezWd2DNqI1h0m1vilOs9Qn 1TnXaiUw6XwOSPcoRMRIzzzJRGH4BMV6q0x/OhuvqH92/dncpGGwSEVToc7iwDVa1IyJvG 8DJrD9vRruefka81kWmT5TruQ9az3Rh8wLjtUWayIStnER7Mgj5v9LJC1i3lb9rWZEScGo 2bN2N8Z3QcfW+4HdFY8uCEwticbFBRDX6VDqpz/Ocslu23g+Q2EjgS+b4U8FX4VbjTkx5S XVAxfmai+A9+eN1vL23UouyL4/D9I9OxCXuh8mcRs2mqMyUoAlPtXW45WM8kRA== X-Spam-Score: -3.75 X-Migadu-Spam-Score: -3.75 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=jBJsOxCw; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D705717817 X-Migadu-Scanner: scn1.migadu.com X-TUID: BHs9D0JAmfe7 Ihor Radchenko writes: > Let's follow the usual approach and first deprecate it. It should become > a constant with 'python value in org-compat.el. Deprecating is not make > sure that other packages that might be testing the variable value do not > get broken. > > Note that we usually `quote' Elisp symbols in the commit messages. Thank you for the review. I've incorporated your feedback and pushed the patch as commit aa48c80fe17eaaaf83c11c9ac2f2fd864f2f3ad9 > I find the need to use advise awkward. Is it necessary? I agree it is awkward, and also fragile to future changes in ob-python. But unless I've missed something, I think some advice is needed to get the old behavior. Still, it would be more robust to just advise the main function org-babel-execute:python, instead of advising the 2 helper functions. But, this would require a little extra work, and while I might do it later, it's a lower priority for me right now (it's unclear whether there are currently active python-mode users of ob-python). For the moment, I just updated the Readme to say the current implementation is a temporary workaround, and it will work for Org 9.7, but may not work in future versions as ob-python evolves. Arguably, it would be best to avoid overriding python src blocks altogether, and instead have completely separate python-mode src blocks. But I would leave such a design decision to whoever decides to maintain babel+python-mode integration in future.