the change in org-time-stamp-custom-formats

the change in org-time-stamp-custom-formats

[Uwe Brauer]

Hi

I just read in the news that 
the Leading =<= and trailing =>= in the default values of
~org-time-stamp-formats~ and ~org-time-stamp-custom-formats~ are
stripped.

No changes on the user side are needed if
~org-time-stamp-custom-formats~ was customized.

But I have files with the setting

#+begin_src emacs-lisp :results silent :exports none
(custom-set-variables
 '(org-display-custom-times t)
 '(org-time-stamp-custom-formats '("<%d.%m.%Y>" . "<%d.%m.%Y %I:%M %p>")))
#+end_src


Should I change that to 
 '(org-time-stamp-custom-formats '("%d.%m.%Y" . "%d.%m.%Y %I:%M %p")))

-- 
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/

Re: the change in org-time-stamp-custom-formats

[Ihor Radchenko]

Uwe Brauer <oub@mat.ucm.es> writes:

> But I have files with the setting
>
> #+begin_src emacs-lisp :results silent :exports none
> (custom-set-variables
>  '(org-display-custom-times t)
>  '(org-time-stamp-custom-formats '("<%d.%m.%Y>" . "<%d.%m.%Y %I:%M %p>")))
> #+end_src
>
>
> Should I change that to 
>  '(org-time-stamp-custom-formats '("%d.%m.%Y" . "%d.%m.%Y %I:%M %p")))

You can. Or you can leave things unchanged.

What we now do with these values is

;; Strip brackets, if any.
    (when (or (and (string-prefix-p "<" format)
                   (string-suffix-p ">" format))
              (and (string-prefix-p "[" format)
                   (string-suffix-p "]" format)))
      (setq format (substring format 1 -1)))

So, brackets, if any, are stripped.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: the change in org-time-stamp-custom-formats

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 1036 bytes --]

>>> "IR" == Ihor Radchenko <yantar92@posteo.net> writes:

> Uwe Brauer <oub@mat.ucm.es> writes:
>> But I have files with the setting
>> 
>> #+begin_src emacs-lisp :results silent :exports none
>> (custom-set-variables
>> '(org-display-custom-times t)
>> '(org-time-stamp-custom-formats '("<%d.%m.%Y>" . "<%d.%m.%Y %I:%M %p>")))
>> #+end_src
>> 
>> 
>> Should I change that to 
>> '(org-time-stamp-custom-formats '("%d.%m.%Y" . "%d.%m.%Y %I:%M %p")))

> You can. Or you can leave things unchanged.

Well if I don't change I see the time stamps like this 
<<09.05.2023 >
instead of

<09.05.2023>

When I use org-toggle-time-stamp-overlays
to toggle the overlays on
-- 
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

Re: the change in org-time-stamp-custom-formats

[Ihor Radchenko]

Uwe Brauer <oub@mat.ucm.es> writes:

>> You can. Or you can leave things unchanged.
>
> Well if I don't change I see the time stamps like this 
> <<09.05.2023 >
> instead of
>
> <09.05.2023>
>
> When I use org-toggle-time-stamp-overlays
> to toggle the overlays on

I am unable to reproduce.

I did

1. /tmp/bug.el
(custom-set-variables
 '(org-display-custom-times t)
 '(org-time-stamp-custom-formats '("<%d.%m.%Y>" . "<%d.%m.%Y %I:%M %p>")))

2. /tmp/bug.org
* This is test
SCHEDULED: <2023-05-09 Tue>
<2023-05-09 Tue> <2023-05-09 Tue 16:24>
[2023-05-09 Tue] [2023-05-09 Tue 16:24]


3. make repro REPRO_ARGS="-l /tmp/bug.el /tmp/bug.org"
4. M-x org-toggle-timestamp-overlays

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: the change in org-time-stamp-custom-formats

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]

>>> "IR" == Ihor Radchenko <yantar92@posteo.net> writes:

> Uwe Brauer <oub@mat.ucm.es> writes:
>>> You can. Or you can leave things unchanged.
>> 
>> Well if I don't change I see the time stamps like this 
>> <<09.05.2023 >
>> instead of
>> 
>> <09.05.2023>
>> 
>> When I use org-toggle-time-stamp-overlays
>> to toggle the overlays on

> I am unable to reproduce.

> I did

> 1. /tmp/bug.el
> (custom-set-variables
>  '(org-display-custom-times t)
>  '(org-time-stamp-custom-formats '("<%d.%m.%Y>" . "<%d.%m.%Y %I:%M %p>")))

Uff I need to cook up a recipe and come back to you.
I hope it is not something in my init files 
but I started to notice that problem only after I pulled and installed
a recent master version, hm.
-- 
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]