From: Ihor Radchenko <yantar92@posteo.net>
To: Tim Visher <tim.visher@gmail.com>
Cc: Emacs Org Mode mailing list <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] org-capture.el: Allow `(here)' as a template target
Date: Wed, 21 Jun 2023 15:59:28 +0000 [thread overview]
Message-ID: <87352kerhb.fsf@localhost> (raw)
In-Reply-To: <CAHa53uykPd47GEm__oqLHSHZF9__vR2EsN-xAVujdki83mzNJQ@mail.gmail.com>
Tim Visher <tim.visher@gmail.com> writes:
>> Also, may you update the docstring of `org-capture-templates'
>
>
> Good catch! This has been done in patch 0004 now. Look good?
Yup.
>> "10.1.3.1 Template elements" section of Org manual?
>
> I'm confused about what you're referring to here. Isn't that what 0002 does?
Yes, it does. I saw it, then noticed the missing `org-capture-templates'
docstring update, and somehow deduced that manual must be missing :facepalm:
> Again, happy to squash and provide a single complete patch once we're all
> done the review. Thanks again, Ihor! :)
Please, also add all the necessary changelog entries to the final commit
message.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2023-06-21 15:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 15:35 [PATCH] org-capture.el: Allow `(here)' as a template target Tim Visher
2023-05-12 16:35 ` Ihor Radchenko
2023-06-20 19:32 ` Tim Visher
2023-06-21 10:33 ` Ihor Radchenko
2023-06-21 13:12 ` Tim Visher
2023-06-21 15:59 ` Ihor Radchenko [this message]
2023-06-21 18:30 ` Tim Visher
2023-06-22 10:18 ` Ihor Radchenko
2023-06-22 13:53 ` Tim Visher
2023-06-23 10:58 ` Ihor Radchenko
2023-06-23 12:02 ` Tim Visher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87352kerhb.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=tim.visher@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).