From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id +AxMCfdglmT5LAAASxT56A (envelope-from ) for ; Sat, 24 Jun 2023 05:20:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id yNaFCPdglmRhXAEAG6o9tA (envelope-from ) for ; Sat, 24 Jun 2023 05:20:23 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A79F7A38E for ; Sat, 24 Jun 2023 05:20:22 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qCto2-0007XY-Ha; Fri, 23 Jun 2023 23:19:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCto0-0007X3-Tl for emacs-orgmode@gnu.org; Fri, 23 Jun 2023 23:19:20 -0400 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCtnv-0001Dg-OG for emacs-orgmode@gnu.org; Fri, 23 Jun 2023 23:19:20 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1qCtns-0008u1-C7 for emacs-orgmode@gnu.org; Sat, 24 Jun 2023 05:19:12 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Nick Dokos Subject: Re: [BUG] org-babel-tangle: Header arg `:comments org' produces no comment in the output [9.7-pre (release_9.6.6-418-g294a4d @ /home/nick/src/emacs/org/org-mode/lisp/)] Date: Fri, 23 Jun 2023 23:19:02 -0400 Message-ID: <87352hk0nt.fsf@alphaville.usersys.redhat.com> References: <87bkh8k3at.fsf@alphaville.usersys.redhat.com> <87r0q3ddnb.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Cancel-Lock: sha1:5F/dwUauc7E0+BXsYgbhXsqSN/0= Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1687576823; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Ex8sXyRJ7GgnZjrt0MGpMVs4MgPUszIBE/HHGkOpv2A=; b=mL4kKeITzV8yTD+N5pbcfDIS40Og1JnvBOuOzI4Fk0BVAwbU6mP0qcddZiBHkZYO2y4IKN 1bFkDu2kxLE3mXCfSK68s4i2+JIyAZku8sCWjBu+rGC0J36W6GDQfQ9GMbTsqiD1CayLhG tkFeMPVXM5NLtVMbZyz8cUnVumyvsOhXoGdrcFafygeTMCjaE1r+OV0Or/Lzyo+TkM6o6S XhCmCEjF1eq9GMGstpd1N4IT4uLCNsVSSznm0GWyoyf+KiUotvGiqoKjFTo9Od09XdyGO8 qVvxEDM+pMzaYzmpQRp04yerE4KmreXX8UauiDZgFKFFZO0DyMTNcCY3FHVrnw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1687576823; a=rsa-sha256; cv=none; b=VUfhXWoVYsgbW65oXyZv41FaNNN/eY8nqD4sTAZBQ6YzmMVHdm1SRhTNp8eapIzrDEorJM PW/FgSX4HiF8DX36V+2Dv0Op1JlqErTOduWX34Ng3QG+Yq8tX2rxd6nwusbM6aYjwI0a6p tPFCbYykamkgcuB+sXIjmz4QS4b66ZzpA7fJNydhP5SHRYT+RG4rrJAcA7VQc+t6qyAmvF UN4W8r4EVwV5V6a6H98TjhD0VHgpm7A5g975M0HvDVS++e+UWnBaK/ru7vMfigJIcjiZj8 5jVjJwYSLwFMNy5kAPJOV7rmGYEmYiO9sOVpLQPxFz3zLRBGwLgN7FGQw37e7Q== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -2.45 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A79F7A38E X-Spam-Score: -2.45 X-TUID: rPUSSMJkTgKw Ihor Radchenko writes: > Nick Dokos writes: > >> Here's an ECM: >> ... >> I narrowed it down to this snippet of code in `org-babel-tangle-single-block': >> ... >> and bisecting fingered this commit: >> ... >> Apparently, `org-back-to-heading' sets match data differently now: `(match-end 0)' gets the end of the line, >> Before the patch, it got the beginning of the line. > > Thanks for the report and for the detailed analysis! > Fixed, on bugfix. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=79ec91584 Thanks! A couple of nits: maybe the comment that `org-back-to-heading' sets match data should be deleted? And there is a typo in the initial comment of the test you added (thanks for adding it!): `:commends org' should be `:comments org'. Also, I found a couple of places in the code where `org-back-to-heading' is called and then match data are used. I don't know if there is a problem or not, but it might be worth double checking to make sure that the usage makes sense: - org.el: l.20792 in `org-forward-heading-same-level' - org-mouse.el: l.976 in `org-mouse-transform-to-outline' I'll try to test these cases and report back but I can't promise when. -- Nick