From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 8A3nGhKkK2W2+wAAauVa8A:P1 (envelope-from ) for ; Sun, 15 Oct 2023 10:34:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 8A3nGhKkK2W2+wAAauVa8A (envelope-from ) for ; Sun, 15 Oct 2023 10:34:26 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C9232453FE for ; Sun, 15 Oct 2023 10:34:25 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b="Bt3Y7/As"; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697358866; a=rsa-sha256; cv=none; b=jW324hn/WSEfZW+OP08C/iLstZssoeXem9XD9fhLiAHKLw/OoyG3aWhOELFvj1JQ/Fds9A SsFTpReKdwz87q3PbXimZSQpHMKxFyZX6/eVeFcubYujWmB4OYGxzVt+0xXxKVJr9dEycl Es9gp76TxUeMeNbZa/MxVcvoSZC6af1kwnTBSOOR76UNSUzoure9j34Ilz9lQfZHOs0cS1 l9+Xtgnm8VOF8yXMjaHT3LC2dnKV5mvcAI7ixAgnM4peUHUr0fnG5YkqwZNkCcAY+xh2Ub 2fscXUW1lt2OFxk10cFKu4WBFu+OLjEs1g8z0otkKorRVVYV9WJzUIluETDcZw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b="Bt3Y7/As"; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697358866; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=aBENsIZ+Bvn7rqVsLN9mF+tvmq0QuNa+INNH5wkD9f0=; b=OWnWGFiLkP/CB+FeOzj3DoVHMDmBg2SpQGFXWrDz/m0IRpzmWfityoyr3hy2oPD2NDHi38 K2oIt+KQ12mfvzMZk82bOHmmrcgFgnXANjQ7imnK2d7VwLAl3oIn98Zpcn5gwGB57cVIXH IyWqFVjyxP9N7q2CzO+Xy7+iXP5+MlTEAck0FIoJ/RGjOBFuqje9GlNlBCn2B/RQnzHTL+ RsqPDSVEZGmCByJqRdeWvHMlMESMmrgk5CgjBDQfDMh2Gf70pOwYTd+V1eeUnjefrGnIvi 6hZO183xnB4BqMVsBNhnYWPopW6mgUYNPwFHOPsboRStm5ny7En9Nb9Y7Bu3/g== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qrwZB-0002mS-E6; Sun, 15 Oct 2023 04:33:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrwZA-0002m6-3r for emacs-orgmode@gnu.org; Sun, 15 Oct 2023 04:33:40 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrwZ6-0007uc-0X for emacs-orgmode@gnu.org; Sun, 15 Oct 2023 04:33:39 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id CEAF3240027 for ; Sun, 15 Oct 2023 10:33:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1697358813; bh=t4k7Jw2PCnhiw6HY6WIlWJpVwZvupgSE8tAIQKcw2uc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=Bt3Y7/AsFBaXuLWmLel+Nzpa2Vp5vTLPRjmJqQMFSOBC0U3vTo81XvDSMOwe44Zox GB7nPSR1oTotK3px9tBLfhbj/sPGE53WusIvxkTv7TRzMI/k4X1Ch61KhFceEeLMcY 5khPILP55q4Chj30l+T7QMvPaVUiY677tOBPwUMo2v8c9/tmnb2jV0UH/UKmI2Ze6k 3uWB8891KofB5mh4cCjYYeu66NFWf+9b0m4uKAzvGPqZhaJyJWyT5fMdu/UErk/xkx J2epHxbMtUs0yBMYmK1DoLHIVUcein6kOYfZH+vT1v4vdNovzH5W7dOsRpaj1Xo6XU KklNyF4NLO4QQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4S7YRd2xrGz9rxR; Sun, 15 Oct 2023 10:33:33 +0200 (CEST) From: Ihor Radchenko To: Elias Kueny Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] Fix :var parameter for fish shell code blocks In-Reply-To: <877cnpwka3.fsf@posteo.net> References: <877cnpwka3.fsf@posteo.net> Date: Sun, 15 Oct 2023 08:35:21 +0000 Message-ID: <8734ycb7w6.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: -8.75 X-Spam-Score: -8.75 X-Migadu-Queue-Id: C9232453FE X-TUID: UX8qa1eDkAy1 Elias Kueny writes: > I found an issue with fish shell code blocks, in that the `:var' parameter generates a command that is not syntaxically correct. Fish uses `set variable value' instead of `variable = value'. As a result, org-babel throws an error when executing the code block. This patch fixes this by adding an exception to org-babel-variable-assignments:shell on the model of what it already does for bash. Thanks for the patch! Applied, onto bugfix. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=c42cdcda4 You are now listed as an Org contributor: https://git.sr.ht/~bzg/worg/commit/fdc3c55f -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at