From: Ihor Radchenko <yantar92@posteo.net>
To: Elias Kueny <elias.kueny@posteo.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix :var parameter for fish shell code blocks
Date: Sun, 15 Oct 2023 08:35:21 +0000 [thread overview]
Message-ID: <8734ycb7w6.fsf@localhost> (raw)
In-Reply-To: <877cnpwka3.fsf@posteo.net>
Elias Kueny <elias.kueny@posteo.net> writes:
> I found an issue with fish shell code blocks, in that the `:var' parameter generates a command that is not syntaxically correct. Fish uses `set variable value' instead of `variable = value'. As a result, org-babel throws an error when executing the code block. This patch fixes this by adding an exception to org-babel-variable-assignments:shell on the model of what it already does for bash.
Thanks for the patch!
Applied, onto bugfix.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=c42cdcda4
You are now listed as an Org contributor:
https://git.sr.ht/~bzg/worg/commit/fdc3c55f
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
prev parent reply other threads:[~2023-10-15 8:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 22:42 [PATCH] Fix :var parameter for fish shell code blocks Elias Kueny
2023-10-15 8:35 ` Ihor Radchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734ycb7w6.fsf@localhost \
--to=yantar92@posteo.net \
--cc=elias.kueny@posteo.net \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).