From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:5f26::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id sGEHD+1rlWWxKwEAkFu2QA (envelope-from ) for ; Wed, 03 Jan 2024 15:15:09 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 8NtyDO1rlWXQhAEAqHPOHw (envelope-from ) for ; Wed, 03 Jan 2024 15:15:09 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=rBFPiNSj; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1704291309; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Ei9SLaqk2QN3/CM6pu10tgjIgq8DzgMOwtBbgVwYUV0=; b=CEcm99rKgfMiGRz/OgOJn2JKBpUh9AAJ/2HMnCodby919wSbWg8es1ZyUw0cSo31HQeJ5S XJisdjHwYps/Ba5ahNB5omXrubn1o3RZgyiVLWGFL4ypS5yKqdChCck97P51P40jgqbTvR MutqAbKvDRwYhOyPUDZsf9BE5gEQjtEUXSe2ZPjC4uckb/L4v3f2Xdv4VlXbE7HLymbilZ 6k925mXNFNgqUtc93mQLwmUU5I8xwRfCtiqtXBJvgN9QEdB3kLXcr7XZTkJiLL0oWzHo2S ayd7vPH0cKdX9WWmHJgnI5sq7U2mJe9bJY4IqrRPaMVy2oNZk5uhictP693Edw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1704291309; a=rsa-sha256; cv=none; b=Sa0cu+muT4KhBaVVPAxl1aEMj2iyn5/1jz+o+ofUanF7/yQ27jJLJ0IuVH+tygRep6mL2K qwlBCH9pxG0F43ZtVlJmrDzSE0HRTc/YG8A3WCIVQ35XYMpvpEXBUHP13YUW+/hkFvwz7a 3USkJ5CqWV1fv1Lew6M+8noJ4vlttk/pRQTTAgTSFCdMAkWA+6SkkzOAVu2aEUwJ4vX0w0 zAFwoGMd3DeVV/aUXYUVBYpJfUvAu5uau0DnfBiiCKrzsnI0y/JqpERgli4aHYPxAVCq7X Eo7rvWEo0jRcSyeljfQYpC09kXKIPc3QbVXzxnu+EdTek2RKLTo7TzLcIi1ZDQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=rBFPiNSj; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A59761E191 for ; Wed, 3 Jan 2024 15:15:08 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rL20j-0001L8-K3; Wed, 03 Jan 2024 09:14:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rL20i-0001L0-PZ for emacs-orgmode@gnu.org; Wed, 03 Jan 2024 09:14:20 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rL20f-0005VY-2t for emacs-orgmode@gnu.org; Wed, 03 Jan 2024 09:14:20 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id AA28B240029 for ; Wed, 3 Jan 2024 15:14:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1704291254; bh=RcJ33QzelEFsOvY016Ci4P2g78utUDfsUJzae98sl8Q=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=rBFPiNSjm+x+aHPPE6v/BJSejPB4ZWtU4fmtfsiWLG+HtoBqBgTfYj5N5r4Hj3xU6 3cnF59gotrLkOTVyTCGxWvuRQp9XMxk2zwNowgGHUgA7l5tNOp7BfEZX4VW7duZv6f hO8IV9z4fqZo2zoiDmQF9YQVnXntcXamv2Y/y3pMlb5F/TK98h2r6oFThF4CpDbyCh dU+Mezz3uCLNRmBIjS02gUeS6XBUnASbqpBJcJE57HltC7jYjKVI6RPdnu3UnstAaC LeFuP3HI1PPp9RX4DIVA0aeX8cnBWu7umNdPDesmc1oIWbLjJhRlr5YFByrM0eQ9Ix D1jeahifriDLA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4T4sCn2B0jz6tmv; Wed, 3 Jan 2024 15:14:13 +0100 (CET) From: Ihor Radchenko To: Rick Lupton Cc: "Y. E." Subject: Re: [PATCH v2] org-id: allow using parent's existing id in links to headlines In-Reply-To: <78720555-7511-42cf-892a-4c508f512b39@app.fastmail.com> References: <118435e8-0b20-46fd-af6a-88de8e19fac6@app.fastmail.com> <87edkwsafe.fsf@localhost> <87cywh2ad6.fsf@localhost> <87jzpmqiy0.fsf@localhost> <2cdfefbf-e9e3-4aeb-a410-1ff3a9d6168e@app.fastmail.com> <87zfybzkul.fsf@localhost> <3c5737c8-f489-4144-a27f-c0e0527c79c0@app.fastmail.com> <87bkaqcjpz.fsf@localhost> <87msu7r902.fsf@localhost> <78720555-7511-42cf-892a-4c508f512b39@app.fastmail.com> Date: Wed, 03 Jan 2024 14:17:25 +0000 Message-ID: <8734ve8psa.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.63 X-Spam-Score: -6.63 X-Migadu-Queue-Id: A59761E191 X-Migadu-Scanner: mx12.migadu.com X-TUID: o8MaPlls3rVI "Rick Lupton" writes: > Thanks for the comments. On this point, I'd like to modify `org-insert-heading' to allow for choosing the level of the newly inserted heading, but first wanted to check if you have a preference for how to change it. > > > I think it would be simplest to change the current: > > (defun org-insert-heading (&optional arg invisible-ok top) > "...When optional argument TOP is non-nil, insert a level 1 heading, unconditionally." > > to: > > (defun org-insert-heading (&optional arg invisible-ok level) > "...When optional argument LEVEL is a number, insert a heading at that level. For backwards compatibility, when LEVEL is non-nil but not a number, insert a level-1 heading." > > but that is not totally backwards compatible -- is that ok? I think that it is OK. I very much doubt that anyone at all uses numerical value for TOP in the existing `org-insert-heading' calls from Elisp. And adding yet another extra optional argument is not justified in this particular case. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at