From: "Björn Bidar" <bjorn.bidar@thaodan.de>
To: Karthik Chikmagalur <karthikchikmagalur@gmail.com>
Cc: Ihor Radchenko <yantar92@posteo.net>, emacs-orgmode@gnu.org
Subject: Re: Link preview generation with new link preview property
Date: Sun, 29 Dec 2024 17:44:31 +0200 [thread overview]
Message-ID: <8734i68peo.fsf@> (raw)
In-Reply-To: <87y102mgdx.fsf@gmail.com> (Karthik Chikmagalur's message of "Thu, 26 Dec 2024 10:46:34 -0800")
Karthik Chikmagalur <karthikchikmagalur@gmail.com> writes:
>>>> ...
>>>> Considering this, it might be better to just split
>>>> `org-link-preview-file' into two public functions, where the "inside"
>>>> function accepts an image instead of a file.
>>>
>>> Agree.
>>> Would you be interested to create a patch?
>>
>> Did you think of something like this?
>
> It looks like you are respecting the alignment specifications, set via
> org-image-align or the :align property of #+attr_*, but not the :width
> property. Is the idea that the preview implementation that provides the
> image should independently use org-display-inline-image--width?
The width is set before the inline image is created. I'm not sure how
this should be handled. Is the with set when creating the inline image
Ihor?
If the width is set before the image is created how should it be handled
in
the preview image-data function?
> At minimum this requires making org-display-inline-image--width a public
> function. But it would be good for org-link-preview-image-data to
> respect both properties.
I agree with both but I'm not sure what should be done on this.
next prev parent reply other threads:[~2024-12-29 15:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <6755f138.0c0a0220.40388.51fbSMTPIN_ADDED_BROKEN@mx.google.com>
2024-12-13 5:49 ` Link preview generation with new link preview property Karthik Chikmagalur
2024-12-14 0:03 ` Björn Bidar
2024-12-14 7:04 ` Ihor Radchenko
2024-12-17 2:46 ` Björn Bidar
2024-12-17 17:39 ` Ihor Radchenko
2024-12-19 21:55 ` Björn Bidar
2024-12-21 12:03 ` Ihor Radchenko
2024-12-17 3:42 ` Karthik Chikmagalur
2024-12-17 17:40 ` Ihor Radchenko
2024-12-19 23:20 ` Björn Bidar
2024-12-20 0:45 ` Karthik Chikmagalur
2024-12-21 12:05 ` Ihor Radchenko
2024-12-23 20:41 ` Björn Bidar
[not found] ` <6764aa79.050a0220.23273b.09a5SMTPIN_ADDED_BROKEN@mx.google.com>
2024-12-26 18:46 ` Karthik Chikmagalur
2024-12-29 15:44 ` Björn Bidar [this message]
2024-12-30 17:05 ` Ihor Radchenko
2024-12-18 6:21 ` stardiviner
2024-12-18 6:33 ` Karthik Chikmagalur
2024-12-19 23:26 ` Björn Bidar
2024-12-21 12:09 ` Ihor Radchenko
2024-12-08 19:18 Björn Bidar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734i68peo.fsf@ \
--to=bjorn.bidar@thaodan.de \
--cc=emacs-orgmode@gnu.org \
--cc=karthikchikmagalur@gmail.com \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).