problem with org-toggle-inline-images

problem with org-toggle-inline-images

[Johannes Brauer]

Hi!
Frequently I publish org-mode documents containing source code blocks to html (htmlize) and pdf (minted). I would like to see the same colors in both export types. But 
I cannot figure out, what’s the best way to achieve this.

Has anyone solved this problem? Are there any hints?

Johannes

problem with org-toggle-inline-images

[Johannes Brauer]

Hi!
Typing C-c C-x C-v the image is displayed in the org buffer correctly. Typing C-c C-x C-v again the image does not disappear and I get the error message:

org-toggle-inline-images: Symbol’s value as variable is void: image-map

Any hints what is going wrong?

I am using
Aquamacs 3.5  GNU Emacs 25.3.50.1 (x86_64-apple-darwin16.7.0, NS
macOs 10.15.2
Org mode version 9.3 (9.3-8-geab7c4-elpa

Johannes

Re: problem with org-toggle-inline-images

[Marco Wahl]

Hi Johannes,

Thanks for the report.

> Typing C-c C-x C-v the image is displayed in the org buffer
> correctly. Typing C-c C-x C-v again the image does not disappear and I
> get the error message:
>
> org-toggle-inline-images: Symbol’s value as variable is void: image-map
>
> Any hints what is going wrong?

Possibly variable image-map is not used correctly in Org or should not
be used at all.  The easiest fix would be to drop the usage of that
variable within Org, I guess.

Does the issue disappear when you do

M-: (require 'image) RET

before the image toggling?


Ciao,
     Marco

Re: problem with org-toggle-inline-images

[Johannes Brauer]

[-- Attachment #1: Type: text/plain, Size: 884 bytes --]

Hi Marco,

thank for your answer

Am 24.12.2019 um 11:00 schrieb Marco Wahl <marcowahlsoft@gmail.com<mailto:marcowahlsoft@gmail.com>>:

The following message is a courtesy copy of an article
that has been posted to gmane.emacs.orgmode as well.

Hi Johannes,

Thanks for the report.

Typing C-c C-x C-v the image is displayed in the org buffer
correctly. Typing C-c C-x C-v again the image does not disappear and I
get the error message:

org-toggle-inline-images: Symbol’s value as variable is void: image-map

Any hints what is going wrong?

Possibly variable image-map is not used correctly in Org or should not
be used at all.  The easiest fix would be to drop the usage of that
variable within Org, I guess.

Does the issue disappear when you do

M-: (require 'image) RET

before the image toggling?
no, the behavior remains the same.

Johannes

[-- Attachment #2: Type: text/html, Size: 6302 bytes --]

Re: problem with org-toggle-inline-images

[Johannes Brauer]

[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]

It seems that the problem arised since I’ve upgraded orgmode from version 9.2.6 (9.2.6-4-ge30905-elpa to version 9.3 (9.3-8-geab7c4-elpa.
On a system where the older version is installed, toggling works fine.

Johannes


Am 24.12.2019 um 11:30 schrieb Johannes Brauer <brauer@nordakademie.de<mailto:brauer@nordakademie.de>>:

Hi Marco,

thank for your answer

Am 24.12.2019 um 11:00 schrieb Marco Wahl <marcowahlsoft@gmail.com<mailto:marcowahlsoft@gmail.com>>:

The following message is a courtesy copy of an article
that has been posted to gmane.emacs.orgmode as well.

Hi Johannes,

Thanks for the report.

Typing C-c C-x C-v the image is displayed in the org buffer
correctly. Typing C-c C-x C-v again the image does not disappear and I
get the error message:

org-toggle-inline-images: Symbol’s value as variable is void: image-map

Any hints what is going wrong?

Possibly variable image-map is not used correctly in Org or should not
be used at all.  The easiest fix would be to drop the usage of that
variable within Org, I guess.

Does the issue disappear when you do

M-: (require 'image) RET

before the image toggling?
no, the behavior remains the same.

Johannes


[-- Attachment #2: Type: text/html, Size: 6135 bytes --]

Re: problem with org-toggle-inline-images

[briangpowell .]

[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]

I use iimage-mode

Have you tried iimage-mode?

Notice the 2 i's in iimage

Toggling works great with iimage-mode

On Tue, Dec 24, 2019 at 8:09 AM Johannes Brauer <brauer@nordakademie.de>
wrote:

> It seems that the problem arised since I’ve upgraded orgmode from version
> 9.2.6 (9.2.6-4-ge30905-elpa to version 9.3 (9.3-8-geab7c4-elpa.
> On a system where the older version is installed, toggling works fine.
>
> Johannes
>
>
> Am 24.12.2019 um 11:30 schrieb Johannes Brauer <brauer@nordakademie.de>:
>
> Hi Marco,
>
> thank for your answer
>
> Am 24.12.2019 um 11:00 schrieb Marco Wahl <marcowahlsoft@gmail.com>:
>
> The following message is a courtesy copy of an article
> that has been posted to gmane.emacs.orgmode as well.
>
> Hi Johannes,
>
> Thanks for the report.
>
> Typing C-c C-x C-v the image is displayed in the org buffer
> correctly. Typing C-c C-x C-v again the image does not disappear and I
> get the error message:
>
> org-toggle-inline-images: Symbol’s value as variable is void: image-map
>
> Any hints what is going wrong?
>
>
> Possibly variable image-map is not used correctly in Org or should not
> be used at all.  The easiest fix would be to drop the usage of that
> variable within Org, I guess.
>
> Does the issue disappear when you do
>
> M-: (require 'image) RET
>
> before the image toggling?
>
> no, the behavior remains the same.
>
> Johannes
>
>
>

[-- Attachment #2: Type: text/html, Size: 5056 bytes --]

Re: problem with org-toggle-inline-images

[Johannes Brauer]

[-- Attachment #1: Type: text/plain, Size: 1689 bytes --]

I didn’t heard of image-mode. Perhaps I will give it a try.
But until orgmode version 9.2.6 worked  without it.


Am 24.12.2019 um 20:14 schrieb briangpowell . <briangpowellms@gmail.com<mailto:briangpowellms@gmail.com>>:

I use iimage-mode

Have you tried iimage-mode?

Notice the 2 i's in iimage

Toggling works great with iimage-mode

On Tue, Dec 24, 2019 at 8:09 AM Johannes Brauer <brauer@nordakademie.de<mailto:brauer@nordakademie.de>> wrote:
It seems that the problem arised since I’ve upgraded orgmode from version 9.2.6 (9.2.6-4-ge30905-elpa to version 9.3 (9.3-8-geab7c4-elpa.
On a system where the older version is installed, toggling works fine.

Johannes


Am 24.12.2019 um 11:30 schrieb Johannes Brauer <brauer@nordakademie.de<mailto:brauer@nordakademie.de>>:

Hi Marco,

thank for your answer

Am 24.12.2019 um 11:00 schrieb Marco Wahl <marcowahlsoft@gmail.com<mailto:marcowahlsoft@gmail.com>>:

The following message is a courtesy copy of an article
that has been posted to gmane.emacs.orgmode as well.

Hi Johannes,

Thanks for the report.

Typing C-c C-x C-v the image is displayed in the org buffer
correctly. Typing C-c C-x C-v again the image does not disappear and I
get the error message:

org-toggle-inline-images: Symbol’s value as variable is void: image-map

Any hints what is going wrong?

Possibly variable image-map is not used correctly in Org or should not
be used at all.  The easiest fix would be to drop the usage of that
variable within Org, I guess.

Does the issue disappear when you do

M-: (require 'image) RET

before the image toggling?
no, the behavior remains the same.

Johannes



[-- Attachment #2: Type: text/html, Size: 6417 bytes --]

Re: problem with org-toggle-inline-images

[Marco Wahl]

Johannes Brauer <brauer@nordakademie.de> writes:

> Typing C-c C-x C-v the image is displayed in the org buffer
> correctly. Typing C-c C-x C-v again the image does not disappear and I
> get the error message:
>
> org-toggle-inline-images: Symbol’s value as variable is void: image-map
>
> Any hints what is going wrong?
>
> I am using
> Aquamacs 3.5  GNU Emacs 25.3.50.1 (x86_64-apple-darwin16.7.0, NS
> macOs 10.15.2
> Org mode version 9.3 (9.3-8-geab7c4-ELPA

IIUC variable image-map was introduced with Emacs 26.  This looks like a
good explanation of the behavior in your environment.

A natural fix is committed, I think.  Would be great if you could test
this fix.

If you want to use the image key map to rotate and zoom inline images in
Org you need to upgrade to Emacs 26, though.


Thanks again and best regards.

Re: problem with org-toggle-inline-images

[Nicolas Goaziou]

Hello,

Marco Wahl <marcowahlsoft@gmail.com> writes:

> A natural fix is committed, I think.  Would be great if you could test
> this fix.

Thank you for the fix.

Could you refactor it so belongs to org-compat.el? For example, we could
create image-map keymap there if Emacs < 26.

Regards,

-- 
Nicolas Goaziou

Re: problem with org-toggle-inline-images

[Marco Wahl]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> Marco Wahl <marcowahlsoft@gmail.com> writes:
>
>> A natural fix is committed, I think.  Would be great if you could test
>> this fix.
>
> Thank you for the fix.
>
> Could you refactor it so belongs to org-compat.el? For example, we could
> create image-map keymap there if Emacs < 26.

Okay, I make a TODO out of this and try to work on the task soon.  Right
now I'm on my way outside... :)


Ciao