* 2nd org-done when invoked from Agenda bug
@ 2007-08-03 21:17 max
2007-08-09 5:05 ` Carsten Dominik
0 siblings, 1 reply; 4+ messages in thread
From: max @ 2007-08-03 21:17 UTC (permalink / raw)
To: emacs-orgmode
$ cat ~/org-bug.el
(add-to-list 'load-path "~/org-5.04")
(require 'org)
(add-to-list 'auto-mode-alist (cons "\\.org$" 'org-mode))
(setq org-agenda-files '("~/test.org"))
(setq org-log-done t)
$ cat ~/test.org
* Not used :bleah:
** TODO one
** TODO two
$ emacs --no-init-file
M-x load-file ~/org-bug.el RET ;; set up the test case
M-x org-agenda RET ;; run agenda command
t ;; press t key to display list of todos
;; the following buffer is displayemwd
-----------------------------------------------------
Global list of TODO items of type: ALL
Available with `N r': (0)ALL (1)TODO (2)DONE
test: TODO one
test: TODO two
-----------------------------------------------------
press <down> twice ;; cursor is on first TODO
press t ;; TODO changes to DONE
press <down> ;; cursor is on the 2nd TODO
press t ;; Agenda buffer changes to this
-----------------------------------------------------
Global list of TODO items of type: ALL
Available with `N r': (0)ALL (1)TODO (2)DONE
test: DONE one
test: one
-----------------------------------------------------
And the 2nd TODO is not marked as DONE but remains unchanged
in the ~/test.org buffer.
Does not happen if org-log-done is not set.
Regards,
Max
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: 2nd org-done when invoked from Agenda bug 2007-08-03 21:17 2nd org-done when invoked from Agenda bug max @ 2007-08-09 5:05 ` Carsten Dominik 2007-08-12 4:57 ` Max Mikhanosha 0 siblings, 1 reply; 4+ messages in thread From: Carsten Dominik @ 2007-08-09 5:05 UTC (permalink / raw) To: max; +Cc: emacs-orgmode I cannot reproduce this bug. Anyone? - Carsten On Aug 3, 2007, at 23:17, max@openchat.com wrote: > $ cat ~/org-bug.el > > (add-to-list 'load-path "~/org-5.04") > (require 'org) > (add-to-list 'auto-mode-alist (cons "\\.org$" 'org-mode)) > (setq org-agenda-files '("~/test.org")) > (setq org-log-done t) > > $ cat ~/test.org > > * Not used :bleah: > ** TODO one > ** TODO two > > $ emacs --no-init-file > M-x load-file ~/org-bug.el RET ;; set up the test case > M-x org-agenda RET ;; run agenda command > t ;; press t key to display list of todos > ;; the following buffer is displayemwd > ----------------------------------------------------- > Global list of TODO items of type: ALL > Available with `N r': (0)ALL (1)TODO (2)DONE > test: TODO one > test: TODO two > ----------------------------------------------------- > press <down> twice ;; cursor is on first TODO > press t ;; TODO changes to DONE > press <down> ;; cursor is on the 2nd TODO > press t ;; Agenda buffer changes to this > ----------------------------------------------------- > Global list of TODO items of type: ALL > Available with `N r': (0)ALL (1)TODO (2)DONE > test: DONE one > test: one > ----------------------------------------------------- > > And the 2nd TODO is not marked as DONE but remains unchanged > in the ~/test.org buffer. > > Does not happen if org-log-done is not set. > > Regards, > Max > > > > _______________________________________________ > Emacs-orgmode mailing list > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode > > -- Carsten Dominik Sterrenkundig Instituut "Anton Pannekoek" Universiteit van Amsterdam Kruislaan 403 NL-1098SJ Amsterdam phone: +31 20 525 7477 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 2nd org-done when invoked from Agenda bug 2007-08-09 5:05 ` Carsten Dominik @ 2007-08-12 4:57 ` Max Mikhanosha 2007-08-12 6:30 ` Carsten Dominik 0 siblings, 1 reply; 4+ messages in thread From: Max Mikhanosha @ 2007-08-12 4:57 UTC (permalink / raw) To: emacs-orgmode At Thu, 9 Aug 2007 07:05:55 +0200, Carsten Dominik wrote: > > I cannot reproduce this bug. Anyone? > Its easy to reproduce, are you sure you doing it with org-log-done set to 't? Here is my understanding of the bug after debugging it a bit, please correct me if I'm wrong: when agenda buffer is constructed, for each item in the agenda buffer it remembers a position back into the original org buffer. These positions are used for example in follow mode triggered by pressing F key. When org buffer contains 2 TODOs like so: ** TODO one ** TODO two If one uses F follow mode in agenda, then as you move cursor in agenda buffer, the correct TODO line in the org buffer is highlighted. Now press T to mark 1st TODO DONE. It inserts a line into original org buffer like so: ** TODO one CLOSED: <whatever> ** TODO two Now the F follow mode highlights the CLOSED line instead of the "TODO two" line when cursor is on the 2nd TODO in the agenda buffer. Basically it highlights the same line where the 2nd TODO _used_ to be, if the CLOSED line was not inserted. I can 100% reproduce this with either my own multi-tty emacs compile, or with the stock emacs that comes with suse 10.2, with only org.el loaded and with --no-init-file Regards, Max > - Carsten > > On Aug 3, 2007, at 23:17, max@openchat.com wrote: > > > $ cat ~/org-bug.el > > > > (add-to-list 'load-path "~/org-5.04") > > (require 'org) > > (add-to-list 'auto-mode-alist (cons "\\.org$" 'org-mode)) > > (setq org-agenda-files '("~/test.org")) > > (setq org-log-done t) > > > > $ cat ~/test.org > > > > * Not used :bleah: > > ** TODO one > > ** TODO two > > > > $ emacs --no-init-file > > M-x load-file ~/org-bug.el RET ;; set up the test case > > M-x org-agenda RET ;; run agenda command > > t ;; press t key to display list of todos > > ;; the following buffer is displayemwd > > ----------------------------------------------------- > > Global list of TODO items of type: ALL > > Available with `N r': (0)ALL (1)TODO (2)DONE > > test: TODO one > > test: TODO two > > ----------------------------------------------------- > > press <down> twice ;; cursor is on first TODO > > press t ;; TODO changes to DONE > > press <down> ;; cursor is on the 2nd TODO > > press t ;; Agenda buffer changes to this > > ----------------------------------------------------- > > Global list of TODO items of type: ALL > > Available with `N r': (0)ALL (1)TODO (2)DONE > > test: DONE one > > test: one > > ----------------------------------------------------- > > > > And the 2nd TODO is not marked as DONE but remains unchanged > > in the ~/test.org buffer. > > > > Does not happen if org-log-done is not set. > > > > Regards, > > Max > > > > > > > > _______________________________________________ > > Emacs-orgmode mailing list > > Emacs-orgmode@gnu.org > > http://lists.gnu.org/mailman/listinfo/emacs-orgmode > > > > > > -- > Carsten Dominik > Sterrenkundig Instituut "Anton Pannekoek" > Universiteit van Amsterdam > Kruislaan 403 > NL-1098SJ Amsterdam > phone: +31 20 525 7477 > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 2nd org-done when invoked from Agenda bug 2007-08-12 4:57 ` Max Mikhanosha @ 2007-08-12 6:30 ` Carsten Dominik 0 siblings, 0 replies; 4+ messages in thread From: Carsten Dominik @ 2007-08-12 6:30 UTC (permalink / raw) To: Max Mikhanosha; +Cc: emacs-orgmode On Aug 12, 2007, at 6:57, Max Mikhanosha wrote: > At Thu, 9 Aug 2007 07:05:55 +0200, Carsten > Dominik wrote: >> >> I cannot reproduce this bug. Anyone? >> > Its easy to reproduce, are you sure you doing it with org-log-done set > to 't? Yes, I forgot this. Now I can reproduce it. THe bug is fixed for the next version, thanks. - Carsten > > Here is my understanding of the bug after debugging it a bit, please > correct me if I'm wrong: when agenda buffer is constructed, for each > item in the agenda buffer it remembers a position back into the > original org buffer. These positions are used for example in follow > mode triggered by pressing F key. > > When org buffer contains 2 TODOs like so: > > ** TODO one > ** TODO two > > If one uses F follow mode in agenda, then as you move cursor in agenda > buffer, the correct TODO line in the org buffer is highlighted. > > Now press T to mark 1st TODO DONE. It inserts a line into original org > buffer like so: > > ** TODO one > CLOSED: <whatever> > ** TODO two > > Now the F follow mode highlights the CLOSED line instead of the "TODO > two" line when cursor is on the 2nd TODO in the agenda > buffer. Basically it highlights the same line where the 2nd TODO > _used_ to be, if the CLOSED line was not inserted. > > I can 100% reproduce this with either my own multi-tty emacs compile, > or with the stock emacs that comes with suse 10.2, with only org.el > loaded and with --no-init-file > > Regards, > Max > >> - Carsten >> >> On Aug 3, 2007, at 23:17, max@openchat.com wrote: >> >>> $ cat ~/org-bug.el >>> >>> (add-to-list 'load-path "~/org-5.04") >>> (require 'org) >>> (add-to-list 'auto-mode-alist (cons "\\.org$" 'org-mode)) >>> (setq org-agenda-files '("~/test.org")) >>> (setq org-log-done t) >>> >>> $ cat ~/test.org >>> >>> * Not used :bleah: >>> ** TODO one >>> ** TODO two >>> >>> $ emacs --no-init-file >>> M-x load-file ~/org-bug.el RET ;; set up the test case >>> M-x org-agenda RET ;; run agenda command >>> t ;; press t key to display list of >>> todos >>> ;; the following buffer is >>> displayemwd >>> ----------------------------------------------------- >>> Global list of TODO items of type: ALL >>> Available with `N r': (0)ALL (1)TODO (2)DONE >>> test: TODO one >>> test: TODO two >>> ----------------------------------------------------- >>> press <down> twice ;; cursor is on first TODO >>> press t ;; TODO changes to DONE >>> press <down> ;; cursor is on the 2nd TODO >>> press t ;; Agenda buffer changes to this >>> ----------------------------------------------------- >>> Global list of TODO items of type: ALL >>> Available with `N r': (0)ALL (1)TODO (2)DONE >>> test: DONE one >>> test: one >>> ----------------------------------------------------- >>> >>> And the 2nd TODO is not marked as DONE but remains unchanged >>> in the ~/test.org buffer. >>> >>> Does not happen if org-log-done is not set. >>> >>> Regards, >>> Max >>> >>> >>> >>> _______________________________________________ >>> Emacs-orgmode mailing list >>> Emacs-orgmode@gnu.org >>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode >>> >>> >> >> -- >> Carsten Dominik >> Sterrenkundig Instituut "Anton Pannekoek" >> Universiteit van Amsterdam >> Kruislaan 403 >> NL-1098SJ Amsterdam >> phone: +31 20 525 7477 >> > > > _______________________________________________ > Emacs-orgmode mailing list > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode > > -- Carsten Dominik Sterrenkundig Instituut "Anton Pannekoek" Universiteit van Amsterdam Kruislaan 403 NL-1098SJ Amsterdam phone: +31 20 525 7477 ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-08-12 6:31 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2007-08-03 21:17 2nd org-done when invoked from Agenda bug max 2007-08-09 5:05 ` Carsten Dominik 2007-08-12 4:57 ` Max Mikhanosha 2007-08-12 6:30 ` Carsten Dominik
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).