From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tassilo Horn Subject: Re: Small fix for Gnus integration Date: Mon, 06 Jul 2009 20:16:32 +0200 Message-ID: <871votpthb.fsf@thinkpad.tsdh.de> References: <87zlblscr0.fsf@delenn.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MNskL-0006Af-Nd for emacs-orgmode@gnu.org; Mon, 06 Jul 2009 14:16:57 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MNskG-0006A7-Mc for emacs-orgmode@gnu.org; Mon, 06 Jul 2009 14:16:56 -0400 Received: from [199.232.76.173] (port=33122 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MNskG-0006A4-Il for emacs-orgmode@gnu.org; Mon, 06 Jul 2009 14:16:52 -0400 Received: from main.gmane.org ([80.91.229.2]:59053 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MNskG-0008GK-6N for emacs-orgmode@gnu.org; Mon, 06 Jul 2009 14:16:52 -0400 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1MNskB-0004zx-R5 for emacs-orgmode@gnu.org; Mon, 06 Jul 2009 18:16:47 +0000 Received: from p54af2289.dip0.t-ipconnect.de ([84.175.34.137]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 06 Jul 2009 18:16:47 +0000 Received: from tassilo by p54af2289.dip0.t-ipconnect.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 06 Jul 2009 18:16:47 +0000 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Andreas Rottmann writes: Hi Andreas, > Without the following patch, storing links to Gnus Article buffers > fails on CVS Emacs, as they (at least in my setup -- IMAP) always > contain a "From " line, which can't be parsed as an RFC822 header. Could you elaborate a bit, i.e. provide such an example mail? > diff --git a/lisp/org-gnus.el b/lisp/org-gnus.el > index 41b1be7..4cc5adb 100644 > --- a/lisp/org-gnus.el > +++ b/lisp/org-gnus.el > @@ -128,6 +128,8 @@ If `org-store-link' was called with a prefix arg the meaning of > (header (with-current-buffer gnus-article-buffer > (gnus-summary-toggle-header 1) > (goto-char (point-min)) > + (when (looking-at "From ") > + (next-line)) > (mail-header-extract-no-properties))) > (from (mail-header 'from header)) > (message-id (org-remove-angle-brackets Looking at the patch, I get the impression, that it's a solution to a problem you created on your own. ;-) If the first line of a mail starts with "From ", I'd say it's broken. ,----[ http://cr.yp.to/immhf/field.html ] | The first line of a field begins with a name and a colon. The name is a | string of one or more graphical ASCII characters other than colons, | i.e., bytes between 33 and 126 inclusive other than 58. `---- The space has the ASCII code 32, so IMO it's not allowed as header field name. Bye, Tassilo