[PATCH] Fixes org-rmail-store-link

[PATCH] Fixes org-rmail-store-link

[T.F. Torrey]

[-- Attachment #1: Type: text/plain, Size: 1129 bytes --]

Hello all,

Attempting to save a link in an Rmail buffer fails with the error
"Wrong type argument: arrayp, nil".

Attempting to save a link in an Rmail buffer succeeds if all headers
are shown (by pressing T to toggle the display).

Attempting to save a link in an Rmail summary buffer always fails with
the same error, even if all headers are shown.

The error occurs because org-rmail-store-link attempts to get the
Message-ID header with mail-fetch-field, then remove the angle
brackets with org-remove-angle-brackets. However, without showing full
headers, Message-ID is hidden, and (mail-fetch-field "message-id)
returns nil. When this is passed to org-remove-angle-brackets, the
error is thrown.

The attached patch remedies this by toggling on the full header display
before getting the Message-ID.

Emacs  : GNU Emacs 24.1.50.1 (i686-pc-linux-gnu, GTK+ Version 3.4.2)
 of 2012-07-29 on doubah, modified by Debian

Package: Org-mode version 7.8.11 (release_7.8.11-360-g7c4ac5-git @ mixed
installation! /usr/local/share/emacs/site-lisp/ and
/home/tftorrey/.emacs.d/src/org-mode/lisp/)

Best to all,
Terry
-- 
T.F. Torrey


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Patch to fix org-rmail-store-link bug in org-rmail.el --]
[-- Type: text/x-diff, Size: 446 bytes --]

diff --git a/lisp/org-rmail.el b/lisp/org-rmail.el
index cb379d3..f8abbf4 100644
--- a/lisp/org-rmail.el
+++ b/lisp/org-rmail.el
@@ -52,6 +52,7 @@
 	  (rmail-show-message rmail-current-message))
 	(when (fboundp 'rmail-narrow-to-non-pruned-header)
 	  (rmail-narrow-to-non-pruned-header))
+	(rmail-toggle-header 0)
 	(let* ((folder buffer-file-name)
 	       (message-id (mail-fetch-field "message-id"))
 	       (from (mail-fetch-field "from"))

Re: [PATCH] Fixes org-rmail-store-link

[Nick Dokos]

T.F. Torrey <tftorrey@tftorrey.com> wrote:

> ,..
> 
> The error occurs because org-rmail-store-link attempts to get the
> Message-ID header with mail-fetch-field, then remove the angle
> brackets with org-remove-angle-brackets. However, without showing full
> headers, Message-ID is hidden, and (mail-fetch-field "message-id)
> returns nil. When this is passed to org-remove-angle-brackets, the
> error is thrown.
> 
> The attached patch remedies this by toggling on the full header display
> before getting the Message-ID.
> 

Shouldn't it be toggled off afterwards?

Nick

Re: [PATCH] Fixes org-rmail-store-link

[T.F. Torrey]

Nick Dokos <nicholas.dokos@hp.com> writes:

>> The attached patch remedies this by toggling on the full header display
>> before getting the Message-ID.
>> 
>
> Shouldn't it be toggled off afterwards?

That would seem logical to me, too, but the internal workings of
org-rmail.el and the rmail functions (which I don't fully understand)
already always leave the headers toggled off.

In the long run, this should probably be changed to respect the state
prior to storing the link, but for now, Bastien's patch makes the
linking function work.

Terry
-- 
T.F. Torrey

Re: [PATCH] Fixes org-rmail-store-link

[Bastien]

Hi,

tftorrey@tftorrey.com (T.F. Torrey) writes:

> Attempting to save a link in an Rmail buffer fails with the error
> "Wrong type argument: arrayp, nil".

This is fixed now, thanks.

I used a slightly different fix, taking `rmail-header-style' into
account.  Thanks anyway for the patch!

Best,

-- 
 Bastien

Re: [PATCH] Fixes org-rmail-store-link

[T.F. Torrey]

> This is fixed now, thanks.
>
> I used a slightly different fix, taking `rmail-header-style' into
> account.  Thanks anyway for the patch!

It works for me. Thanks for the quick fix. Although ...

-- 
T.F. Torrey