Re: org-capture with org-contacts template causing problems

[Frank Terbeck <ft@bewatermyfriend.org>]

Frank Terbeck wrote:
> Frank Terbeck wrote:
> [...]
>> When using `org-capture' (and then selecting "c" in the menu window), I
>> get the following error message in the "CAPTURE-contacts.org" buffer:
>>
>> * %![Error: (invalid-function gnus-with-article-headers)]
>> :PROPERTIES:
>> :EMAIL: %![Error: (invalid-function gnus-with-article-headers)]
>> :END:
> [...]
>
> Turns out, this problem is triggered when I byte-compile org-contacts.el
> inside my .emacs.d directory. The compilation process yields the
> following warnings:
>
> Compiling /home/hawk/.emacs.d/vendor/org-contacts.el...
[...]
> vendor/org-contacts.el:870:1:Warning: the following functions are not known to
>     be defined: org-reverse-string, mail-abbrev-in-expansion-header-p,
>     gnus-with-article-headers, diary-ordinal-suffix, gnus-with-article-buffer,
>     elmo-message-field, std11-narrow-to-header, std11-fetch-field,
>     erc-get-channel-user-list, org-install-letbind, google-maps-static-show
> Wrote /home/hawk/.emacs.d/vendor/org-contacts.elc
>
>
> `org-capture' with the `org-contacts' template works fine if I move the
> corresponding .elc file out of the way.
>
> My guess is, that there are a few `requires' missing in the
> `eval-and-compile' form on top of `org-contacts.el'. Maybe someone with
> more intimate knowledge of the involved code than myself has an idea as
> to how to fix this?

Here's a diff, that removes some of the warnings and in turn makes my
use-case work again, even with a byte-compiled `org-contacts.el':


diff --git a/vendor/org-contacts.el b/vendor/org-contacts.el
index 4ffe360..f6234b6 100644
--- a/vendor/org-contacts.el
+++ b/vendor/org-contacts.el
@@ -42,6 +42,8 @@
 (eval-and-compile
   (require 'org))
 (require 'gnus-util)
+(require 'gnus-art)
+(require 'mail-utils)
 (require 'org-agenda)
 (require 'org-capture)
 
I guess, similar additions could fix the other warnings as well.

Regards, Frank