From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Dokos Subject: Re: bug(?) ox-html always add a timestamp in comment which can't be customized away Date: Sat, 08 Jun 2013 02:04:14 -0400 Message-ID: <871u8dkujl.fsf@pierrot.dokosmarshall.org> References: <87ehcdkw3g.fsf@pierrot.dokosmarshall.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46561) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UlCGH-0006Qr-3v for emacs-orgmode@gnu.org; Sat, 08 Jun 2013 02:04:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UlCGF-00039v-UI for emacs-orgmode@gnu.org; Sat, 08 Jun 2013 02:04:25 -0400 Received: from plane.gmane.org ([80.91.229.3]:34458) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UlCGF-00039i-NT for emacs-orgmode@gnu.org; Sat, 08 Jun 2013 02:04:23 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1UlCGD-0004vW-ER for emacs-orgmode@gnu.org; Sat, 08 Jun 2013 08:04:21 +0200 Received: from pool-108-7-96-134.bstnma.fios.verizon.net ([108.7.96.134]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 08 Jun 2013 08:04:21 +0200 Received: from ndokos by pool-108-7-96-134.bstnma.fios.verizon.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 08 Jun 2013 08:04:21 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Haojun Bao writes: > Just checked, it is the same tag (release_8.0.3), there is no change like in your code. > > Could you please run git blame on those lines? You need to upgrade to latest. Git blame says: ,---- | $ git blame -L 1509,1511 lisp/ox-html.el | d574bf52 (Kodi Arfer 2013-05-30 15:19:57 -0400 1509) (when (plist-get info :time-stamp-file) | d574bf52 (Kodi Arfer 2013-05-30 15:19:57 -0400 1510) (format-time-string | d574bf52 (Kodi Arfer 2013-05-30 15:19:57 -0400 1511) (concat "\n"))) `---- and the commit shows the change from the code you see to the code I see: ,---- | nick@pierrot:~/src/emacs/org/org-mode$ git show d574bf52 | commit d574bf522d1b2ac74cb4245f8742253bde7861df | Author: Kodi Arfer | Date: Thu May 30 15:19:57 2013 -0400 | | ox-html: Fix handling of time-stamp-file | | * lisp/ox-html.el (org-html--build-meta-info): Insert no timestamp | when :time-stamp-file is nil. | | TINYCHANGE | | diff --git a/lisp/ox-html.el b/lisp/ox-html.el | index 297cb55..949c3ba 100644 | --- a/lisp/ox-html.el | +++ b/lisp/ox-html.el | @@ -1506,10 +1506,9 @@ INFO is a plist used as a communication channel." | "iso-8859-1"))) | (concat | (format "%s\n" title) | - (format | - (when :time-stamp-file | - (format-time-string | - (concat "\n")))) | + (when (plist-get info :time-stamp-file) | + (format-time-string | + (concat "\n"))) | (format | (if (org-html-html5-p info) | (org-html-close-tag "meta" " charset=\"%s\"" info) `---- Nick > > On Sat, Jun 8, 2013 at 1:30 PM, Nick Dokos wrote: > > Haojun Bao writes: > > > The culprit code is the following: > > > >   (when :time-stamp-file > >     (format-time-string > >      (concat "\n"))) > > > > This `when' condition is always true, because :time-stamp-file is a > > keyword and always eval to itself, never to nil. > > > > So I think org-export-time-stamp-file should be used instead of > > :time-stamp-file. > > > > What version are you using? In the version I have, the code looks like > this: > >      (when (plist-get info :time-stamp-file) >        (format-time-string >          (concat "\n"))) > > Org-mode version 8.0.3 (release_8.0.3-197-g221768) > [nb: this version includes a few local commits (irrelevant to this subject)] > -- > Nick > -- Nick