From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ingo Lohmar <i.lohmar@gmail.com>
Subject: Re: [PATCH] fix org-insert-todo-heading-respect-content in plain
 list item
Date: Mon, 28 Oct 2013 20:35:50 +0100
Message-ID: <871u35yyqx.fsf@acer.localhost.com>
References: <878uxeu0bh.fsf@acer.localhost.com> <877gcxbxab.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49592)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <i.lohmar@gmail.com>) id 1Vasbb-0008O7-BH
	for emacs-orgmode@gnu.org; Mon, 28 Oct 2013 15:36:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <i.lohmar@gmail.com>) id 1VasbS-0003i2-Jq
	for emacs-orgmode@gnu.org; Mon, 28 Oct 2013 15:36:03 -0400
Received: from mail-ee0-x230.google.com ([2a00:1450:4013:c00::230]:58374)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <i.lohmar@gmail.com>) id 1VasbS-0003ht-DF
	for emacs-orgmode@gnu.org; Mon, 28 Oct 2013 15:35:54 -0400
Received: by mail-ee0-f48.google.com with SMTP id e50so3631283eek.21
	for <emacs-orgmode@gnu.org>; Mon, 28 Oct 2013 12:35:53 -0700 (PDT)
In-Reply-To: <877gcxbxab.fsf@gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Nicolas Goaziou <n.goaziou@gmail.com>
Cc: emacs-orgmode@gnu.org

Hi Nicolas,

sure: emacs -q -nw, and in the scratch buffer

(add-to-list 'load-path "~/src/org-mode/lisp/")   ;refer to HEAD as of yesterday
(org-mode)

;and enter/paste:

* test
- an -!- item
- another one

Then, with the cursor at -!- (for example), hitting <C-S-return> breaks
the line, while it /should/ create a todo heading after the subtree.
Replacing the t with '(4) (which is what org-todo-heading comapres with)
fixes this.

HTH, regards,
Ingo



On Mon, Oct 28 2013 09:43 (+0100), Nicolas Goaziou wrote:

> Hello,
>
> Ingo Lohmar <i.lohmar@gmail.com> writes:
>
>> please find attached a 1-4-char patch fixing the behavior of the above
>> function when inside a plain list.
>
> [...]
>
>> Subject: [PATCH] fix org-insert-todo-heading-respect-content in plain list item
>>
>> * lisp/org.el (org-insert-todo-heading-respect-content): pass correct
>> prefix arg to always insert heading
>>
>> TINYCHANGE
>>
>> This function used a second argument t, which is eventually passed to
>> org-insert-heading, adding a list item when inside a plain list.  Use
>> the proper argument '(4) now, to always create a heading, just like
>> the function's name and documentation imply.
>
> Thank you for your patch.
>
> Could you provide a test case, because, after a quick test, I do not see
> any difference before and after applying your patch.
>
>
> Regards,
>
> -- 
> Nicolas Goaziou