Re: [PATCH] fix org-insert-todo-heading-respect-content in plain list item

[Ingo Lohmar <i.lohmar@gmail.com>]

Hi Nicolas,

sure: emacs -q -nw, and in the scratch buffer

(add-to-list 'load-path "~/src/org-mode/lisp/")   ;refer to HEAD as of yesterday
(org-mode)

;and enter/paste:

* test
- an -!- item
- another one

Then, with the cursor at -!- (for example), hitting <C-S-return> breaks
the line, while it /should/ create a todo heading after the subtree.
Replacing the t with '(4) (which is what org-todo-heading comapres with)
fixes this.

HTH, regards,
Ingo



On Mon, Oct 28 2013 09:43 (+0100), Nicolas Goaziou wrote:

> Hello,
>
> Ingo Lohmar <i.lohmar@gmail.com> writes:
>
>> please find attached a 1-4-char patch fixing the behavior of the above
>> function when inside a plain list.
>
> [...]
>
>> Subject: [PATCH] fix org-insert-todo-heading-respect-content in plain list item
>>
>> * lisp/org.el (org-insert-todo-heading-respect-content): pass correct
>> prefix arg to always insert heading
>>
>> TINYCHANGE
>>
>> This function used a second argument t, which is eventually passed to
>> org-insert-heading, adding a list item when inside a plain list.  Use
>> the proper argument '(4) now, to always create a heading, just like
>> the function's name and documentation imply.
>
> Thank you for your patch.
>
> Could you provide a test case, because, after a quick test, I do not see
> any difference before and after applying your patch.
>
>
> Regards,
>
> -- 
> Nicolas Goaziou