orgstruct-mode taking over C-c C-f

orgstruct-mode taking over C-c C-f

[Eric Abrahamsen]

Hey there,

I use the orgstruct minor mode in message mode, and recently it has
started eating the C-c C-f prefix, which it didn't used to do. Or it's
erroring on it, instead of passing it along, I'm not sure which.

In message mode, C-c C-f is the prefix for a set of "goto mail header"
commands. With orgstruct mode on, hitting C-c C-f gives the backtrace
below.

I'm not sure how this is supposed to work, so I'm not quite sure what
the proper solution is...

Thanks,
Eric

Debugger entered--Lisp error: (void-function set-transient-map)
  (set-transient-map binding)
  (if (keymapp binding) (set-transient-map binding) (let ((func (or binding (unless disable (quote orgstruct-error))))) (when func (call-interactively func))))
  (let* ((orgstruct-mode) (binding (loop with key = "." for rep in (quote (nil ("<\\([^>]*\\)tab>" . "\\1TAB") ("<\\([^>]*\\)return>" . "\\1RET") ("<\\([^>]*\\)escape>" . "\\1ESC") ("<\\([^>]*\\)delete>" . "\\1DEL"))) do (when rep (setq key (read-kbd-macro (let ... ...)))) thereis (key-binding key)))) (if (keymapp binding) (set-transient-map binding) (let ((func (or binding (unless disable (quote orgstruct-error))))) (when func (call-interactively func)))))
  (if fallback (let* ((orgstruct-mode) (binding (loop with key = "." for rep in (quote (nil ("<\\([^>]*\\)tab>" . "\\1TAB") ("<\\([^>]*\\)return>" . "\\1RET") ("<\\([^>]*\\)escape>" . "\\1ESC") ("<\\([^>]*\\)delete>" . "\\1DEL"))) do (when rep (setq key (read-kbd-macro ...))) thereis (key-binding key)))) (if (keymapp binding) (set-transient-map binding) (let ((func (or binding (unless disable ...)))) (when func (call-interactively func))))) (org-run-like-in-org-mode (lambda nil (interactive) (let* ((org-heading-regexp (concat "^" orgstruct-heading-prefix-regexp "\\(\\*+\\)\\(?: +\\(.*?\\)\\)?[		]*$")) (org-outline-regexp (concat orgstruct-heading-prefix-regexp "\\*+ ")) (org-outline-regexp-bol (concat "^" org-outline-regexp)) (outline-regexp org-outline-regexp) (outline-heading-end-regexp "\n") (outline-level (quote org-outline-level)) (outline-heading-alist)) (call-interactively (quote org-forward-heading-same-level))))))
  (let* ((disable nil) (fallback (or disable (not (let* ((org-heading-regexp ...) (org-outline-regexp ...) (org-outline-regexp-bol ...) (outline-regexp org-outline-regexp) (outline-heading-end-regexp "\n") (outline-level ...) (outline-heading-alist)) (org-context-p (quote headline) (quote item) nil)))))) (if fallback (let* ((orgstruct-mode) (binding (loop with key = "." for rep in (quote (nil ... ... ... ...)) do (when rep (setq key ...)) thereis (key-binding key)))) (if (keymapp binding) (set-transient-map binding) (let ((func (or binding ...))) (when func (call-interactively func))))) (org-run-like-in-org-mode (lambda nil (interactive) (let* ((org-heading-regexp (concat "^" orgstruct-heading-prefix-regexp "\\(\\*+\\)\\(?: +\\(.*?\\)\\)?[		]*$")) (org-outline-regexp (concat orgstruct-heading-prefix-regexp "\\*+ ")) (org-outline-regexp-bol (concat "^" org-outline-regexp)) (outline-regexp org-outline-regexp) (outline-heading-end-regexp "\n") (outline-level (quote org-outline-level)) (outline-heading-alist)) (call-interactively (quote org-forward-heading-same-level)))))))
  orgstruct-hijacker-org-forward-heading-same-level-1(1)
  call-interactively(orgstruct-hijacker-org-forward-heading-same-level-1 nil nil)

Re: orgstruct-mode taking over C-c C-f

[Jambunathan K]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Debugger entered--Lisp error: (void-function set-transient-map)

New function in snapshot builds.  From the ChangeLog

2013-12-23  Chong Yidong  <cyd@gnu.org>

	* subr.el (set-transient-map): Rename from
	set-temporary-overlay-map.  Doc fix.

Re: orgstruct-mode taking over C-c C-f

[Jambunathan K]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Debugger entered--Lisp error: (void-function set-transient-map)

New function in snapshot builds.  ChangeLog says

    2013-12-23  Chong Yidong  <cyd@gnu.org>

            * subr.el (set-transient-map): Rename from
            set-temporary-overlay-map.  Doc fix.

Re: orgstruct-mode taking over C-c C-f

[Bastien]

Hi Eric,

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> I'm not sure how this is supposed to work, so I'm not quite sure what
> the proper solution is...

This should now be fixed, please test and report any problem.

Thanks,

-- 
 Bastien

Re: orgstruct-mode taking over C-c C-f

[Eric Abrahamsen]

Bastien <bzg@gnu.org> writes:

> Hi Eric,
>
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> I'm not sure how this is supposed to work, so I'm not quite sure what
>> the proper solution is...
>
> This should now be fixed, please test and report any problem.
>
> Thanks,

It's still doing it! I should be seeing why for myself, if you don't get
to this for a couple of days I hope I'll have time...

E

Re: orgstruct-mode taking over C-c C-f

[Bastien]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> It's still doing it! I should be seeing why for myself, if you don't get
> to this for a couple of days I hope I'll have time...

Did you recompiled Org?

-- 
 Bastien

Re: orgstruct-mode taking over C-c C-f

[Malcolm Purvis]

>>>>> "Bastien" == Bastien  <bzg@gnu.org> writes:

Bastien> Did you recompiled Org?

I can confirm that the problem still exists with a freshly compiled
version of the latest mainline
(240329465b466584f4bf80f24eb881fb3c9285cf).

Also the alias org-set-transient-map doesn't seem to be called, so I
still get the error about the undefined function set-transient-map when
running Emacs 23.3.

Thanks,

Malcolm

-- 
		    Malcolm Purvis <malcolm@purvis.id.au>

Re: orgstruct-mode taking over C-c C-f

[Bastien]

Malcolm Purvis <malcolm@purvis.id.au> writes:

>>>>>> "Bastien" == Bastien  <bzg@gnu.org> writes:
>
> Bastien> Did you recompiled Org?
>
> I can confirm that the problem still exists with a freshly compiled
> version of the latest mainline
> (240329465b466584f4bf80f24eb881fb3c9285cf).
>
> Also the alias org-set-transient-map doesn't seem to be called, so I
> still get the error about the undefined function set-transient-map when
> running Emacs 23.3.

Indeed, my bad, fixed now.

Thanks!

-- 
 Bastien

Re: orgstruct-mode taking over C-c C-f

[Eric Abrahamsen]

Bastien <bzg@gnu.org> writes:

> Malcolm Purvis <malcolm@purvis.id.au> writes:
>
>>>>>>> "Bastien" == Bastien  <bzg@gnu.org> writes:
>>
>> Bastien> Did you recompiled Org?
>>
>> I can confirm that the problem still exists with a freshly compiled
>> version of the latest mainline
>> (240329465b466584f4bf80f24eb881fb3c9285cf).
>>
>> Also the alias org-set-transient-map doesn't seem to be called, so I
>> still get the error about the undefined function set-transient-map when
>> running Emacs 23.3.
>
> Indeed, my bad, fixed now.

Works great, thanks a lot!