Re: patch to add new link type "infoi" that leverages Info-index command

[Nicolas Goaziou <mail@nicolasgoaziou.fr>]

emacs18@gmail.com (Richard Y. Kim) writes:

> Thanks for your feedback.  Attached is new patch which incorporates all
> your suggestions

Applied. Thank you.

> except the following:
>
>> Not directly related to your patch, but shouldn't it be
>>
>>   (user-error "Could not open: %s" name)
>
> I'm not sure what you mean by this.  Do you mean that the verb "open" is
> more approrpriate than "find" in the error message, i.e., "Could not
> open" rather than "Could not find"?  If so, then it seems like "find" is
> more appropriate since "open" seems like there was a problem with
> opening a file when the problem is that a particular node was not found
> after successfully opening a file.  Please let me know if I
> misunderstood.  Thanks again for your valuable feedbacks.

This is simpler than that. I was just saying that (user-error ...) was
probably more appropriate than (message ...) in the last line of the
function. I changed that in another patch.

> Subject: [PATCH] org-info: try info index if info node is not found

Nitpick: Missing capitals after the colons. I fixed it in the patch.
> +			(user-error (format "Could not find '%s' node or index entry" 
> +					    nodename-or-index))))))

I changed this to (user-error "Could not ..." nodename-or-index) since
`format' is not necessary.


Regards,