From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: problems with export and :cache
Date: Thu, 29 Oct 2015 15:22:21 +0100
Message-ID: <871tcdpxeq.fsf@nicolasgoaziou.fr>
References: <olu8u6mk730.fsf@med.uni-goettingen.de>
	<olu4mhak6qc.fsf@med.uni-goettingen.de> <87vb9pyf0l.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54232)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1Zro4I-0005PT-LC
	for emacs-orgmode@gnu.org; Thu, 29 Oct 2015 10:20:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1Zro4H-00073I-M5
	for emacs-orgmode@gnu.org; Thu, 29 Oct 2015 10:20:42 -0400
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:57456)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1Zro4H-00072t-FK
	for emacs-orgmode@gnu.org; Thu, 29 Oct 2015 10:20:41 -0400
In-Reply-To: <87vb9pyf0l.fsf@gmail.com> (Aaron Ecay's message of "Thu, 29 Oct
	2015 13:34:50 +0000")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Andreas Leha <andreas.leha@med.uni-goettingen.de>
Cc: emacs-orgmode@gnu.org

Hello,

Aaron Ecay <aaronecay@gmail.com> writes:

> The simple patch attached to this message fixes a bug that my testing
> indicated was responsible for erroneous re-evaluations at least some
> of the time.

Thank you. A minor comment follows.

>        (cons :result-type  (cond ((member "output" result-params) 'output)
>  				((member "value" result-params) 'value)
>  				(t 'value))))
> -     (org-babel-get-header params :var 'other))))
> +     (loop for item in params
> +	   unless (memq (car item) '(:colname-names
> +				     :rowname-names
> +				     :result-params
> +				     :result-type
> +				     :var))
> +	   collect item))))

Using `loop' here is, IMO, over-doing it. You can use instead, e.g.,

  (org-remove-if
   (lambda (item)
     (memq (car item)
           '(:colname-names :rowname-names :result-params :result-type :var)))
   params)

Another option is to extend `org-babel-get-header' to accept a list of
keys instead of a single key.

In any case, this patch, or a variant thereof, should be applied to
maint.


Regards,

-- 
Nicolas Goaziou