From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Thomas Alexander Gerds <tag@biostat.ku.dk>
Cc: emacs-orgmode@gnu.org
Subject: Re: proposed change of org-gnus-store-link for nnir groups
Date: Wed, 16 Dec 2015 22:09:25 +0100 [thread overview]
Message-ID: <871tamaynu.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <86bn9whtym.fsf@biostat.ku.dk> (Thomas Alexander Gerds's message of "Sat, 12 Dec 2015 10:55:29 +0100")
Hello,
Thomas Alexander Gerds <tag@biostat.ku.dk> writes:
> sometimes after searching for mail with notmuch, I want to save a link
> to one of the articles shown in the nnir summary. since nnir groups are
> temporary I would like org-gnus-store-link to treat nnir groups
> differently and to use the articles orginal group when creating the
> link. the following 3 lines change of org-gnus-store-link does this for
> me. if this is interesting for others maybe it could be integrated
> ... if not, I could either advice org-gnus-store-link or add a modified
> version to org-store-link-functions. comments?
Sounds good. Thank you.
> (when (eq (car (gnus-find-method-for-group gnus-newsgroup-name))
> 'nnvirtual)
> (setq group (car (nnvirtual-map-article
> (gnus-summary-article-number)))))
> + (when (eq (car (gnus-find-method-for-group gnus-newsgroup-name))
> + 'nnir)
> + (setq group (nnir-article-group (gnus-summary-article-number))))
I think the above could be wrapped within a cl-case, if only to compute
(car (gnus-find-method-for-group gnus-newsgroup-name)) only once. Also,
it may require an entry in ORG-NEWS, and a proper commit message.
Would you mind sending an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2015-12-16 21:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-12 9:55 proposed change of org-gnus-store-link for nnir groups Thomas Alexander Gerds
2015-12-16 21:09 ` Nicolas Goaziou [this message]
2015-12-17 6:14 ` Thomas Alexander Gerds
2015-12-17 8:57 ` Nicolas Goaziou
2015-12-18 6:49 ` Thomas Alexander Gerds
2015-12-18 21:45 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871tamaynu.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=tag@biostat.ku.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).