From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: Org campture recursively expands %-escapes
Date: Tue, 12 Jan 2016 00:05:49 +0100
Message-ID: <871t9nra2a.fsf@nicolasgoaziou.fr>
References: <CA+iiQwTLDwpR-ypFitnpe7kKy8Kc0gdx1sixjRn39Vcuzzruxg@mail.gmail.com>
	<CAJcAo8uEAHgs4XeyHCnqx_1AyieA-ZdR-8UntwHd7W_vUom7dg@mail.gmail.com>
	<87d1uwpm1a.fsf@nicolasgoaziou.fr>
	<CAJcAo8uX6Q6GZpNbUVweZ6yCfhcRNj-0niOezHoU5RzqC5Jd=Q@mail.gmail.com>
	<87610o2wkz.fsf@nicolasgoaziou.fr> <87io4kn6cn.fsf@nicolasgoaziou.fr>
	<CALn3zoiVyTBai=c0DPLFsPbiTLa6=Kx=UzVr_yMoFJxyBNZkAw@mail.gmail.com>
	<87oad2qw4z.fsf@nicolasgoaziou.fr>
	<CALn3zohAxc6eMe-eGUhMxF3k+sP-Zqo4tkPSzb2_7xvK2G+BJQ@mail.gmail.com>
	<87bn92qsmb.fsf@nicolasgoaziou.fr>
	<CALn3zojm5eW5+XytNhLZ5SQoH2He2zJBiYkO=k+2atjgi+phFQ@mail.gmail.com>
	<87lh837fzx.fsf@nicolasgoaziou.fr>
	<CALn3zojC7NH6GWnR7q2MbtqpajEJcfiiLN52Dw8fqXgAsq3==w@mail.gmail.com>
	<87h9ipqrez.fsf@nicolasgoaziou.fr>
	<CALn3zogxH2Bx0bXn7SiNEXpesuatvVOJAN0D+zgk+ijxW4a53g@mail.gmail.com>
	<8737u7lmhg.fsf@nicolasgoaziou.fr>
	<CALn3zogf2kBcRUzPn7L6pwXtBjQfu4tsQC2Qc+KxP0R+eHwL7g@mail.gmail.com>
	<87si26kab0.fsf@nicolasgoaziou.fr>
	<CALn3zoi6fWCgcrVM_DyuZ_eBPK8TDkgCmbgvM4f3LFJSYWpB9A@mail.gmail.com>
	<87k2nik594.fsf@nicolasgoaziou.fr>
	<CALn3zohmto_8aPvAr6O8wk=Eco_7vLyVabz30f25gmifQbc3gQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53980)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1aIlVC-0000Xl-E4
	for emacs-orgmode@gnu.org; Mon, 11 Jan 2016 18:03:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1aIlVB-0004AP-HI
	for emacs-orgmode@gnu.org; Mon, 11 Jan 2016 18:03:54 -0500
Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:37780)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1aIlVB-0004AG-BV
	for emacs-orgmode@gnu.org; Mon, 11 Jan 2016 18:03:53 -0500
In-Reply-To: <CALn3zohmto_8aPvAr6O8wk=Eco_7vLyVabz30f25gmifQbc3gQ@mail.gmail.com>
	(Michael Brand's message of "Sun, 10 Jan 2016 09:08:01 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Michael Brand <michael.ch.brand@gmail.com>
Cc: Org Mode <emacs-orgmode@gnu.org>

Hello,

Michael Brand <michael.ch.brand@gmail.com> writes:

> I would like to push the attached change to add some ERTs with the
> commit msg below and would like to ask you for a review first.

It looks good. Thank you. Minor suggestions follow.

>  (ert-deftest test-org-capture/fill-template ()
> -  "Test `org-capture-fill-template' specifications."
> +  "Test `org-capture-fill-template' specifications.
> +The tests here are very similar to those in
> +`test-org-feed/fill-template'."

Not sure the last sentence above is really interesting. Ditto for the
other occurrences.

> -   (string-match-p
> -    (format-time-string (substring (car org-time-stamp-formats) 1 -1))
> +   (equal
> +    (concat "[" (format-time-string
> +		 (substring (car org-time-stamp-formats) 1 -1)) "]\n")
>      (org-capture-fill-template "%u")))
>    (should
> -   (string-match-p
> -    (format-time-string (substring (cdr org-time-stamp-formats) 1 -1))
> +   (equal
> +    (concat "[" (format-time-string
> +		 (substring (cdr org-time-stamp-formats) 1 -1)) "]\n")

I discovered recently (!) `org-time-stamp-formats' which avoids doing
the substring dance. You may want to use it instead. Ditto for the other
occurrences.


Regards,

-- 
Nicolas Goaziou