From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: patch for HTML links to GNU documents
Date: Mon, 28 Mar 2016 10:59:28 +0200
Message-ID: <871t6vrn9r.fsf@nicolasgoaziou.fr>
References: <CAFq8O8uJhF5h=_Wcv8W83wqdaMn2KSxFoVs+Nc83Ey0hS45gJg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60209)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1akSzF-00061X-Dd
	for emacs-orgmode@gnu.org; Mon, 28 Mar 2016 04:57:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1akSzC-0004e7-7I
	for emacs-orgmode@gnu.org; Mon, 28 Mar 2016 04:57:25 -0400
Received: from relay3-d.mail.gandi.net ([217.70.183.195]:48958)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1akSzC-0004dw-0D
	for emacs-orgmode@gnu.org; Mon, 28 Mar 2016 04:57:22 -0400
In-Reply-To: <CAFq8O8uJhF5h=_Wcv8W83wqdaMn2KSxFoVs+Nc83Ey0hS45gJg@mail.gmail.com>
	(Richard Kim's message of "Sun, 27 Mar 2016 15:55:10 -0700")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Richard Kim <emacs18@gmail.com>
Cc: Org-Mode mailing list <emacs-orgmode@gnu.org>

Hello,

Richard Kim <emacs18@gmail.com> writes:

> Attached patch affects how 'info' links in org mode are converted to HTML
> links.  Today info links such as
>
>     [[info:emacs#List Buffers]]
>
> are converted to this HTML link:
>
>     <a href="emacs.html#List-Buffers">emacs#List Buffers</a>
>
> With the patch applied, the HTML link generated would be
>
>     <a href="
> http://www.gnu.org/software/emacs/manual/html_mono/emacs.html#List-Buffers">emacs#List
> Buffers</a>

Thank you. Some comments follow.

> +(defvar org-info-emacs-documents

I suggest to use `defconst' instead, since you're not modifying or
let-binding the variable whatsoever.

> +  '("ada-mode" "auth" "autotype" "bovine" "calc" "ccmode" "cl" "dbus" "dired-x"
> +    "ebrowse" "ede" "ediff" "edt" "efaq-w32" "efaq" "eieio" "eintr" "elisp"
> +    "emacs-gnutls" "emacs-mime" "emacs" "epa" "erc" "ert" "eshell" "eudc" "eww"
> +    "flymake" "forms" "gnus" "htmlfontify" "idlwave" "ido" "info" "mairix-el"
> +    "message" "mh-e" "newsticker" "nxml-mode" "octave-mode" "org" "pcl-cvs"
> +    "pgg" "rcirc" "reftex" "remember" "sasl" "sc" "semantic" "ses" "sieve"
> +    "smtpmail" "speedbar" "srecode" "todo-mode" "tramp" "url" "vip" "viper"
> +    "widget" "wisent" "woman")
> +  "List of emacs documents available at the official URL
> +<http://www.gnu.org/software/emacs/manual/html_mono/.>")

The first sentence in the docstring is expected to be on a single line,
e.g.

  "List of emacs documents available.
  Taken from <http://www.gnu.org/software/emacs/manual/html_mono/.>"

> +(defvar org-info-other-documents

`defconst'

Could you also write an entry about it in ORG-NEWS?


Regards,

-- 
Nicolas Goaziou