emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* MobileOrg Export Broken
@ 2016-06-24  0:57 Ian Dunn
  2016-06-24  7:22 ` Nicolas Goaziou
  0 siblings, 1 reply; 2+ messages in thread
From: Ian Dunn @ 2016-06-24  0:57 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 616 bytes --]


    I run Org from the git repo, updating daily.  I unsuccessfully tried syncing with MobileOrg (Android) about two hours ago.  I reverted org-mobile.el back to the version from yesterday and found the problem: TODO keywords aren't being listed correctly.  Here's an example:

Old:
#+TODO: TODO | DEFERRED DONE PENDING CANCELLED

New:
#+TODO: TODO

    This messes with MobileOrg, preventing it from syncing.

    I worked through the problem, which appears to be caused by org-delete-all being called before the TODO keywords are inserted into the file.  I attached a patch that fixes this problem.

-- 
Ian Dunn


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: org-mobile.el.patch --]
[-- Type: text/x-diff, Size: 585 bytes --]

diff --git a/lisp/org-mobile.el b/lisp/org-mobile.el
index 9c69128..9192561 100644
--- a/lisp/org-mobile.el
+++ b/lisp/org-mobile.el
@@ -446,8 +446,9 @@ agenda view showing the flagged items."
 				      x))
 			     (cdr entry)))
 	       (dwds (or (member "|" kwds) (last kwds)))
-	       (twds (org-delete-all dwds kwds)))
+	       (twds kwds))
 	  (insert "#+TODO: " (mapconcat 'identity kwds " ") "\n")
+	  (org-delete-all dwds twds)
 	  (setq todo-kwds (org-delete-all twds todo-kwds))
 	  (setq done-kwds (org-delete-all dwds done-kwds))))
       (when (or todo-kwds done-kwds)

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: MobileOrg Export Broken
  2016-06-24  0:57 MobileOrg Export Broken Ian Dunn
@ 2016-06-24  7:22 ` Nicolas Goaziou
  0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2016-06-24  7:22 UTC (permalink / raw)
  To: Ian Dunn; +Cc: emacs-orgmode

Hello,

Ian Dunn <dunni@gnu.org> writes:

>     I run Org from the git repo, updating daily. I unsuccessfully
> tried syncing with MobileOrg (Android) about two hours ago. I reverted
> org-mobile.el back to the version from yesterday and found the
> problem: TODO keywords aren't being listed correctly. Here's an
> example:
>
> Old:
> #+TODO: TODO | DEFERRED DONE PENDING CANCELLED
>
> New:
> #+TODO: TODO
>
>     This messes with MobileOrg, preventing it from syncing.
>
>     I worked through the problem, which appears to be caused by
>     org-delete-all being called before the TODO keywords are inserted
>     into the file.  I attached a patch that fixes this problem.

Correct. I pushed a slightly different patch. Thank you.

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-06-24  7:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-24  0:57 MobileOrg Export Broken Ian Dunn
2016-06-24  7:22 ` Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).