From mboxrd@z Thu Jan 1 00:00:00 1970 From: cesar mena Subject: Re: please read: bug when marking tasks done Date: Mon, 07 Jan 2019 10:20:00 -0500 Message-ID: <871s5o8pgf.fsf@gnu.org> References: <87d0paprs6.fsf@gnu.org> <87wonhcpnj.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([209.51.188.92]:49109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggWhJ-0002a0-Sg for emacs-orgmode@gnu.org; Mon, 07 Jan 2019 10:20:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggWhG-0000Je-MI for emacs-orgmode@gnu.org; Mon, 07 Jan 2019 10:20:13 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:46519) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ggWhG-0000Ep-6p for emacs-orgmode@gnu.org; Mon, 07 Jan 2019 10:20:10 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 486EC2229C for ; Mon, 7 Jan 2019 10:20:07 -0500 (EST) Received: from [127.0.1.1] (pool-71-126-174-77.washdc.fios.verizon.net [71.126.174.77]) by mail.messagingengine.com (Postfix) with ESMTPA id 87232E4743 for ; Mon, 7 Jan 2019 10:20:05 -0500 (EST) In-Reply-To: <87wonhcpnj.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Mon, 07 Jan 2019 00:49:52 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode hi nicolas, Nicolas Goaziou writes: > Hello, > > cesar mena writes: > >> hello everyone, >> >> in the maint branch, marking a repeatable task as DONE causes the >> "Rescheduled from" dates to be lost in the :LOGBOOK:. >> >> in the below diff all of the from dates are rewritten with the new >> scheduled date: >> >> - SCHEDULED: <2018-12-04 Tue .+1m> >> + SCHEDULED: <2019-02-05 Tue .+1m> >> :PROPERTIES: >> - :LAST_REPEAT: [2018-08-08 Wed 07:40] >> + :LAST_REPEAT: [2019-01-05 Sat 18:47] >> :END: >> :LOGBOOK: >> - - Rescheduled from "[2018-11-28 Wed .+1m]" on [2018-11-28 Wed 0= 8:35] >> - - Rescheduled from "[2018-11-25 Sun .+1m]" on [2018-11-25 Sun 0= 9:17] >> - - Rescheduled from "[2018-11-20 Tue .+1m]" on [2018-11-22 Thu 1= 0:03] >> - - Rescheduled from "[2018-11-13 Tue .+1m]" on [2018-11-17 Sat 0= 9:48] >> - - Rescheduled from "[2018-11-06 Tue .+1m]" on [2018-11-08 Thu 0= 7:02] >> - - Rescheduled from "[2018-10-28 Sun .+1m]" on [2018-10-30 Tue 1= 6:22] >> - - Rescheduled from "[2018-10-25 Thu .+1m]" on [2018-10-25 Thu 0= 7:34] >> - - Rescheduled from "[2018-10-19 Fri .+1m]" on [2018-10-19 Fri 0= 7:48] >> - - Rescheduled from "[2018-10-16 Tue .+1m]" on [2018-10-16 Tue 1= 6:21] >> - - Rescheduled from "[2018-10-11 Thu .+1m]" on [2018-10-14 Sun 1= 0:31] >> - - Rescheduled from "[2018-10-07 Sun .+1m]" on [2018-10-08 Mon 0= 8:48] >> - - Rescheduled from "[2018-09-27 Thu .+1m]" on [2018-09-29 Sat 1= 8:50] >> - - Rescheduled from "[2018-09-20 Thu .+1m]" on [2018-09-20 Thu 0= 9:50] >> - - Rescheduled from "[2018-09-08 Sat .+1m]" on [2018-09-14 Fri 0= 7:10] >> + - State "DONE" from "TODO" [2019-01-05 Sat 18:47] >> + - Rescheduled from "[2019-02-05 Tue .+1m]" on [2018-11-28 Wed 0= 8:35] >> + - Rescheduled from "[2019-02-05 Tue .+1m]" on [2018-11-25 Sun 0= 9:17] >> + - Rescheduled from "[2019-02-05 Tue .+1m]" on [2018-11-22 Thu 1= 0:03] >> + - Rescheduled from "[2019-02-05 Tue .+1m]" on [2018-11-17 Sat 0= 9:48] >> + - Rescheduled from "[2019-02-05 Tue .+1m]" on [2018-11-08 Thu 0= 7:02] >> + - Rescheduled from "[2019-02-05 Tue .+1m]" on [2018-10-30 Tue 1= 6:22] >> + - Rescheduled from "[2019-02-05 Tue .+1m]" on [2018-10-25 Thu 0= 7:34] >> + - Rescheduled from "[2019-02-05 Tue .+1m]" on [2018-10-19 Fri 0= 7:48] >> + - Rescheduled from "[2019-02-05 Tue .+1m]" on [2018-10-16 Tue 1= 6:21] >> + - Rescheduled from "[2019-02-05 Tue .+1m]" on [2018-10-14 Sun 1= 0:31] >> + - Rescheduled from "[2019-02-05 Tue .+1m]" on [2018-10-08 Mon 0= 8:48] >> + - Rescheduled from "[2019-02-05 Tue .+1m]" on [2018-09-29 Sat 1= 8:50] >> + - Rescheduled from "[2019-02-05 Tue .+1m]" on [2018-09-20 Thu 0= 9:50] >> + - Rescheduled from "[2019-02-05 Tue .+1m]" on [2018-09-14 Fri 0= 7:10] >>=20=20=20 >> bisect says it was introduced in >> af81211fdc01b64449179bcdb77fb1c8ecb3fb94. > > Which is a bugfix=E2=80=A6 as per the documentation for "org-auto-repeat-maybe" only the base date of repeating deadline/scheduled time stamps should change. AFAICT the patch changes every occurrence of an inactive repeating timestamp that is not a comment. > I think a solution would be to remove the repeater from timestamps > inserted upon logging a state change or a re-scheduling. but that is useful and correct information. it lets me know the state of the scheduled timestamp at the time i rescheduled; you are proposing to change this to avoid a re-computation for data that i am sure we agree should be treated as immutable. note that the from dates in the "Rescheduled" line is also in quotes indicating that it is textual information. no longer in play. changing such dates is akin to changing dates in a comment. what do you think? best, -cm