From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jack Kamm <jackkamm@gmail.com>
Subject: Re: [PATCH] Fix ob-python.el initiate session error with py-shell
Date: Tue, 18 Feb 2020 09:18:33 -0800
Message-ID: <871rqrak5y.fsf@gmail.com>
References: <877e0kjbqq.fsf@gmail.com> <874kvnako5.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:52264)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <jackkamm@gmail.com>) id 1j46W7-0000BI-1f
 for emacs-orgmode@gnu.org; Tue, 18 Feb 2020 12:18:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <jackkamm@gmail.com>) id 1j46W6-0001s5-1i
 for emacs-orgmode@gnu.org; Tue, 18 Feb 2020 12:18:38 -0500
Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]:36371)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <jackkamm@gmail.com>) id 1j46W5-0001ra-Sj
 for emacs-orgmode@gnu.org; Tue, 18 Feb 2020 12:18:38 -0500
Received: by mail-pj1-x1041.google.com with SMTP id gv17so1280017pjb.1
 for <emacs-orgmode@gnu.org>; Tue, 18 Feb 2020 09:18:37 -0800 (PST)
In-Reply-To: <874kvnako5.fsf@gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
To: numbchild@gmail.com, Org Mode <emacs-orgmode@gnu.org>

Hi stardiviner,

Sorry for the noise, I have some additional comments below:

When I run "make compile", I get the following message:

In org-babel-python-initiate-session-by-key:
ob-python.el:211:12:Warning: py-shell called with 9 arguments, but accepts
    only 0-1

I think this is because the "(declare-function py-shell)" no longer
matches the signature of the upstream py-shell function you're using.

Also, I now see that the commit does have a changelog entry, but not a
commit message. Unless it is standard to take the subject line as the
commit message? I am still a little new to merging patches from email,
and might not have all the proper tooling setup for it.

When you update the patch, please mention that this is specifically for
python-mode.el in the commit message and changelog entry.