Bug: eldoc error: (void-function nil) [9.3.7 (release_9.3.7-708-g5417e3 @ /home/n/.emacs.d/straight/build/org/)]

[No Wayman <iarchivedmywholelife@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 631 bytes --]


The patch to org-eldoc applied in b2b587387 still throws an error:

eldoc error: (void-function nil)

I was unable to step through this because (I think) eldoc causes 
the debugger to close as soon as input is received. The error 
occurs when `eldoc--invoke-strategy` attempts to funcall 
eldoc-documentation-default.

The attached patch works for me, but I do not know if it is the 
correct solution.

Emacs  : GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, X 
toolkit, cairo version 1.17.3, Xaw3d scroll bars)
 of 2020-08-12
Package: Org mode version 9.3.7 (release_9.3.7-708-g5417e3 @ 
/home/n/.emacs.d/straight/build/org/)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: org-eldoc-documentation-function --]
[-- Type: text/x-patch, Size: 1330 bytes --]

From 45dfdedbce47aa72c9f7f9f146b422236e9b9e23 Mon Sep 17 00:00:00 2001
From: Nicholas Vollmer <iarchivedmywholelife@gmail.com>
Date: Thu, 13 Aug 2020 14:20:05 -0400
Subject: [PATCH] org-eldoc: (org-eldoc-documentation-function): set
 `eldoc-documentation-functions'

* contrib/lisp/org-eldoc.el (org-eldoc-documentation-function):

b2b587387 did not set eldoc-documentation-functions, resulting in
`eldoc--invoke-strategy' throwing a void-fucntion error.
---
 contrib/lisp/org-eldoc.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/contrib/lisp/org-eldoc.el b/contrib/lisp/org-eldoc.el
index aa1dcb41b..ce0b7ddc2 100644
--- a/contrib/lisp/org-eldoc.el
+++ b/contrib/lisp/org-eldoc.el
@@ -138,7 +138,8 @@
              (string= lang "emacs-lisp")
              (string= lang "elisp")) (if (fboundp 'elisp-eldoc-documentation-function)
                                          (elisp-eldoc-documentation-function)
-                                       (let (eldoc-documentation-function)
+                                       (let ((eldoc-documentation-functions
+					      '(elisp-eldoc-var-docstring elisp-eldoc-funcall)))
                                          (eldoc-print-current-symbol-info))))
            ((or
              (string= lang "c") ;; http://github.com/nflath/c-eldoc
-- 
2.28.0