emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Eric S Fraga <e.fraga@ucl.ac.uk>
To: Kyle Meyer <kyle@kyleam.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: new feature for consideration: other-tab for org-agenda-window-setup
Date: Thu, 27 Aug 2020 10:50:53 +0100	[thread overview]
Message-ID: <871rjsquwy.fsf@ucl.ac.uk> (raw)
In-Reply-To: <87k0xlm48z.fsf@kyleam.com> (Kyle Meyer's message of "Wed, 26 Aug 2020 18:28:12 -0400")

On Wednesday, 26 Aug 2020 at 18:28, Kyle Meyer wrote:
> Thanks.  Sounds fine to me.

Hi Kyle,

thanks for the feedback.  Some questions/comments:

> Style conventions: s/added/Add/s/handle/Handle/

Okay although grammatically wrong but we won't go into that... ;-)

> I think it's worth noting here which Emacs version gained tab support.

Just as part of the comment?

> As you suggest in your follow-up message, you need to guard these calls
> for the sake of older versions.  Perhaps something like
>
>     (if (fboundp 'FN)
>         (FN ...)
>       (user-error "Your Emacs version doesn't support tabs"))

Okay; is there any way to guard the customization of the variable so that the option does not get provided when it's an older version of Emacs?

I'll update the patch and post later.

Thanks again,
eric

-- 
: Eric S Fraga via Emacs 28.0.50, Org release_9.3.7-719-gcdfc40.dirty


  reply	other threads:[~2020-08-27  9:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-26 16:21 new feature for consideration: other-tab for org-agenda-window-setup Eric S Fraga
2020-08-26 16:28 ` Eric S Fraga
2020-08-26 22:28 ` Kyle Meyer
2020-08-27  9:50   ` Eric S Fraga [this message]
2020-08-27 10:51     ` Kyle Meyer
2020-08-27 19:31       ` Eric S Fraga
2020-08-28  4:27         ` Kyle Meyer
2020-08-29 12:07           ` Kyle Meyer
2020-08-31 13:09             ` Eric S Fraga
2020-09-03 10:16             ` Bastien
2020-09-03 12:29 ` Bastien
2020-09-03 21:26   ` Eric S Fraga
2020-09-04  7:06     ` Bastien
2020-09-04  7:50       ` Eric S Fraga
2020-09-03 21:28   ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rjsquwy.fsf@ucl.ac.uk \
    --to=e.fraga@ucl.ac.uk \
    --cc=emacs-orgmode@gnu.org \
    --cc=kyle@kyleam.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).