From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id AG7gJIiQjWDmwAAAgWs5BA (envelope-from ) for ; Sat, 01 May 2021 19:31:52 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id YIeJIIiQjWCqKwAA1q6Kng (envelope-from ) for ; Sat, 01 May 2021 17:31:52 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DB6A415C6A for ; Sat, 1 May 2021 19:31:51 +0200 (CEST) Received: from localhost ([::1]:54584 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lctT4-00084F-SC for larch@yhetil.org; Sat, 01 May 2021 13:31:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46546) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lctSZ-00081L-Ea for emacs-orgmode@gnu.org; Sat, 01 May 2021 13:31:20 -0400 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]:42811) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lctSS-0001Qe-Q1 for emacs-orgmode@gnu.org; Sat, 01 May 2021 13:31:18 -0400 Received: by mail-pl1-x630.google.com with SMTP id v13so612404ple.9 for ; Sat, 01 May 2021 10:31:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:message-id :date:mime-version; bh=Oj4EX1S9J/vq/4MsT2R5sSunD/tnq7xZEB1SzVNMJ7U=; b=O7hIYrFCUfnYtYgOFSi4kEgVvMTSWyWuYM5w/jjHDDc+DYJ2qOPWic0Y/sqLIRP4T4 HyR6iO9/4JEs+cSrbE80qYgPh/xftgNI5d7JE3tBSSmALCYhv2dzA7MaarUPhzGM9Mww knzjcpO9WynLcljnCic0Si5jhIy2Oklt/d+fRm0rX+vaKE2m8qtxEoykJvnDoN3AF0D5 oWqQ7141g3jQLLVezZm6xtJk7OnA2fqWki+C39nLv+cJZ5ttLUpRUHt//SQ2JSq7sfb9 iBrlwaj0dNZkJCuLTUX8a2Hh/yGgDILtiyz7PKKnO6H+H3Ca3zxe7I6KJOY9gctNEXO4 6tJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:message-id:date:mime-version; bh=Oj4EX1S9J/vq/4MsT2R5sSunD/tnq7xZEB1SzVNMJ7U=; b=Sxux2ywturUZl1brbdDUyjHBhwoFEd+gbV1zsEc8yq03FmNivCKwdw2OwGLkEyDUYz 0DQd/QF24zNIP4+vTW80/EPMmFaQ3r1+K3njrb1+97DRNPjfstACbF6BGZjrrXtquyOr YmyOvJ07T/RZksvd7ifezrLvG8+sHlwx+MezOh8VWxOEg4VmTgBoAZE6BCKoihV/g8L9 8wfWWx1iLaHhGlGZkZx4qheVaolHGkKm/Yz4+sXZLZUffnWKdr70nvI+9UiGoapwHu2w rsXIZR6kxxS5x8xmb+2vUNjiNTbQxpOxjyoTnhJd+H9YwTFTu6GAJPQj9LYljMNrkbY6 Mz3Q== X-Gm-Message-State: AOAM5332G8FxBtebxy0+d6lz1XJ2b4dmvyiMAEmDKluZxeabOpPpQEjV bUdP6Gu+oQW9qRfQOlDS324= X-Google-Smtp-Source: ABdhPJw3VARb9fBQl4qfnhHD1Z4gnv5wEN5INvHgxIUQbapFUHixD+IlSCQKbciFCITmV9thGk3ctA== X-Received: by 2002:a17:90b:4b90:: with SMTP id lr16mr18615096pjb.203.1619890271078; Sat, 01 May 2021 10:31:11 -0700 (PDT) Received: from localhost (180-150-91-8.b4965b.per.nbn.aussiebb.net. [180.150.91.8]) by smtp.gmail.com with ESMTPSA id hi8sm4998538pjb.34.2021.05.01.10.31.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 May 2021 10:31:10 -0700 (PDT) References: <87o8et6g79.fsf@tsdye.online> <87fsz6k8yw.fsf@gmail.com> <878s4y1icm.fsf@tsdye.online> User-agent: mu4e 1.4.15; emacs 28.0.50 From: Timothy To: "Thomas S. Dye" Subject: Re: [PATCH] LaTeX export: arbitrary float environments In-reply-to: <878s4y1icm.fsf@tsdye.online> Message-ID: <871raqbbtw.fsf@gmail.com> Date: Sun, 02 May 2021 01:31:07 +0800 MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::630; envelope-from=tecosaur@gmail.com; helo=mail-pl1-x630.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619890312; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Oj4EX1S9J/vq/4MsT2R5sSunD/tnq7xZEB1SzVNMJ7U=; b=jX2uFY/Bhw8P3lNN7ph9d4soMpkvnoyHb3iXaVB0BPc+is+6LI2rrdQrb/z2bfIPdNRFWC ygA/keGszBUbiHU9poFmd7w/QB22dIgnPrkEZu+pJnBwcdGAEMms2udOWYzHAwpo93U9ZF GPgnWCyR+MUJaCdkqpMM5vUUm1D5KoPi+p0u/+ctn2y6Hodak0LRt3rZ365lw3VwImjdFq L4O4EFPpwOvVGOSEKA+zfPgaPynPsFbprZlBqOojju/CHQLjiNYi+GOoLQX1axkxNYQJzA E9W0+6UJjISAofywA271EYytzvo2dbs74nBF2q/zrFx9+hY9tSME+dxdU/1l7g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619890312; a=rsa-sha256; cv=none; b=W5zCHH2QCGLp6TNZexP+aTqp7yjTUcQRFerTG02diNS9+irwRrhg/Cm84hvtCA60TwVwjf HOHtiqPm9eOerY29k2tDSXq2eWM0gAcJ9GX9vFd11zs2xD507NQzN4S2/c1nFlx0hWPJQR THuPCj0vtY554e0sq5QSq1NlqONNE5W7BJvYTA9fM1HCZinWMrsbqZDnp8JycuyWECK3VB cvA45KMa/HeCT/m/XAAiOTGRCBOZmzdiFMlb9YB2ZdkIjeZyfMpBwWbrYv4dWytmakNLgQ OVa+R2PjagZs8yDN/WCj3BhlkmALf5LO1tn5e8FGxHKUyRf75YyOuA0+R8bdxA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=O7hIYrFC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.16 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=O7hIYrFC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: DB6A415C6A X-Spam-Score: -3.16 X-Migadu-Scanner: scn0.migadu.com X-TUID: 4EdBJj3RzIEu Thomas S. Dye writes: > Aloha Timothy, :waves: > Sorry for the clumsy patch, which I guess would also benefit from an addition to > the manual, as well? No problem, we all start somewhere :) (and I know I'm still making mistakes) An update to the manual to describe the changed behaviour would be good. If you'd like you could wait till a core maintainer says this looks good before going to that effort, or you could add it in now so it's all in a single patch --- as long as something happens. > Larger question: do we really want to tinker with ob-latex in this way? Or, > should changes like this patch follow a path indicated by Tim Cross and into > their own package, say ob-latex-ex, which might someday replace ob-latex if it > proved useful and stable? I don't think LaTeX support is likely to leave Org any time soon, so at least until a core maintainer tells you otherwise I'd be inclined to proceed with your current patch. If this was a huge/transformational change I may be more uncertain, but this looks fairly simple to me at least. -- Timothy > All the best, > Tom > > Timothy writes: > >> Hi Thomas, >> >> On the surface, this looks reasonable to me :) >> >> Just commenting on some technicalities with the patch itself: >> - In ORG-NEWS it would be good to wrap the content over multiple lines >> instead of having a single 270 char line :) >> - You seem to have an anomalous change to the ob-python :return entry >> - I don't think your patch subject follows the convention for Org, it >> should be: >> "main file/feature: overall change summary" >> so, something like >> "ox-latex: allow for arbitrary float environments" >> rather than >> "LaTeX export: arbitrary float environments" >> >> Thanks for the patch :) >> >> Timothy