Re: Incorrect link is stored (org-elements?)

[Ihor Radchenko <yantar92@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

Max Nikulin <manikulin@gmail.com> writes:

> `org-store-link' under some conditions may pick a link to wrong heading. 
> Emacs-26.3, Org main~1.

I can reproduce, though not exactly following your steps.
Can you try the attached patch?

Best,
Ihor


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-element-at-point-Fix-breakage-when-called-at-the.patch --]
[-- Type: text/x-diff, Size: 1650 bytes --]

From 6465741dff757af23b10d1f0a412eb41d05f4c75 Mon Sep 17 00:00:00 2001
Message-Id: <6465741dff757af23b10d1f0a412eb41d05f4c75.1636458311.git.yantar92@gmail.com>
From: Ihor Radchenko <yantar92@gmail.com>
Date: Tue, 9 Nov 2021 19:42:14 +0800
Subject: [PATCH] org-element-at-point: Fix breakage when called at the end of
 section

* lisp/org-element.el (org-element-at-point): Do no unconditionally
return first matching cached element when point is within blank lines
after section element and CACHED-ONLY is non-nil.

Fixes https://list.orgmode.org/smbl59$qjm$1@ciao.gmane.io/T/#u
---
 lisp/org-element.el | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/lisp/org-element.el b/lisp/org-element.el
index 9ea13db9c..ad5c2bbd0 100644
--- a/lisp/org-element.el
+++ b/lisp/org-element.el
@@ -7510,9 +7510,6 @@ (defun org-element-at-point (&optional pom cached-only)
                                (and (org-element-property :contents-begin element)
                                     (>= pom (org-element-property :begin element))
                                     (< pom (org-element-property :contents-begin element)))
-                               (and (org-element-property :contents-end element)
-                                    (< pom (org-element-property :end element))
-                                    (>= pom (org-element-property :contents-end element)))
                                (and (not (org-element-property :contents-end element))
                                     (>= pom (org-element-property :begin element))
                                     (< pom (org-element-property :end element)))))))
-- 
2.32.0