From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id uOE0ItbKsWI9DgAAbAwnHQ (envelope-from ) for ; Tue, 21 Jun 2022 15:42:46 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id mAQ3ItbKsWI2hgAA9RJhRA (envelope-from ) for ; Tue, 21 Jun 2022 15:42:46 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 35C7B2A40F for ; Tue, 21 Jun 2022 15:42:46 +0200 (CEST) Received: from localhost ([::1]:57846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o3e9U-0005b3-Tm for larch@yhetil.org; Tue, 21 Jun 2022 09:42:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36254) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3e7z-0004OD-RE for emacs-orgmode@gnu.org; Tue, 21 Jun 2022 09:41:12 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:38643) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o3e7y-000423-BY for emacs-orgmode@gnu.org; Tue, 21 Jun 2022 09:41:11 -0400 Received: by mail-wr1-x435.google.com with SMTP id v14so19019469wra.5 for ; Tue, 21 Jun 2022 06:41:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:mime-version; bh=KeluffN1dobI3/eNC4JQz+3Pyj5Tknm32M1u7Hi6ceE=; b=bdalcIKM4pEclFCqOyOrWuf4dwFXqeBJnVXMOtl2tFh0Wr1aNLYQ4408g47lDom+70 0KgphjLvsO7F13a9vf0k2cwM5owQN7znQuU6hWD5hLh3jyF+ql5DZ8DFlqc8/u38EfSZ TAY9wDToIKyqI4eHQY/GUQASL6cW4HCPcQ0rTpIAlnQxN1SzatMLePyYi5XivemAQu5A 84IoeNPaVisCQp6j5SuveiZN5sWBcKaiTklGDWgULJQyjpcND5CsV/OYaC9OWHL4LlsF SFnPAp10RZ1tHRIIiMjf0sWtBPbz19sTJvwTh7/UVD+Ibym3ngOzPltIiXVCgfZ/ynnH XStw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:mime-version; bh=KeluffN1dobI3/eNC4JQz+3Pyj5Tknm32M1u7Hi6ceE=; b=4vGm5EOnMSrL6R7ABNvUQMQdkgl3SYX9Uolz9nIUaWJ4t9H82NDoAe02sbq6APJNz5 SqvJeZJEJFhcQ6tI9yUbrU4P3ykIe4gyfnvvGXiE+fM0seMzK0SKY1EYTo/niJ4tZSYp ZEggXSpnucD/K5KxTR7XiVEnsqIFfSDnPnhU5bu36SeJNiHQlE8drNDlCKLC669wWZcH 69udaq6CfQu+dlJcMD8NjaveVWMnynHt72WcLUY/f14ZS2WJlSBlXHG6rdnHWEKFEuIM jeTDscDXff7Sak+eSSv+cijBsTlPeKxEPiN7akm2MVxIHK84qOAb1ESlK3CjQ8wVypwV dk1w== X-Gm-Message-State: AJIora+eR3A1cDRbjz+BHqUFi9f72+HBQxCom8kK/heQk2P983tc7fOp h1wIxe5TGzv0YxvpoPpDCF2MCvJyvH8= X-Google-Smtp-Source: AGRyM1tJCd2AqLQtmu0XBU/AzHS5HlFBTcd5pp4dG2sV0qQ+aoTcN2EOqycq3XLpIoeD/bsEQdMcNw== X-Received: by 2002:a05:6000:1f04:b0:218:4e7c:cb97 with SMTP id bv4-20020a0560001f0400b002184e7ccb97mr28446417wrb.644.1655818868232; Tue, 21 Jun 2022 06:41:08 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb50:971f:1b62:ce80:8d6b]) by smtp.gmail.com with ESMTPSA id f8-20020a05600c4e8800b003974b95d897sm25457246wmq.37.2022.06.21.06.41.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 06:41:07 -0700 (PDT) From: Robert Pluim To: Hugo Heagren Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH v3] ol.el: add description format parameter to org-link-parameters References: <87zgl1npow.fsf@localhost> <20220405192931.6747-1-hugo@heagren.com> <87a6cx79xn.fsf@localhost> <87zgi6fckr.fsf@heagren.com> Gmane-Reply-To-List: yes Date: Tue, 21 Jun 2022 15:41:07 +0200 In-Reply-To: <87zgi6fckr.fsf@heagren.com> (Hugo Heagren's message of "Tue, 21 Jun 2022 13:03:32 +0100") Message-ID: <871qvixhfw.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=rpluim@gmail.com; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655818966; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=KeluffN1dobI3/eNC4JQz+3Pyj5Tknm32M1u7Hi6ceE=; b=gnXfgsQfUpizYLieS2l/CILJVHNJcyr/pw6VfgK76dXWcqgGiUSIRypOpyvl+QogAQwF49 MObzgTZQhqPDeRYTmBI++dB8k5JQ81AmRaknV1rXxgUge2yFEIWa6N8GuWqKOUKs6FrPcU 4HJCWTEgW5CUopiv2hn9lOjFltav1ptZbkrY+M0e5PaJQfCV8QG68BLo/WrjH4puY4Xeiq j8ItvK1FEuss7RhwDIzpvU5jB0Itn7myBEmKUfk4Ms3B0k5s7i9QfkUP89CpwcpWK0ArL+ 1VvQDAzcshr8f1zIIcJWdMpMHCbGznNsHytu0fM3nsE5UvkhG+zwJ0KX89J96Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655818966; a=rsa-sha256; cv=none; b=WmOldXF6v+F7fjj4R8Aef0BViJKChRUdqIIQHJ0HzMDUgvR9LoQdlmzT6o5QusSyzps3an Epxkxc1Hpr7gh3OwIRyIwfDjblHG5VB9Tu2YNAfWVFQD7dEUyIlvA8dP6rDtrUZmmAa2qJ hywFiZCQzjf/1hudHq7YTM3GV9XJaXxdCeKm9+l1riedR5JYHsbyFNCyNbHRGRD+0Tqcn5 JnwXZy2v999yTNDdIbRIhsH05EzI8ktag9F12BrcdnOQvugfbuYx15rLiiEuFjK+ndCMEt yGF26I+wprq9+bdtYnj0gvsZ8Kh42CPO2OlVFngVb2onJHBPj4rLFOxM62RUdQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=bdalcIKM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.27 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=bdalcIKM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 35C7B2A40F X-Spam-Score: -6.27 X-Migadu-Scanner: scn0.migadu.com X-TUID: sDPuHCt+Rk3c >>>>> On Tue, 21 Jun 2022 13:03:32 +0100, Hugo Heagren said: Hugo> They're very nearly just right, but for some reason Hugo> `test-ol-with-link-parameters-as' doesn't always reset the parameters Hugo> correctly for me. However I have them set to originally, it sets Hugo> `:default-description' to a lambda. This might be a quirk at my end Hugo> though -- if someone else could have a look I'd be very grateful. They way your macro is defined, it uses `orig-parameters' in a way that it will leak into the global namespace. Better would be to do (let ((orig-parameters org-link-parameters)) ... (setq org-link-parameters orig-parameters) Robert --