From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id qNyyE267XGNemQAAbAwnHQ (envelope-from ) for ; Sat, 29 Oct 2022 07:34:38 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id SB2WE267XGNYJQAAauVa8A (envelope-from ) for ; Sat, 29 Oct 2022 07:34:38 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E90F89533 for ; Sat, 29 Oct 2022 07:34:37 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooeSF-0001SQ-5f; Sat, 29 Oct 2022 01:32:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooePR-0007pE-HF for emacs-orgmode@gnu.org; Sat, 29 Oct 2022 01:29:29 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooePP-0008M3-0y for emacs-orgmode@gnu.org; Sat, 29 Oct 2022 01:29:29 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 5BE74240026 for ; Sat, 29 Oct 2022 07:29:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1667021364; bh=BjYet/8peIUIrzmtIglTXFRk3MtabgF4ELSSIcUwfZw=; h=From:To:Cc:Subject:Date:From; b=I1IzbG897FtSjR6UhmWodNl/AzEYH0b58LGJF1sTzT1lPvMKrw92TcYqKfDheJzEC 7yFK/G5pv6UTCYs/WA3tJKYVGkp/far/1Jq/d/jSHnr0mAoEcNwYbE5pV1k+yeMOz/ OnBmtuWaqB8uLR/s3lArlap2qOAyIZ+nSIhGv+LsWpe1m/4y3KRgEdW4LLeOtOG6i0 +Kz2xZoKdji4KvKKkY23h5FgwEpXz8sXXPOvploVvOU0Nm28kSb/gL6C6FhoekHSek 3fgErY0AqcbO4M2a466teXsngRPG+VT9prwwqDov7TBHCRctQnAFrG25Vv5Tuggwo7 TeWYjw9ncAgFg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Mznz44Qk8z9rxD; Sat, 29 Oct 2022 07:29:20 +0200 (CEST) From: Ihor Radchenko To: Alex Giorev Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] Fix org-set-tags-command active region bug In-Reply-To: References: Date: Sat, 29 Oct 2022 05:30:04 +0000 Message-ID: <871qqrjixv.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Emacs-orgmode" Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1667021678; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=14kV6Y3gYGW7zA3g4sOg8t9LTZ8Bap/938pv9FbaZAc=; b=E+p8vCf7CvQk5eT36tzazI3qM9P1SeNtJM764R7LCCD+mZ046+O2ES8X6Vtzpi6Smt9l4w X5OxfCFELpLii70je5T4V4jRCYKT3pmoObODs2EWZgpUX66KHKoPomztlyyPwx5Iu10qg5 yNrZ2h7zw+ISXMhtnZqXTRYlsziF5T9z9E9Qnhhvtio9mirqp1dzBtwk5cGCZxUprR1qJd k543wM14yo3g5jvvE+u7wHp1klz7+nbKzlkvKDIK2WXGhiyTIQpMmfahshMGNfkC1yceJD kmxyEwyw7hZD524VoyVKiBl6dPEP4dygCuhOgVl/S7+iuDNatzkAUwWc7+XWjQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1667021678; a=rsa-sha256; cv=none; b=FCKBaQNc69CXJFYb81IhV/tTyXL69TaCkbXp9jjYxRZ3J/+pF8Hrkc7dCBV2XkF+NRJcgw hbZdbtAbeZzHXWRBbl9jAMYtWSnVCBbsAb7nxQEC5Sd8LxsIxMOX4BavYR8MgufDhY+uAx VWgyg8wu5AfHNkKzqgBkuRr1RCZ4eA0DTNFV8gnCawXWh66ztiz8CYW4HNq6PDhBrVvwab v89jyL2hK7t2iwl/gZpQJ9vDHUsHhumiaIo+PVuunq81wD3b1D6M8qTmkRDG9D2H7IY9Rl AmFixiEVV2oawiEUu+/XpVYzo8ttzxFwfXdWP0M1Ml/j3USjxNx+iVk71UVOxg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=I1IzbG89; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.63 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=I1IzbG89; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E90F89533 X-Spam-Score: -3.63 X-Migadu-Scanner: scn1.migadu.com X-TUID: d5MyXM42+jPS Alex Giorev writes: > When `org-loop-over-headlines-in-active-region' is 'start-level, the > command should loop only over the headings having the same level as the > first one, but it loops over all headings in the region. This patch fixes > the issue. Thanks for reporting and providing the patch! I have applied an equivalent patch that uses the code style more similar to other places in Org where `org-loop-over-headlines-in-active-region' is handled. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=78806952218e87f4a413a29c908161f97572f97d -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at