From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id CLLAB1E6X2OazwAAbAwnHQ (envelope-from ) for ; Mon, 31 Oct 2022 04:00:33 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id CCPDB1E6X2PQHwEA9RJhRA (envelope-from ) for ; Mon, 31 Oct 2022 04:00:33 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B3DFA26DC9 for ; Mon, 31 Oct 2022 04:00:32 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1opL1c-00026O-FL; Sun, 30 Oct 2022 22:59:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opL1b-000250-DM for emacs-orgmode@gnu.org; Sun, 30 Oct 2022 22:59:43 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opL1Z-0006mX-GE for emacs-orgmode@gnu.org; Sun, 30 Oct 2022 22:59:43 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id A401B240101 for ; Mon, 31 Oct 2022 03:59:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1667185179; bh=ahvY0Ra1RdorjwGXds9VK+WB9OM/kwyTHJ23f2PeWO4=; h=From:To:Cc:Subject:Date:From; b=BDGi9ObHOJvHvATIZ43ryIK3c+182zzMolA4StY88C9yDu+rcrk7Mo1Cllnz6tEn3 MAhX6BjxHQUoPpRqmHByixmQwN+MDRnRpdU+n9oCupS0JsypU+Zx/8lXJ1l+PGkTqs 2tDYSMkweld01COztbN8CYMc+fwR4FyMFRVPMe7kZTAJp1tkNwkxkpKwmOSDBftIVV hurqbwVPSHYNlh11PPr4O+Mxpd3wOm/jghaRejghrWr8i38OXnVQw0rqQephhxPEcE NBE6KN5eN4YWheFmMwjmsWDhpcMlLqlyo1F+NFYgvBu9e0hgNUgOrA+wNnDQE3ANlm kIIAu4SeoxwKg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N0yYQ3Jmfz6tnc; Mon, 31 Oct 2022 03:59:38 +0100 (CET) From: Ihor Radchenko To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec Cc: Bastien , emacs-orgmode@gnu.org Subject: Re: Setting org-todo-keywords through directory-local variables In-Reply-To: <875yg1craw.fsf@gmail.com> References: <87mu62gvjk.fsf@gmail.com> <87eercsx1b.fsf@gmail.com> <87lflkdmxx.fsf@nicolasgoaziou.fr> <87eeraaju7.fsf@gmail.com> <87a70stkmv.fsf@gmail.com> <87v9gsdyhk.fsf@gnu.org> <87leoyatwu.fsf@localhost> <875yg1craw.fsf@gmail.com> Date: Mon, 31 Oct 2022 03:00:17 +0000 Message-ID: <871qqon1dq.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Emacs-orgmode" Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1667185232; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=ahvY0Ra1RdorjwGXds9VK+WB9OM/kwyTHJ23f2PeWO4=; b=KOhrCgWt6GKuDHos3sGfNO3zfJoLmgsmPj9SbI39zZBD+FT/YCnIiSYRJEDhNAVuB72Kwa uJqehn5cJgKktLLeWMFeHYQ7qFHI6nvfWLbpjM+pn91fb4BKxbbPzaLT36otp8FR9opJFq ualokJES0h0UHpCwwvGksc0P7jQYxU0/uUw/wOwsqt9yd2C7iBdVB4SvXY7SXE0l7QnSof xL+xy66Y4H8zxSMLpivsBi2kaDGr6n89KBEqx+ws1AKUXyi76sOkzAHZDtN5e9uJq+uEuN YaXlUj0FCX607+gvwYQtg4x026+AbO5qOinjZNMw4aP+mdydYrEtqH5xiXwGow== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1667185232; a=rsa-sha256; cv=none; b=fL9xm7DE+whcW3qBEUXpuYUGwr+kxi/IhOoi8eZe7VxSl9Bv9JnsCwZqbvLjiiYaUuU54g Gch0VyvfDgHVv5CpejW2SjhKcLJY1KKnqPfhoOfmb5GIwh+s8/F719bTyfhKoniyXdCQ6G 9f589oRvD76TbyCJQ2HADVxLZGvZw9GUHSN/caeD9iyZollKv1vCfP6Sb8fJQzITcKWIVg EYA8ZKXHwL8Wi7mx1T5IPtE3wG4PCLNKai3qPYPFMGu7RkJ1jIFKboE7r+KdVUoUvGbpDf p6Hg/0L3CpHt0DUM9ETwxsXvnjaNZFAQHffmImRPOEDuOTpPa9ZSFXR52eiNPA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=BDGi9ObH; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.46 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=BDGi9ObH; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: B3DFA26DC9 X-Spam-Score: -3.46 X-Migadu-Scanner: scn1.migadu.com X-TUID: sqNrOQkD1OQ6 K=C3=A9vin Le Gouguec writes: >> Maybe the hook approach can work better. But I'd prefer to discuss all >> the possible caveats first. > > My reasoning for keeping the current initialization code untouched and > _re_computing stuff in hack-local-variables-hook hinged on=E2=80=A6 I would avoid re-computing staff. Some variables define Org parser setup and re-computing is expensive when we need to reset the parser state. In particular, it will make parser cache persistence useless. > This patch might have been my first foray into Org's init code, so it > felt too risky to go with any approach other than "keep the > implementation for the established features _exactly_ _as_ _now_; stuff > all the experimental stuff in hack-local-variables-hook". I'd say that it is too early to consider local variable hooks. Especially given that Emacs devs just suggested a better approach and discouraged using hack-local-variables-hook. See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D57003#108 What we can do wrt this patch is extract the part that marks some variables as :safe. It will be a useful addition in any case. For handling local variables, let's wait for the discussion with Emacs devs to resolve. --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at