From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id sN58OgFDdGZuOwAA62LTzQ:P1 (envelope-from ) for ; Thu, 20 Jun 2024 14:56:02 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id sN58OgFDdGZuOwAA62LTzQ (envelope-from ) for ; Thu, 20 Jun 2024 16:56:02 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=UNBZnjVZ; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1718895361; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=l1jVwc0Uex5sMPcd+mMzRuniIo0+CImc100pPLambKY=; b=WsvYRM/Mi0xbbaFcyr4iIhZ1UOooKTdKFdbyHZ1q5lvKki8Ul1mYcKhACrIuhp9YUjui7r vGRTDGXHDw6NOvl4fLKZee5x4vC36nTgDULSOGgxb13GyjH1btSn/jIkd/ti8Sfp0Zy9gC kwDSySJBeSm7hR2wy2+zXVGdQMMV4UhL/ppDSTuu/6dbwrrbXBt9LH4xGNrEoXPaAZHmBG v22lZtEP/HmnFtsGGYQpdy8g652HvPmBpSYogdiI8XsG/VeYqfboGbf9/85s0wrF8I9XpK NgktVwtaLrQybRmPBHP+oWRTybXsU2s9gyBZxaJ54sHCGETun17KPZDbyejzfg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1718895361; a=rsa-sha256; cv=none; b=Ar6lFHwOuyNtafeXk66J+U0ywaYvU/DnzKp5TgZmoaCwNxtU9gHfJg3D2UM1KSlcYOw64q NqnQmNaUfxcs/aV+dJAP8waQY5Z2LOsYdEMI/rWEMmRCZHXwB0w/0rAwghJqHsgAzWxWfm D5piwQPdeK6L3FBY7mUC1ym5kKZhFV+yzDDmV2KKEzgVudZ2MPuq3myB/sybXYjt9GTUUb oP942E0FM0keN77Uf2IXNq+m16yOv4Oj1Hk5JCKtVPK49zRhP4S8Lz9byjDDBZrcGMy6SG RrIpNsSqBwdsmsHiFVrcpmgvH6C//dITcBTgc9fbB5JXCvEygbNlq2ZkSHvJMQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=UNBZnjVZ; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7D0F93B44C for ; Thu, 20 Jun 2024 16:56:01 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sKJBl-0006uv-Bc; Thu, 20 Jun 2024 10:55:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKJBi-0006uR-Sd for emacs-orgmode@gnu.org; Thu, 20 Jun 2024 10:54:59 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKJBg-0002vD-5V for emacs-orgmode@gnu.org; Thu, 20 Jun 2024 10:54:58 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 44DC9240029 for ; Thu, 20 Jun 2024 16:54:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1718895293; bh=WPPhtakMXGt5qL9lsCPXmDU7bSXhilXxMFU5Tt36mU4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=UNBZnjVZPl70ovRTOxopSxhh3Z3BrqyG4Dfw3QWAqItA1e0qh0ybG4w/M7Rwc28eF Qc2X79Qt3r6C5S/QA4i2iXBB8rkAmnPzvQTbSnQp99HceQKqq8ETGRz5JhnAY3waTs OiKvBRG+CqoWMGRUW6X7PjCI6vKaQS5INM66Y7wIomIVp43KWaVrE6CVtburX9XlOy /Ozpa50gbestRI+/gr/a2hDqEOtvROzdCddHTELvOF7+ocQdEGM0ycVoANFbYIJqg9 f33s/TwGwG8VnV5YZ+DgAkIQ3bDt+n/1xRyycRaSNlXAL+UiLUTS7jnEqGt/pHRNwi ic3zB0AzChP3w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4W4k6h6QBBz9rxF; Thu, 20 Jun 2024 16:54:52 +0200 (CEST) From: Ihor Radchenko To: Al Haji-Ali Cc: emacs-orgmode@gnu.org Subject: Re: [BUG] org-refile-get-location a symlinked file [9.7-pre (release_9.6.29-1443-gb4d17c)] In-Reply-To: References: <87sexba3aa.fsf@localhost> <87le32s93z.fsf@localhost> <87v8259fh7.fsf@localhost> Date: Thu, 20 Jun 2024 14:56:37 +0000 Message-ID: <871q4r8xy2.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.58 X-Spam-Score: -6.58 X-Migadu-Queue-Id: 7D0F93B44C X-Migadu-Scanner: mx11.migadu.com X-TUID: t7YjrGtUnqMT Al Haji-Ali writes: >> I am thus attaching an alternative patch. >> May you please test if it fixes the problem on your side? > I think it's missing calling `file-truename` call on `filename`, see attached patch. Makes sense. Applied, onto bugfix. Fixed. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?h=bugfix&id=a4ff518 >> Thanks. Although this is a different kind of patch. And it is doing too >> much - we do not want to expand all the names via `file-truename' >> because you may have a situation like >> >> /path/to/file1.org >> /path/to/symlinks/name-is-completely-different.org >> >> Then, using `file-truename' may be confusing for people who expect the >> symlink name to be displayed. > > I am not sure what would be the correct approach. Perhaps the > true-name expansion should be conditioned on the value of > `find-file-visit-truename`. Maybe. I am slightly cautious about adding it without public discussion though - (1) I can see how people may not expect `find-file-visit-truename` to affect `org-refile'; (2) I am not 100% familiar with this area of Org codebase, and I am not 100% confident that changing refile targets table won't break anything. If you want to add support of `find-file-visit-truename`, please send another email marked [FR] (feature request) in subject line, explaining what you want to add. Then, we can see if more people are interested. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at