emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Sebastien Vauban" <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
To: emacs-orgmode-mXXj517/zsQ@public.gmane.org
Subject: [PATCH] Improve message when file to include is missing
Date: Fri, 24 Jan 2014 11:49:26 +0100	[thread overview]
Message-ID: <86wqhpu021.fsf@somewhere.org> (raw)

Hello,

When a SETUPFILE is missing, there is an error or message generated, but
we don't know in which file the bad reference is -- when all those files
are loaded during the agenda generation.

Hence, a better message, specifying where to go and look for the bad
link.

Best regards,
  Seb

From 4c31c1cf649c2eb3487e61e56296f058a62d7c08 Mon Sep 17 00:00:00 2001
From: "Sebastien Vauban" <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
Date: Fri, 24 Jan 2014 11:43:52 +0100
Subject: [PATCH] Improve message when file to include is missing

* org.el (org-file-contents): Improve message when linked file does not exist.

---
 lisp/org.el |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index a225bae..787a09f 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -5235,8 +5235,10 @@ Support for group tags is controlled by the option
   (if (or (not file)
 	  (not (file-readable-p file)))
       (if noerror
-	  (message "Cannot read file \"%s\"" file)
-	(error "Cannot read file \"%s\"" file))
+	  (message "Cannot read file \"%s\" referenced in file \"%s\""
+		   file (buffer-file-name))
+	(error "Cannot read file \"%s\" referenced in file \"%s\""
+	       file (buffer-file-name)))
     (with-temp-buffer
       (insert-file-contents file)
       (buffer-string))))
-- 
1.7.9

-- 
Sebastien Vauban

             reply	other threads:[~2014-01-24 10:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-24 10:49 Sebastien Vauban [this message]
2014-01-24 11:14 ` [PATCH] Improve message when file to include is missing Nicolas Goaziou
2014-01-24 11:19   ` Bastien
2014-02-18 14:55   ` Sebastien Vauban
2014-02-18 20:21     ` Nicolas Goaziou
2014-02-18 20:32       ` Sebastien Vauban
2014-02-18 22:10         ` Nicolas Goaziou
2014-01-24 11:15 ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86wqhpu021.fsf@somewhere.org \
    --to=sva-news-d0wtavr13harg/idocfnwg@public.gmane.org \
    --cc=emacs-orgmode-mXXj517/zsQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).