emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Sebastien Vauban" <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
To: emacs-orgmode-mXXj517/zsQ@public.gmane.org
Subject: Re: Bug in org-table-convert-region?
Date: Tue, 28 May 2013 11:28:20 +0200	[thread overview]
Message-ID: <86txlnqwqz.fsf@somewhere.org> (raw)
In-Reply-To: 87vc63easa.fsf@gmail.com

Thorsten,

Thorsten Jolitz wrote:
> "Sebastien Vauban" <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org> writes:
>>>
>>> ,-----------------------------------------------------------------------
>>> | (org-table-convert-region BEG0 END0 &optional SEPARATOR)
>>> |
>>> | Convert region to a table.[...]
>>> | SEPARATOR specifies the field separator in the lines.  It can have the
>>> | following values:
>>> |
>>> | '(4)     Use the comma as a field separator
>>> | '(16)    Use a TAB as field separator
>>> | integer  When a number, use that many spaces as field separator
>>> | nil      When nil, the command tries to be smart and figure out the
>>> `-----------------------------------------------------------------------
>>> Looks like a bug in the argument handling?
>>
>> I don't have an answer, but one extra question (which popped up when
>> reading your analysis): how does Emacs see the difference between `C-u' and
>> `C-u 4'?
>>
>> That is, how to differentiate "Use the comma as a field separator" from
>> "Use 4 spaces as field separator"?
>
> The answer is here:
>
>>> and from the elisp manual:
>>>
>>> ,-----------------------------------------------------------------------
>>> | Here are the results of calling display-prefix with various raw prefix
>>> | arguments:
>>> |
>>> |      C-u     M-x display-prefix  -| (4)
>>> |      C-u C-u M-x display-prefix  -| (16)
>>> |      C-u 3   M-x display-prefix  -| 3
>>> `-----------------------------------------------------------------------

OK. I now understand that:

- `C-u' gives an list argument of '(4)
- `C-u 4' gives a numeric argument of 4

So, that's the way to distinguish them.

> ,---------------------------------------------------------
> | (org-table-convert-region BEG0 END0 &optional SEPARATOR)
> `---------------------------------------------------------
>
> with C-u M-x org-table-convert-region should be e.g.
>
> ,----------------------------------------
> | (org-table-convert-region 38  456 '(4))
> `----------------------------------------
>
> and C-u 3 M-x org-table-convert-region should be
>
> ,----------------------------------------
> | (org-table-convert-region 38  456 3)
> `----------------------------------------
>
> but I checked with edebug, its actually 
>
> ,----------------------------------------
> | (org-table-convert-region 38  456 nil)
> `----------------------------------------
>
> and "When nil, the command tries to be smart and figure out [itself]"
>
> So the problem seems to be that 'C-u 3' doesn't work as expected in my
> case. Could you check if it works for you?

I've considered the following table:

test a b c
test  a  b  c
test   a   b   c
test    a    b    c
test     a     b     c
test      a      b      c

and tried to convert it with various configs:

- M-x org-table-convert-region
- C-u M-x org-table-convert-region
- C-u 4 M-x org-table-convert-region
- C-u 3 M-x org-table-convert-region

In all cases, when evaluating `separator' under edebug, it showed me `nil',
and always converted the table into this:

| test | a | b | c |
| test | a | b | c |
| test | a | b | c |
| test | a | b | c |
| test | a | b | c |
| test | a | b | c |

So, `separator' seems never to get a correct value, and to be constantly be
equal to `nil'. Dunno why, though.

Do you confirm this as well?

Best regards,
  Seb

-- 
Sebastien Vauban

  reply	other threads:[~2013-05-28  9:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-27 22:59 Bug in org-table-convert-region? Thorsten Jolitz
2013-05-28  7:17 ` Sebastien Vauban
2013-05-28  9:03   ` Thorsten Jolitz
2013-05-28  9:28     ` Sebastien Vauban [this message]
2013-05-28 10:20       ` Thorsten Jolitz
2013-05-28 11:47         ` [PATCH] org-table-convert-region (was Re: Bug in org-table-convert-region?) Thorsten Jolitz
2013-06-01  5:46           ` Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86txlnqwqz.fsf@somewhere.org \
    --to=sva-news-d0wtavr13harg/idocfnwg@public.gmane.org \
    --cc=emacs-orgmode-mXXj517/zsQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).