flycheck orgmode on windows invalid output file name

flycheck orgmode on windows invalid output file name

[Guido Van Hoecke]

Hi,

Environment:
Windows 10 (Insider preview 14352)
GNU Emacs 25.0.92.1 (x86_64-w64-mingw32) of 2016-03-03

I just installed flycheck-20160604.154/

I read that it does not officially support windows 'although it should
mostly work fine on Windows'

And indeed flycheck works fine when editing .el, .js, .php et al. files.

However, my emacs.el file is generated from an emacs-guivho.org
file. When I issue C-' to edit an elisp code block, flycheck barks at
me:

Error while checking syntax automatically: (file-error "Opening output file" "Invalid argument" "c:/Users/guivh/emacs-guivho/.flycheck_emacs-guivho.org[*Org Src emacs-guivho.org[ emacs-lisp ]*]")

I checked the windows only issues but did not see something similar.

Apparently flycheck has a problem with the fact that the buffer does not
correspond to a physical file.

I hope there is a known or suggested workaround...

TIA,


-- 
Guido

If you try to please everyone, somebody is not going to like it.

Re: flycheck orgmode on windows invalid output file name

[Eli Zaretskii]

> From: Guido Van Hoecke <guivho@gmail.com>
> Date: Sun, 05 Jun 2016 12:45:45 +0200
> 
> Error while checking syntax automatically: (file-error "Opening output file" "Invalid argument" "c:/Users/guivh/emacs-guivho/.flycheck_emacs-guivho.org[*Org Src emacs-guivho.org[ emacs-lisp ]*]")
> 
> I checked the windows only issues but did not see something similar.
> 
> Apparently flycheck has a problem with the fact that the buffer does not
> correspond to a physical file.

No, I think the problem is that flycheck assumes it can create a file
whose name includes '*', which is false on Windows.

> I hope there is a known or suggested workaround...

If I'm right, the only solution is to modify flycheck so that it runs
the file name through convert-standard-filename.

Re: flycheck orgmode on windows invalid output file name

[Guido Van Hoecke]

On 5 June 2016 at 17:25, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Guido Van Hoecke <guivho@gmail.com>
>> Date: Sun, 05 Jun 2016 12:45:45 +0200
>>
>> Error while checking syntax automatically: (file-error "Opening output file" "Invalid argument" "c:/Users/guivh/emacs-guivho/.flycheck_emacs-guivho.org[*Org Src emacs-guivho.org[ emacs-lisp ]*]")
>>
>> I checked the windows only issues but did not see something similar.
>>
>> Apparently flycheck has a problem with the fact that the buffer does not
>> correspond to a physical file.
>
> No, I think the problem is that flycheck assumes it can create a file
> whose name includes '*', which is false on Windows.
>
>> I hope there is a known or suggested workaround...
>
> If I'm right, the only solution is to modify flycheck so that it runs
> the file name through convert-standard-filenam

For testing i went to change flycheck-temp-file-system in flycheck.el
so that it reads

(setq tempfile (convert-standard-filename (expand-file-name
(file-name-nondirectory filename)
           directory)))

rather than the original

(setq tempfile (expand-file-name (file-name-nondirectory filename)
           directory))

I than edebugged the flycheck-temp-file-system with the
"c:/Users/guivh/emacs-guivho/.flycheck_emacs-guivho.org[*Org Src
emacs-guivho.org[ emacs-lisp ]*]") filename, and it nicely produced a
tempfile where the '*'s are replaced by '!'s.

Still, when editing elisp blocks from my elisp.org files, I keep
hitting the '*' problem...

Anyway, I do think that your suggestion is to the point, so I am going
to suggest it to the flycheck people. It certainly can't heart to call
this ectra function in non-windows ebvironments, as it doesn't do
anything there.

Thanks Eli,

Guido



>

Re: flycheck orgmode on windows invalid output file name

[Eli Zaretskii]

> From: Guido Van Hoecke <guivho@gmail.com>
> Date: Sun, 5 Jun 2016 21:41:18 +0200
> Cc: help-gnu-emacs <help-gnu-emacs@gnu.org>, orgmode <emacs-orgmode@gnu.org>
> 
> For testing i went to change flycheck-temp-file-system in flycheck.el
> so that it reads
> 
> (setq tempfile (convert-standard-filename (expand-file-name
> (file-name-nondirectory filename)
>            directory)))
> 
> rather than the original
> 
> (setq tempfile (expand-file-name (file-name-nondirectory filename)
>            directory))
> 
> I than edebugged the flycheck-temp-file-system with the
> "c:/Users/guivh/emacs-guivho/.flycheck_emacs-guivho.org[*Org Src
> emacs-guivho.org[ emacs-lisp ]*]") filename, and it nicely produced a
> tempfile where the '*'s are replaced by '!'s.
> 
> Still, when editing elisp blocks from my elisp.org files, I keep
> hitting the '*' problem...

What is "the '*' problem", exactly?

Re: flycheck orgmode on windows invalid output file name

[Guido Van Hoecke]

On 6 June 2016 at 04:29, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Guido Van Hoecke <guivho@gmail.com>
>> Date: Sun, 5 Jun 2016 21:41:18 +0200
>> Cc: help-gnu-emacs <help-gnu-emacs@gnu.org>, orgmode <emacs-orgmode@gnu.org>
>>
>> For testing i went to change flycheck-temp-file-system in flycheck.el
>> so that it reads
>>
>> (setq tempfile (convert-standard-filename (expand-file-name
>> (file-name-nondirectory filename)
>>            directory)))
>>
>> rather than the original
>>
>> (setq tempfile (expand-file-name (file-name-nondirectory filename)
>>            directory))
>>
>> I than edebugged the flycheck-temp-file-system with the
>> "c:/Users/guivh/emacs-guivho/.flycheck_emacs-guivho.org[*Org Src
>> emacs-guivho.org[ emacs-lisp ]*]") filename, and it nicely produced a
>> tempfile where the '*'s are replaced by '!'s.
>>
>> Still, when editing elisp blocks from my elisp.org files, I keep
>> hitting the '*' problem...
>
> What is "the '*' problem", exactly?
>
Filenames with '*'.
Flycheck member lunaryorn accepted to implement your
convert-standard-filename suggestion and implemented it in master.

Thanks again Eli.

Guido

Re: flycheck orgmode on windows invalid output file name

[Eli Zaretskii]

> From: Guido Van Hoecke <guivho@gmail.com>
> Date: Mon, 6 Jun 2016 08:43:00 +0200
> Cc: help-gnu-emacs <help-gnu-emacs@gnu.org>, orgmode <emacs-orgmode@gnu.org>
> 
> >> Still, when editing elisp blocks from my elisp.org files, I keep
> >> hitting the '*' problem...
> >
> > What is "the '*' problem", exactly?
> >
> Filenames with '*'.

But I thought my suggested change fixed that, as the file names no
longer have '*'.  Right?

> Flycheck member lunaryorn accepted to implement your
> convert-standard-filename suggestion and implemented it in master.
> 
> Thanks again Eli.

You are welcome.