From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Alexander Gerds Subject: Re: proposed change of org-gnus-store-link for nnir groups Date: Fri, 18 Dec 2015 07:49:05 +0100 Message-ID: <86mvt8l09q.fsf@biostat.ku.dk> References: <86bn9whtym.fsf@biostat.ku.dk> <871tamaynu.fsf@nicolasgoaziou.fr> <86y4ctfvpn.fsf@biostat.ku.dk> <87si31a1vq.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50731) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9oqo-0002Gv-TP for emacs-orgmode@gnu.org; Fri, 18 Dec 2015 01:49:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9oqk-00024M-45 for emacs-orgmode@gnu.org; Fri, 18 Dec 2015 01:49:14 -0500 Received: from mail-lf0-x230.google.com ([2a00:1450:4010:c07::230]:36343) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9oqj-00024B-Rv for emacs-orgmode@gnu.org; Fri, 18 Dec 2015 01:49:10 -0500 Received: by mail-lf0-x230.google.com with SMTP id z124so61725543lfa.3 for ; Thu, 17 Dec 2015 22:49:09 -0800 (PST) Received: from linuxsund27324 (2803ds5-noe.0.fullrate.dk. [90.184.8.121]) by smtp.gmail.com with ESMTPSA id i66sm2573036lfb.2.2015.12.17.22.49.06 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Dec 2015 22:49:06 -0800 (PST) In-Reply-To: <87si31a1vq.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Thu, 17 Dec 2015 09:57:29 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain yes, I now found the "how to contribute" page :) the updated patch is attached. thanks! Nicolas Goaziou writes: > Hello, > > Thomas Alexander Gerds writes: > >> great. the updated patch is attached. > > It looks good. Thank you. One minor comment below. > >> for ORG-NEWS: >> ,---- >> | *** Links **** Links stored by org-gnus-store-link in nnir groups >> | >> | Since gnus nnir groups are temporary, org-gnus-store-link now >> | refers to the article's original group. >> `---- > > OK. > >> commit f56d29a57ed965029c1b5f3929f3085423e46f18 Author: Thomas >> Alexander Gerds Date: Thu Dec 17 06:57:11 2015 >> +0100 >> org-gnus: avoid links to nnir groups > > "Avoid" > > You also need to refer to the function modified, e.g., > > * lisp/org-gnus.el (org-gnus-store-link): Articles in an nnir group > refer to the original group. > > Eventually, if you haven't signed FSF papers, you also need to add > "TINYCHANGE" at the end of the message. > > Regards, -- Thomas A. Gerds -- Assoc. Prof. Department of Biostatistics University of Copenhagen, Oester Farimagsgade 5, 1014 Copenhagen, Denmark Office: CSS-15.2.07 (Gamle Kommunehospital) tel: 35327914 (sec: 35327901) --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-org-gnus.el-change-nnir-group-reference.patch >From 907bf2c9b474a740f6ec4cbe8a79db1b7d995276 Mon Sep 17 00:00:00 2001 From: Thomas Alexander Gerds Date: Fri, 18 Dec 2015 07:43:38 +0100 Subject: [PATCH] org-gnus.el: change nnir group reference * lisp/org-gnus.el (org-gnus-store-link): Articles in an nnir group refer to the original group TINYCHANGE --- lisp/org-gnus.el | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lisp/org-gnus.el b/lisp/org-gnus.el index c7b46af..11345a0 100644 --- a/lisp/org-gnus.el +++ b/lisp/org-gnus.el @@ -172,10 +172,12 @@ If `org-store-link' was called with a prefix arg the meaning of (subject (copy-sequence (mail-header-subject header))) (to (cdr (assq 'To (mail-header-extra header)))) newsgroups x-no-archive desc link) - (when (eq (car (gnus-find-method-for-group gnus-newsgroup-name)) - 'nnvirtual) - (setq group (car (nnvirtual-map-article - (gnus-summary-article-number))))) + (cl-case (car (gnus-find-method-for-group gnus-newsgroup-name)) + (nnvirtual + (setq group (car (nnvirtual-map-article + (gnus-summary-article-number))))) + (nnir + (setq group (nnir-article-group (gnus-summary-article-number))))) ;; Remove text properties of subject string to avoid Emacs bug ;; #3506 (set-text-properties 0 (length subject) nil subject) -- 2.1.4 --=-=-=--