From: "Sebastien Vauban" <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
To: emacs-orgmode-mXXj517/zsQ@public.gmane.org
Subject: Re: [PATCH] Center currently clocked headline to top of screen
Date: Tue, 10 Sep 2013 11:57:05 +0200 [thread overview]
Message-ID: <86k3ipdmoe.fsf@somewhere.org> (raw)
In-Reply-To: 93522FFB-910F-4EC2-ADBF-115680FAE372@gmail.com
Hi Carsten,
Carsten Dominik wrote:
> On Sep 2, 2013, at 4:02 PM, Sebastien Vauban <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org> wrote:
>> Carsten Dominik wrote:
>>>> El Thu, 22 Aug 2013 10:36:00 +0200 Sebastien Vauban va escriure:
>>>>
>>>>> When jumping to the currently clocked headline (via `C-c C-x C-j'), it
>>>>> seems (to me) more logical to recenter that headline at the top of the
>>>>> screen (vs at the center of the screen, that is the current behavior).
>>>
>>>> Seeing a bit of context is nice; maybe putting it at line 2 or 3 is
>>>> better than at the top and I think it is better than centered. It could
>>>> also be configurable.
>>>
>>> Yup, I have made this a (recenter 2). Non-configurable until arrival of
>>> more votes.
>>
>> I'd vote for (recenter 0), as:
>>
>> - I generally only clock on projects, and
>>
>> - I'm not interested by seeing the last action(s) of the previous project,
>> when jumping to the currently clocking task.
>>
>> May I submit a patch with a configurable variable?
>
> Yes.
Here it is!
Best regards,
Seb
From: "Sebastien Vauban" <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
Date: Tue, 10 Sep 2013 11:52:51 +0200
Subject: [PATCH] Add option with number of context lines before currently clocked-in entry
* org-clock.el (org-clock-goto-before-context): New option.
(org-clock-goto): Use that option.
---
lisp/org-clock.el | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index 524dbf1..c39b589 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -1668,6 +1668,9 @@ Optional argument N tells to change by that many units."
(message "Clock canceled")
(run-hooks 'org-clock-cancel-hook))
+(defvar org-clock-goto-before-context 2
+ "Number of lines of context to display before currently clocked-in entry.")
+
;;;###autoload
(defun org-clock-goto (&optional select)
"Go to the currently clocked-in entry, or to the most recently clocked one.
@@ -1691,7 +1694,7 @@ With prefix arg SELECT, offer recently clocked tasks for selection."
(org-show-entry)
(org-back-to-heading t)
(org-cycle-hide-drawers 'children)
- (recenter 2)
+ (recenter org-clock-goto-before-context)
(org-reveal)
(if recent
(message "No running clock, this is the most recently clocked task"))
--
1.7.9
next prev parent reply other threads:[~2013-09-10 9:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 8:36 [PATCH] Center currently clocked headline to top of screen Sebastien Vauban
2013-08-22 11:36 ` Daniel Clemente
2013-08-30 16:15 ` Carsten Dominik
2013-09-02 14:02 ` Sebastien Vauban
2013-09-02 14:16 ` Carsten Dominik
2013-09-10 9:57 ` Sebastien Vauban [this message]
2013-09-13 6:10 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86k3ipdmoe.fsf@somewhere.org \
--to=sva-news-d0wtavr13harg/idocfnwg@public.gmane.org \
--cc=emacs-orgmode-mXXj517/zsQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).