[PATCH] Re: Bug: `org-agenda-prepare-buffers' fails at (org-refresh-properties "APPT_WARNTIME" 'org-appt-warntime) [8.2.5h (8.2.5h-82-gd91d4b-elpaplus @ /home/wgg/.emacs.d/elpa/org-plus-contrib-20140324/)]

[Sacha Chua <sacha@sachachua.com>]

wgg2@member.fsf.org writes:

> On the latest `org-plus-contrib' build from the org package.el repo, my
> Agenda buffers (for any Agenda command) fail to render properly, with
> these pertinent lines from *Backtrace*:
> Debugger entered--Lisp error: (wrong-type-argument integer-or-marker-p nil)
>   put-text-property(28484 nil org-appt-warntime "60")
...
> I then isolated this to the following lines of function
> `org-agenda-prepare-buffers':
> 	    (or (memq 'appt org-agenda-ignore-drawer-properties)
> 	        (org-refresh-properties "APPT_WARNTIME" 'org-appt-warntime))

I ran into a similar problem with org-agenda-prepare-buffers and the
EFFORT property. This change to org-refresh-properties seems to fix it:

diff --git a/lisp/org.el b/lisp/org.el
index f8615a2..bd9c05e 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -9393,7 +9393,7 @@ property to set."
 	   (save-excursion
 	     (org-back-to-heading t)
 	     (put-text-property
-	      (point-at-bol) (outline-next-heading) tprop p))))))))
+	      (point-at-bol) (or (outline-next-heading) (point-max)) tprop p))))))))
 
 
 ;;;; Link Stuff

The previous version by Bastien used (org-end-of-subtree t t), which had
checked for (eobp) in it, but outline-next-heading returns nil if there
are no further headings.

Sacha Chua