From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Sebastien Vauban" Subject: Re: [BUG] ob-sql.el: probably an extra paren Date: Thu, 21 Mar 2013 09:37:36 +0100 Message-ID: <86ehf9p2r3.fsf@somewhere.org> References: <16047.1363748067@alphaville> <86vc8mtfcx.fsf@somewhere.org> <87fvzqnpfd.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org-mXXj517/zsQ@public.gmane.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org-mXXj517/zsQ@public.gmane.org To: emacs-orgmode-mXXj517/zsQ@public.gmane.org Hi Bastien, Bastien wrote: > "Sebastien Vauban" writes: >> Nick Dokos wrote: >>> Can we please make it an invariable practice to run `make test' before >>> every push? >> >> Isn't it possible to put such in some sort of Git pre-commit hook (or >> pre-push hook), so that it gets automatically enforced? > > If anyone knows how to setup an automated tests framework for Org, feel f= ree > to go ahead, we will use it and monitor broken tests to see what's wrong = in > the code or in the tests or in the environment running the tests. > > Testing is a nice habit to have, but let's not make it a coercive > pre-requisit before pushing patches. > > My whole thinking here is well captured by Rich Hickey: > > http://codequarterly.com/2011/rich-hickey/ > > Fogus: You have been known to speak out against test-driven development. > Do you mind elaborating on your position? > > Hickey: I never spoke out =E2=80=98against=E2=80=99 TDD. What I have sa= id is, life is > short and there are only a finite number of hours in a day. So, we have= to > make choices about how we spend our time. If we spend it writing tests, > that is time we are not spending doing something else. Each of us needs= to > assess how best to spend our time in order to maximize our results, both > in quantity and quality. If people think that spending fifty percent of > their time writing tests maximizes their results=E2=80=94okay for them.= I=E2=80=99m sure > that=E2=80=99s not true for me=E2=80=94I=E2=80=99d rather spend that ti= me thinking about my > problem. I=E2=80=99m certain that, for me, this produces better solutio= ns, with > fewer defects, than any other use of my time. A bad design with a compl= ete > test suite is still a bad design. The text you mention refers about time to write extra test suites. I was referring to simply have "make test" _run_ before being able to push commit= s. Best regards, Seb --=20 Sebastien Vauban