[PATCH] [Babel] Add line number to "Processing code block..." message

[PATCH] [Babel] Add line number to "Processing code block..." message

[Sebastien Vauban]

Hello,

Here is a small patch to improve the messages displayed by Org Babel when
processing code blocks: now, you get the line number added to the output, so
that you can easily find afterward which block had problems, if such things
were reported in the *Messages* buffer.

Best regards,
  Seb

From 9e8b74d881575318ff480f084ac10aea82696904 Mon Sep 17 00:00:00 2001
From: Sebastien Vauban <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
Date: Thu, 7 Nov 2013 16:24:53 +0100
Subject: [PATCH] Improve "Processing Org code block" message

* ob-exp.el (org-babel-exp-src-block): Improve message by adding line number.

---
 lisp/ob-exp.el |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/lisp/ob-exp.el b/lisp/ob-exp.el
index c8479e3..3874338 100644
--- a/lisp/ob-exp.el
+++ b/lisp/ob-exp.el
@@ -110,12 +110,14 @@ none ---- do not display either code or results upon export
 
 Assume point is at the beginning of block's starting line."
   (interactive)
-  (unless noninteractive (message "org-babel-exp processing..."))
   (save-excursion
     (let* ((info (org-babel-get-src-block-info 'light))
+	   (line (org-current-line))
 	   (lang (nth 0 info))
 	   (raw-params (nth 2 info)) hash)
       ;; bail if we couldn't get any info from the block
+      (unless noninteractive
+	(message "Processing %s code block at line %d..." lang line))
       (when info
 	;; if we're actually going to need the parameters
 	(when (member (cdr (assoc :exports (nth 2 info))) '("both" "results"))
-- 
1.7.9

-- 
Sebastien Vauban

Re: [PATCH] [Babel] Add line number to "Processing code block..." message

[Bastien]

Hi Sébastien,

"Sebastien Vauban" <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
writes:

> Here is a small patch to improve the messages displayed by Org Babel when
> processing code blocks: now, you get the line number added to the output, so
> that you can easily find afterward which block had problems, if such things
> were reported in the *Messages* buffer.

(I'll let Eric decide on this one.)

PS: Don't forget to add TINYCHANGE at the end of your patches in such
cases.

-- 
 Bastien

Re: [PATCH] [Babel] Add line number to "Processing code block..." message

[Sebastien Vauban]

Hi Bastien,

Bastien wrote:
> "Sebastien Vauban" <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org> writes:
>
> PS: Don't forget to add TINYCHANGE at the end of your patches in such
> cases.

I thought that the rule was:

    Add TINYCHANGE if less than 20 (trivial) lines; otherwise, you need to
    assign copyright to the FSF -- and, *if you signed the FSF papers, you
    don't need anymore to add TINYCHANGE, whichever the length of the change.*

Is this wrong now?

Best regards,
  Seb

-- 
Sebastien Vauban

Re: [PATCH] [Babel] Add line number to "Processing code block..." message

[Bastien]

Hi Sébastien,

"Sebastien Vauban" <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
writes:

> I thought that the rule was:
>
>     Add TINYCHANGE if less than 20 (trivial) lines; otherwise, you need to
>     assign copyright to the FSF -- and, *if you signed the FSF papers, you
>     don't need anymore to add TINYCHANGE, whichever the length of the change.*
>
> Is this wrong now?

No, that's correct, but I forgot you signed the FSF papers as you
don't appear on http://orgmode.org/worg/org-contribute.html -- can
you put your name there?

Thanks!

-- 
 Bastien

Re: [PATCH] [Babel] Add line number to "Processing code block..." message

[Sebastien Vauban]

Hi Bastien,

Bastien wrote:
> "Sebastien Vauban" <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org> writes:
>
>> I thought that the rule was:
>>
>>     Add TINYCHANGE if less than 20 (trivial) lines; otherwise, you need to
>>     assign copyright to the FSF -- and, *if you signed the FSF papers, you
>>     don't need anymore to add TINYCHANGE, whichever the length of the change.*
>>
>> Is this wrong now?
>
> No, that's correct, but I forgot you signed the FSF papers as you
> don't appear on http://orgmode.org/worg/org-contribute.html -- can
> you put your name there?

It's already in there (since some years): I'm #113 in your list of current
contributors.

Best regards,
  Seb

-- 
Sebastien Vauban

Re: [PATCH] [Babel] Add line number to "Processing code block..." message

[Bastien]

"Sebastien Vauban" <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
writes:

> It's already in there (since some years): I'm #113 in your list of current
> contributors.

Yes, indeed, sorry!  (Was looking for "Séb", not "Seb"...)

-- 
 Bastien

Re: [PATCH] [Babel] Add line number to "Processing code block..." message

[Eric Schulte]

Hi Seb,

Thanks for this patch, I've applied it and then tweaked the wording of
the message.

Best,

"Sebastien Vauban" <sva-news@mygooglest.com> writes:

> Hello,
>
> Here is a small patch to improve the messages displayed by Org Babel when
> processing code blocks: now, you get the line number added to the output, so
> that you can easily find afterward which block had problems, if such things
> were reported in the *Messages* buffer.
>
> Best regards,
>   Seb
>
> From 9e8b74d881575318ff480f084ac10aea82696904 Mon Sep 17 00:00:00 2001
> From: Sebastien Vauban <sva-news@mygooglest.com>
> Date: Thu, 7 Nov 2013 16:24:53 +0100
> Subject: [PATCH] Improve "Processing Org code block" message
>
> * ob-exp.el (org-babel-exp-src-block): Improve message by adding line number.
>
> ---
>  lisp/ob-exp.el |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/lisp/ob-exp.el b/lisp/ob-exp.el
> index c8479e3..3874338 100644
> --- a/lisp/ob-exp.el
> +++ b/lisp/ob-exp.el
> @@ -110,12 +110,14 @@ none ---- do not display either code or results upon export
>  
>  Assume point is at the beginning of block's starting line."
>    (interactive)
> -  (unless noninteractive (message "org-babel-exp processing..."))
>    (save-excursion
>      (let* ((info (org-babel-get-src-block-info 'light))
> +	   (line (org-current-line))
>  	   (lang (nth 0 info))
>  	   (raw-params (nth 2 info)) hash)
>        ;; bail if we couldn't get any info from the block
> +      (unless noninteractive
> +	(message "Processing %s code block at line %d..." lang line))
>        (when info
>  	;; if we're actually going to need the parameters
>  	(when (member (cdr (assoc :exports (nth 2 info))) '("both" "results"))
> -- 
> 1.7.9

-- 
Eric Schulte
https://cs.unm.edu/~eschulte
PGP: 0x614CA05D

Re: [PATCH] [Babel] Add line number to "Processing code block..." message

[Bastien]

Eric Schulte <schulte.eric@gmail.com> writes:

> Thanks for this patch, I've applied it and then tweaked the wording of
> the message.

Thanks!

-- 
 Bastien

Re: [PATCH] [Babel] Add line number to "Processing code block..." message

[Sebastien Vauban]

Hello Eric,

Eric Schulte wrote:
> "Sebastien Vauban" <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org> writes:
>> Here is a small patch to improve the messages displayed by Org Babel when
>> processing code blocks: now, you get the line number added to the output, so
>> that you can easily find afterward which block had problems, if such things
>> were reported in the *Messages* buffer.
>>
>> -  (message "org-babel-exp processing..."))
>> ...
>> +  (message "Processing %s code block at line %d..." lang line))
>
> Thanks for this patch, I've applied it and then tweaked the wording of the
> message.

I thought my wording was more clear from a user perspective, but I don't mind
with yours, and I'm happy that line has been added. Much clearer to use the
information from the *Messages* buffer.

Best regards,
  Seb

-- 
Sebastien Vauban