From: Eli Zaretskii <eliz@gnu.org>
To: "Sławomir Grochowski" <slawomir.grochowski@gmail.com>
Cc: yantar92@posteo.net, emacs-orgmode@gnu.org, emacs-devel@gnu.org,
philipk@posteo.net, stefankangas@gmail.com, larsi@gnus.org,
hmelman@gmail.com, info@protesilaos.com
Subject: Re: [DISCUSSION] "quick-help" popup for org-columns (column view)
Date: Mon, 08 Apr 2024 14:46:24 +0300 [thread overview]
Message-ID: <861q7gyt4f.fsf@gnu.org> (raw)
In-Reply-To: <87frvwl2wv.fsf@gmail.com> (message from Sławomir Grochowski on Mon, 08 Apr 2024 09:38:40 +0200)
> From: Sławomir Grochowski <slawomir.grochowski@gmail.com>
> Cc: yantar92@posteo.net, emacs-orgmode@gnu.org, emacs-devel@gnu.org,
> philipk@posteo.net, stefankangas@gmail.com, larsi@gnus.org,
> hmelman@gmail.com, info@protesilaos.com
> Date: Mon, 08 Apr 2024 09:38:40 +0200
>
> > The idea here was that some other function could rebind
> > `help-quick-sections' dynamically. That way you avoid the redundant
> > arguments (which would all have to be documented).
>
> Is this really a good practice?
> Relying on global variables instead of passing variables as a parameters?
Emacs is full of such practices, so don't worry about that, it's quite
common (and considered good practice) in Emacs Lisp.
> Eli Zaretskii <eliz@gnu.org> writes:
> > In any case, we cannot change the signature of help-quick, since it's a
> > public function.
>
> If I can't modify the function `help-quick' how can I make it work?
You write a new function with the signature you like and make
help-quick call it to do the actual job. Where you want to use the
signature of the new function, you call it directly.
prev parent reply other threads:[~2024-04-08 11:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 19:55 [DISCUSSION] "quick-help" popup for org-columns (column view) Sławomir Grochowski
2024-02-08 22:16 ` Adam Porter
2024-02-08 23:01 ` Stefan Kangas
2024-02-09 23:02 ` Ihor Radchenko
2024-02-10 15:44 ` Philip Kaludercic
2024-02-10 18:04 ` [External] : " Drew Adams
2024-03-20 23:15 ` JD Smith
2024-03-20 14:08 ` Ihor Radchenko
2024-04-06 20:41 ` Sławomir Grochowski
2024-04-06 22:08 ` chad
2024-04-06 22:40 ` Philip Kaludercic
2024-04-07 5:57 ` Eli Zaretskii
2024-04-08 7:38 ` Sławomir Grochowski
2024-04-08 8:24 ` Philip Kaludercic
2024-04-08 19:13 ` Sławomir Grochowski
2024-04-10 8:26 ` Philip Kaludercic
2024-04-10 20:42 ` Sławomir Grochowski
2024-04-11 6:37 ` Philip Kaludercic
2024-04-11 6:58 ` Philip Kaludercic
2024-04-11 8:43 ` Sławomir Grochowski
2024-04-13 8:37 ` Philip Kaludercic
2024-04-15 12:39 ` Sławomir Grochowski
2024-04-16 7:24 ` Philip Kaludercic
2024-04-18 20:55 ` Sławomir Grochowski
2024-05-02 18:04 ` Sławomir Grochowski
2024-04-08 11:46 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=861q7gyt4f.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=hmelman@gmail.com \
--cc=info@protesilaos.com \
--cc=larsi@gnus.org \
--cc=philipk@posteo.net \
--cc=slawomir.grochowski@gmail.com \
--cc=stefankangas@gmail.com \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).