From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marco Wahl Subject: Re: Survey: changing a few default settings for Org 9.4 Date: Wed, 19 Feb 2020 18:57:49 +0100 Message-ID: <84y2sypihu.fsf@gmail.com> References: <87pnebf2ku.fsf@gnu.org> <84k14ikfee.fsf@gmail.com> <87zhde3iue.fsf@gnu.org> <84ftf6k90h.fsf@gmail.com> <87r1yq3ddy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:54005) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4Tbf-0004zF-11 for emacs-orgmode@gnu.org; Wed, 19 Feb 2020 12:57:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4Tbe-0000ns-1C for emacs-orgmode@gnu.org; Wed, 19 Feb 2020 12:57:54 -0500 In-Reply-To: <87r1yq3ddy.fsf@gnu.org> (Bastien's message of "Wed, 19 Feb 2020 14:39:05 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: Bastien Cc: Marco Wahl , emacs-orgmode@gnu.org Hi Bastien and all, >> Subject: [PATCH 1/2] org: Fix corner case for org-kill-line >> >> * lisp/org.el (org-kill-line): Kill _all_ tags when the cursor is on the tags part. > > There is a problem with this patch: when on a empty heading with tags, > killing the tags will let the cursor back right after the last "*". > Not a big deal in most headlines, but when on the first headline, this > leads to an error. Okay. Thanks for this finding. > I think org-kill-line should not try to do too much, and kill only > parts of the tags when the cursor is in the middle of tags is the > right thing to do. Fair enough. I tried to implement the sentence "When after the headline text, kill the tags" from the documentation for org-special-ctrl-k, which I interpreted as kill _all_ tags. Just to make clear my decision for the patch. > As for the other patch, I think it's important to explain that the > whole subtree will be killed, even if not visible -- that's the whole > point of this variable after all. AFAICS the kill of a folded (invisible) subtree is also performed without having set org-special-ctrl-k. So I'd rather say that there is no need for pointing out that behavior in the documentation. > So I'm sorry but these patches can't make it. > > Thanks anyway! You are welcome. That's fine with me. Ciao!