[PATCH][mini] bulk-mark-regexp and -toggle also with time grid

[PATCH][mini] bulk-mark-regexp and -toggle also with time grid

[marcowahlsoft]

[-- Attachment #1: Type: text/plain, Size: 858 bytes --]

Hi!

From the documentation for * in an agenda-buffer (C-h k *):

--8<---------------cut here---------------start------------->8---
* runs the command org-agenda-bulk-mark-all (found in
  org-agenda-mode-map), which is an interactive compiled Lisp function
  in `org-agenda.el'.

It is bound to *, <menu-bar> <Agenda> <Bulk action> <Mark all>.

(org-agenda-bulk-mark-all)

Mark all entries for future agenda bulk action.
--8<---------------cut here---------------end--------------->8---

Currently this is not true if there is a time grid in the agenda buffer.

--8<---------------cut here---------------start------------->8---
G runs the command org-agenda-toggle-time-grid (found in...
--8<---------------cut here---------------end--------------->8---

Please consider to apply the attached patch.


Ciao,  Marco
-- 
http://www.wahlzone.de
PGP: 0x0A3AE6F2

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: bulk-mark regexp and toggle also with time grid --]
[-- Type: text/x-diff, Size: 949 bytes --]

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index dbc9861..c8808e5 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -9680,7 +9680,7 @@ This is a command that has to be installed in `calendar-mode-map'."
 	  (overlay-put ov 'type 'org-marked-entry-overlay))
 	(end-of-line 1)
 	(or (ignore-errors
-	      (goto-char (next-single-property-change (point) 'txt)))
+	      (goto-char (next-single-property-change (point) 'org-hd-marker)))
 	    (beginning-of-line 2))
 	(while (and (get-char-property (point) 'invisible) (not (eobp)))
 	  (beginning-of-line 2))
@@ -9734,7 +9734,7 @@ This is a command that has to be installed in `calendar-mode-map'."
   (save-excursion
     (goto-char (point-min))
     (while (ignore-errors
-	     (goto-char (next-single-property-change (point) 'txt)))
+	     (goto-char (next-single-property-change (point) 'org-hd-marker)))
       (org-agenda-bulk-toggle))))
 
 (defun org-agenda-bulk-toggle ()

Re: [PATCH][mini] bulk-mark-regexp and -toggle also with time grid

[marcowahlsoft]

[-- Attachment #1: Type: text/plain, Size: 286 bytes --]

> (org-agenda-bulk-mark-all)
>
> Mark all entries for future agenda bulk action.

> Currently this is not true if there is a time grid in the agenda buffer.
>
> Please consider to apply the attached patch.

I forgot one line in the previous patch.  Please consider the new patch only.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: bulk-mark regexp and toggle also with time grid patch --]
[-- Type: text/x-diff, Size: 1421 bytes --]

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index dbc9861..1bec8dc 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -9680,7 +9680,7 @@ This is a command that has to be installed in `calendar-mode-map'."
 	  (overlay-put ov 'type 'org-marked-entry-overlay))
 	(end-of-line 1)
 	(or (ignore-errors
-	      (goto-char (next-single-property-change (point) 'txt)))
+	      (goto-char (next-single-property-change (point) 'org-hd-marker)))
 	    (beginning-of-line 2))
 	(while (and (get-char-property (point) 'invisible) (not (eobp)))
 	  (beginning-of-line 2))
@@ -9698,7 +9698,7 @@ This is a command that has to be installed in `calendar-mode-map'."
   (let ((entries-marked 0) txt-at-point)
     (save-excursion
       (goto-char (point-min))
-      (goto-char (next-single-property-change (point) 'txt))
+      (goto-char (next-single-property-change (point) 'org-hd-marker))
       (while (and (re-search-forward regexp nil t)
 		  (setq txt-at-point (get-text-property (point) 'txt)))
 	(when (string-match regexp txt-at-point)
@@ -9734,7 +9734,7 @@ This is a command that has to be installed in `calendar-mode-map'."
   (save-excursion
     (goto-char (point-min))
     (while (ignore-errors
-	     (goto-char (next-single-property-change (point) 'txt)))
+	     (goto-char (next-single-property-change (point) 'org-hd-marker)))
       (org-agenda-bulk-toggle))))
 
 (defun org-agenda-bulk-toggle ()

[-- Attachment #3: Type: text/plain, Size: 79 bytes --]



Sorry for the extra noise,  Marco
-- 
http://www.wahlzone.de
PGP: 0x0A3AE6F2

Re: [PATCH][mini] bulk-mark-regexp and -toggle also with time grid

[Nicolas Goaziou]

Hello,

marcowahlsoft@gmail.com writes:

>> (org-agenda-bulk-mark-all)
>>
>> Mark all entries for future agenda bulk action.
>
>> Currently this is not true if there is a time grid in the agenda buffer.
>>
>> Please consider to apply the attached patch.
>
> I forgot one line in the previous patch.  Please consider the new
> patch only.

Thank you.

Would you mind providing a proper commit message (don't forget the
TINYCHANGE at the end) and send it again using git format-patch?

Regards,

-- 
Nicolas Goaziou

Re: [PATCH][mini] bulk-mark-regexp and -toggle also with time grid

[marcowahlsoft]

Hi Nicolas,

>>> Mark all entries for future agenda bulk action.
>>> Currently this is not true if there is a time grid in the agenda buffer.
>>>
>>> Please consider to apply the attached patch.
>> ...
>
> Would you mind providing a proper commit message (don't forget the
> TINYCHANGE at the end) and send it again using git format-patch?

I did my very best.  See the respective post.  It's actually been my
first git format-patch.  Hopefully it's useful for the integration.


Best regards,  Marco
-- 
http://www.wahlzone.de
PGP: 0x0A3AE6F2