From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marco Wahl Subject: Re: Use Emacs support for image resizing when using org-image-actual-width Date: Thu, 29 Aug 2019 17:39:30 +0200 Message-ID: <84v9ugf0b1.fsf@gmail.com> References: <87k1aw9hvn.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:57831) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i3MWS-0002Ec-V0 for emacs-orgmode@gnu.org; Thu, 29 Aug 2019 11:39:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i3MWR-0006vb-UH for emacs-orgmode@gnu.org; Thu, 29 Aug 2019 11:39:40 -0400 Received: from 195-159-176-226.customer.powertech.no ([195.159.176.226]:53512 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i3MWR-0006rY-NO for emacs-orgmode@gnu.org; Thu, 29 Aug 2019 11:39:39 -0400 Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1i3MWO-000THk-Eg for emacs-orgmode@gnu.org; Thu, 29 Aug 2019 17:39:36 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org Hi Terje! > I am running Emacs version 27 (building from master) and recently > noticed that my images no longer scales using org-image-actual-width. > > I then read that ImageMagick support is no longer enabled by default as > there is a new "native" resizing method built-in to Emacs. > > As seen in the news for on Emacs version 27 (master branch): >> ** Emacs no longer defaults to using ImageMagick to display images, >> due to security and stability concerns. To override the default, use >> 'configure --with-imagemagick'. > > As well as: >> ** Emacs now supports resizing and rotating images without ImageMagick. >> All modern systems support this feature. (On GNU and Unix systems, >> Cairo drawing or the XRender extension to X11 is required for this to >> be available; the configure script will test for it and, if found, >> enable scaling.) > >> The new function 'image-transforms-p' can be used to test whether any >> given frame supports these capabilities. > > I then inspected the code of org-mode and noticed there is an expression > in the cond that figures out how to scale, e.g.: >> ((not (image-type-available-p 'imagemagick)) nil) > > I haven't looked into yet how the scaling is done, but I know some other > modes such as image-mode had support for using the new method. > > I think it would be great to support the native scaling option as well > when available. Since opting in to imagemagick will be Emacs wide and > then we loose the benefit of the new functionality. I committed a fix to the master branch. I think the way was clear. But testing is welcome as always. Thanks, Marco