emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Marco Wahl <marcowahlsoft@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix: Emacs 25 fancy diary inclusion in agenda
Date: Mon, 13 Oct 2014 11:43:42 +0200	[thread overview]
Message-ID: <84iojoz4mp.fsf@tm6592.fritz.box> (raw)
In-Reply-To: 87fveu5wl0.fsf@Rainer.invalid

Hi Achim,

Thanks for your corrections and hints.

>> Patch pushed!
>
> It looks like that patch should have gone to maint rather than master

Sorry for that.  I was not aware that fixes should go to maint.  I just
naively took the first best branch (which was master) for applying the
change.  BTW: It looks like a good soul already merged the patch into
the maint branch.

> and please use a properly formatted commit message in the future:
>
> - The first line of the commit has been taken from the subject of your
>   post rather than being in the form that Org uses.
> - The commit description itself will be shortened to unintelligible
>   gibberish in the Emacs Changelog since the text before the first blank
>   line doesn't actually tell what the change has been about.

A formal error plus unintelligible gibberish.  Hard to imagine how a
commit message could be worse.  I try to be more careful the next time.


Thanks again,  Marco
-- 
http://www.wahlzone.de
GPG: 0x0A3AE6F2

  parent reply	other threads:[~2014-10-13  9:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-10 14:20 [PATCH] Fix: Emacs 25 fancy diary inclusion in agenda Marco Wahl
2014-10-10 16:25 ` Aaron Ecay
2014-10-11 10:36   ` Marco Wahl
2014-10-11 12:38     ` Bastien
2014-10-11 16:20       ` Marco Wahl
2014-10-11 17:45         ` Achim Gratz
2014-10-11 20:36           ` Aaron Ecay
2014-10-13  9:49             ` Marco Wahl
2014-10-13  9:43           ` Marco Wahl [this message]
2014-10-13 16:59             ` Achim Gratz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84iojoz4mp.fsf@tm6592.fritz.box \
    --to=marcowahlsoft@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).