From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marco Wahl Subject: Re: bug? 'org-ctrl-c-ctrl-c-final-hook not run Date: Sun, 17 Mar 2019 20:42:37 +0100 Message-ID: <84imwhi8ya.fsf@gmail.com> References: <23694.38816.468259.88211@AGAME7.local> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([209.51.188.92]:36822) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5brV-0008T7-Ds for emacs-orgmode@gnu.org; Sun, 17 Mar 2019 15:54:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5bgE-0007Y1-H5 for emacs-orgmode@gnu.org; Sun, 17 Mar 2019 15:42:47 -0400 Received: from [195.159.176.226] (port=42090 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h5bgE-0007XX-4p for emacs-orgmode@gnu.org; Sun, 17 Mar 2019 15:42:46 -0400 Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1h5bgB-000yOp-I0 for emacs-orgmode@gnu.org; Sun, 17 Mar 2019 20:42:43 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org thunk2@arcor.de (Thomas Plass) writes: > This is a question for Org API users regarding > 'org-ctrl-c-ctrl-c-final-hook and how it is to be understood. > > As per the docstring > > This can be used to add additional functionality to the C-c C-c key > which executes context-dependent commands. This hook is run after > any other test, ... > > should the 'message in the hook function below be executed? > > (add-hook 'org-ctrl-c-ctrl-c-final-hook > (function (lambda () > (message "org-ctrl-c-ctrl-c-final-hook called from %s" > (org-element-type (org-element-context))) > t))) > > In fact, the hook isn't run at all, although it makes no assumptions > whatsoever about its context. Your hook runs if no other C-c C-c functionality jumped in. You could apply C-c C-c at several locations in an Org buffer to see your hook in action. > Is this the way things are intended or is this behaviour a bug? I guess this is intended. You can add functionality for C-c C-c for locations which don't have C-c C-c functionality yet. > What I'm trying to achieve is to post-process a standard Org element. > However, my target element is already taken care of by one of the > patterns in 'ctrl-c-ctrl-c, so the hook-caller is never reached. Exactly. > As a workaround, I take advantage of the rest of the above docstring > > ... while ‘org-ctrl-c-ctrl-c-hook’ is run before the first test. > > and add to this hook a function that recursively calls > 'org-ctrl-c-ctrl-c before it does its own work - which seems > incredibly kludgy. Possibly it's a good idea to realize the implementation of your idea independent of C-c C-c. And postpone the binding with C-c C-c. HTH, ciao, -- Marco